| Message ID | 1498119011-17798-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | fce136aafe1f51b2dbca1439f3bf31a7e6d32ca9 |
| Headers | show |
> dm: include <dm/util.h> from driver/core/dump.c A typo in the subject. I mean "drivers/core/dump.c" 2017-06-22 17:10 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > Include <dm/util.h> to fix sparse warnings: > symbol 'dm_dump_all' was not declared. Should it be static? > symbol 'dm_dump_uclass' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/core/dump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/core/dump.c b/drivers/core/dump.c > index fd4596ee68b7..c3e109e7ed11 100644 > --- a/drivers/core/dump.c > +++ b/drivers/core/dump.c > @@ -8,6 +8,7 @@ > #include <dm.h> > #include <mapmem.h> > #include <dm/root.h> > +#include <dm/util.h> > > static void show_devices(struct udevice *dev, int depth, int last_flag)
On Thu, Jun 22, 2017 at 4:12 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: >> dm: include <dm/util.h> from driver/core/dump.c > > A typo in the subject. > I mean "drivers/core/dump.c" > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 22 June 2017 at 02:10, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Include <dm/util.h> to fix sparse warnings: > symbol 'dm_dump_all' was not declared. Should it be static? > symbol 'dm_dump_uclass' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/core/dump.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Simon Glass <sjg@chromium.org>
On 22 June 2017 at 02:10, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Include <dm/util.h> to fix sparse warnings: > symbol 'dm_dump_all' was not declared. Should it be static? > symbol 'dm_dump_uclass' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/core/dump.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/drivers/core/dump.c b/drivers/core/dump.c index fd4596ee68b7..c3e109e7ed11 100644 --- a/drivers/core/dump.c +++ b/drivers/core/dump.c @@ -8,6 +8,7 @@ #include <dm.h> #include <mapmem.h> #include <dm/root.h> +#include <dm/util.h> static void show_devices(struct udevice *dev, int depth, int last_flag) {
Include <dm/util.h> to fix sparse warnings: symbol 'dm_dump_all' was not declared. Should it be static? symbol 'dm_dump_uclass' was not declared. Should it be static? Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/core/dump.c | 1 + 1 file changed, 1 insertion(+)