From patchwork Fri Jun 23 09:25:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 106251 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp112353qgd; Fri, 23 Jun 2017 02:26:19 -0700 (PDT) X-Received: by 10.99.109.201 with SMTP id i192mr6999752pgc.204.1498209979668; Fri, 23 Jun 2017 02:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498209979; cv=none; d=google.com; s=arc-20160816; b=qOohdofnb6iQYBM6p18ljNtSO14Ir1grdDr277L39I/Lq44O9QWECrnuaGsQ/anNIE zExzLg4cEfn8tQkV/ySkfAJvqNhXd0eqdYkTLDVNTUAWeGUpRZUcxvhigqZQzcghytVr wVFeAWnC/ql+Jakm1Wy3pK1/Z2oMxBdE7Ph4OiBc7JVFncZGe9RwTQ88RiyZqnXKJ2Ia 5a93kBSiXk3aladKRp48eokv5S8ouNc73QbPGFRySRzcM92OHdrQ21OEtuqH8PGLBXNg 6BYVbBJclOCfwBnb58gFEnrdSLyzqU05nUpTOWtR43tQZZud7Yq+idO3sHti9hojPhia VFdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=lihHQjANG7Q9kkJpE2pXSMRZHZddthkCihNLD7YXaYc=; b=Up986VKhdWyYpa5+N9xUVn7tkZkaN+p7OaNhLKStWg8i4UyuxGA52T2zzPvqn+FJuy qFx9SVw9KGmjP9Pb5ypgTniwlE08rM+HRXXN9yQIuMgo6FsT6cdP821se74nIIyRXQ3M 66uVVSQv+53I0+y0f6j6dtdwbkhXi//+chyM7p0kOs5MyP0HsKB98/CPOsWKTvNR3H21 KYdZIPih35qWRQ1mLIz5QMPWqbDpfvhGPZF30j39oNsS5qOc73ueYKft9MJ/MsDoXUPs iThJA+B619YMKi8FkHMKPA8EQweo7wJiFs1m9nUx8VFnHvJu1CuBQ0g4CfELeDKHRBGf NSjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=aPcRIzD2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t18si2984519pge.491.2017.06.23.02.26.19; Fri, 23 Jun 2017 02:26:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=aPcRIzD2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754684AbdFWJZy (ORCPT + 25 others); Fri, 23 Jun 2017 05:25:54 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:36682 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbdFWJZr (ORCPT ); Fri, 23 Jun 2017 05:25:47 -0400 Received: by mail-pg0-f52.google.com with SMTP id u62so19024650pgb.3 for ; Fri, 23 Jun 2017 02:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=lihHQjANG7Q9kkJpE2pXSMRZHZddthkCihNLD7YXaYc=; b=aPcRIzD2BU24D5yfW8Y46h+uqz/6QPkkNL5RlW4g2kaS/DJVxdVCRQEBYe5308c+wO 3zRdxyAO+O5cJrxfu9wY2Jue8+JSCNzjViCRTuH5ii54hE6Q8SvyzcHkeD3+Dc8qEKQZ oJ0l6Z2WtDP6nyuQdzqM6fJ+b3Ij7zcXSOZqQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=lihHQjANG7Q9kkJpE2pXSMRZHZddthkCihNLD7YXaYc=; b=tTl2yZbYuKkyTy0qzWsn6BIvsD38CdhLEjWLwdD9vPlPOaV2JqLNI4ck4VaUmC5X7m os6mvGio8ndrZm2ZL0LvbClJ0SYoVVJ5qPh/R9Pg0WVREoLPmDnLPOz1WRzSYJ76eosf D2BDSiQpVoAuuX5W1ViXWdfbllwHqOOUVKTBTEs0PZOjfAOYdxy150xtQ6WPNGytG1G8 1OeGkQxqw2Hx1EfPO5YAv+J6IbGvpjyvLvTRz5eaQbTZhSdKdzopWicIETbrVB39oz/z WGtFoyBYP3GhJH2zbaSdDzRuBiQ3Al3IWvMtDVJmg1NduSXN6rnpoP9pecaAYVWBWM7H F+hA== X-Gm-Message-State: AKS2vOyq3SJK0g9z/ZqBqho6mnQvyx3yU0ZY0qPXVtSJt2u7rRf1FuRY Znjw+u8T/ZoNdH6N X-Received: by 10.84.150.164 with SMTP id h33mr8128856plh.152.1498209946808; Fri, 23 Jun 2017 02:25:46 -0700 (PDT) Received: from localhost ([122.172.59.234]) by smtp.gmail.com with ESMTPSA id 24sm8993776pfs.58.2017.06.23.02.25.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 02:25:46 -0700 (PDT) From: Viresh Kumar To: Juri Lelli , Greg Kroah-Hartman Cc: Viresh Kumar , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux@arm.linux.org.uk, Will Deacon , Vincent Guittot , arnd.bergmann@linaro.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/5] arch_topology: Change return type of topology_parse_cpu_capacity() to bool Date: Fri, 23 Jun 2017 14:55:32 +0530 Message-Id: <23788541e21b137b0f868f9da3ab1c4db028debc.1498209817.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.13.0.71.gd7076ec9c9cb In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org topology_parse_cpu_capacity() returns 1 on success and 0 on errors. Make it return bool instead of int as that suits the purpose better. Signed-off-by: Viresh Kumar --- drivers/base/arch_topology.c | 8 ++++---- include/linux/arch_topology.h | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.13.0.71.gd7076ec9c9cb diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index a3cd7c869c3e..5728e2fbb765 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -119,13 +119,13 @@ void topology_normalize_cpu_scale(void) mutex_unlock(&cpu_scale_mutex); } -int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) +bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) { - int ret = 1; + int ret; u32 cpu_capacity; if (cap_parsing_failed) - return !ret; + return false; ret = of_property_read_u32(cpu_node, "capacity-dmips-mhz", &cpu_capacity); @@ -137,7 +137,7 @@ int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) if (!raw_capacity) { pr_err("cpu_capacity: failed to allocate memory for raw capacities\n"); cap_parsing_failed = true; - return 0; + return false; } } capacity_scale = max(cpu_capacity, capacity_scale); diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h index 9af3c174c03a..716ce587247e 100644 --- a/include/linux/arch_topology.h +++ b/include/linux/arch_topology.h @@ -4,10 +4,12 @@ #ifndef _LINUX_ARCH_TOPOLOGY_H_ #define _LINUX_ARCH_TOPOLOGY_H_ +#include + void topology_normalize_cpu_scale(void); struct device_node; -int topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu); +bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu); struct sched_domain; unsigned long topology_get_cpu_scale(struct sched_domain *sd, int cpu);