From patchwork Mon Jun 26 18:01:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 106371 Delivered-To: patch@linaro.org Received: by 10.140.101.48 with SMTP id t45csp275906qge; Mon, 26 Jun 2017 11:03:23 -0700 (PDT) X-Received: by 10.200.52.129 with SMTP id w1mr1904709qtb.77.1498500203557; Mon, 26 Jun 2017 11:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498500203; cv=none; d=google.com; s=arc-20160816; b=UQrBZbN7DGhYA71gf33YaGv6Qpevj/hWFz8g2ztAaUN+GGs6/59I7unFiJ4UoHtgyj qHAfONrDKGvLqkpC4BvrgErI6MAzH6CDd9jvDvc1+m8fIPo/QR4h6w6KblgiXYP0Fo8F Oz26eBkUlkTdipkEQIaSCU61h6QuXXGu85fjIKffq/mf6qxLJX2O+ojrdIG+r5nj1jRm BI0XuYdw1XKzvvtYBXYg4JhGNye2ti6U6YFVsKP+iUHJdFTVXrrMWrvczUMlxwx/HJqd TE+/s87+fwMoKW6d7Ul+hrBAfxuD+R0UK5GCSfxQGS3iBqBuwYBQ0xejzRE2FUcU5AgY TYjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:references :in-reply-to:message-id:date:to:from:delivered-to:dkim-filter :dmarc-filter:arc-authentication-results; bh=bnMi5iVV3y68hJGWDWLAI1rM6qlbtOeeDTCov67G5ks=; b=SH/g+7+RhFExIEMJ00fDKvFTgwDM19FzkzO/ivla2qvEDtEHa+TQHYwlA23H1jgrK5 jfsqTnexatTKf4ofjBW2dvXwdH9i+XBpwL3FD5tYXLmDt3xouWuYh9L42hlZhJjHyh5m 9wVpKQ5/AsaF1FIu7k40CmEQU55qs7D7y+X823quvycmWPsAfRNfXVVX6QF16X1E3VdZ ipsrXHLNxH1p6K//OdeTycpcyf6DOcvCPlJ+vmIVLGgkOmWxpBBHp0N6vD/Sb/lqCVzG +7BJ1T9kiy63gd6KQm98aakosNFHzlqETe6i4V3PHeyJ+FeMDbGX/m8Ziw/0THpz2qVt jjhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id m28si615141qki.156.2017.06.26.11.03.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jun 2017 11:03:23 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC37A40F10; Mon, 26 Jun 2017 18:03:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC37A40F10 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EC37A40F10 Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6C1E7EA3A; Mon, 26 Jun 2017 18:03:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6758127F; Mon, 26 Jun 2017 18:03:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v5QI22om007877 for ; Mon, 26 Jun 2017 14:02:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 794497E48D; Mon, 26 Jun 2017 18:02:02 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from worklaptop.redhat.com (ovpn-117-115.phx2.redhat.com [10.3.117.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2E7B7E497; Mon, 26 Jun 2017 18:02:00 +0000 (UTC) From: Cole Robinson To: libvir-list@redhat.com Date: Mon, 26 Jun 2017 14:01:42 -0400 Message-Id: <7bd360f9f9510cfa9ff3a04def6ef1f2d537c2b6.1498499391.git.crobinso@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: cdall@linaro.org, drjones@redhat.com, riku.voipio@linaro.org, Andrea Bolognani Subject: [libvirt] [PATCH 01/12] Revert "qemu: Support chardevs with ARM virt machines" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 26 Jun 2017 18:03:22 +0000 (UTC) This reverts commit 70c9b44270f75bfb7a5701d81aa49380d139e8f0. This commit breaks existing aarch64 machvirt configs with: Which fails with: error: Failed to start domain fedora25-aarch64 error: internal error: process exited while connecting to monitor: 2017-06-26T13:55:34.726293Z qemu-system-aarch64: -chardev pty,id=charserial0: char device redirected to /dev/pts/5 (label charserial0) 2017-06-26T13:55:34.782121Z qemu-system-aarch64: -device isa-serial,chardev=charserial0,id=serial0: No 'ISA' bus found for device 'isa-serial' Signed-off-by: Cole Robinson --- src/qemu/qemu_capabilities.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.13.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Andrea Bolognani diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 12d9477cf..61c9a1066 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5573,11 +5573,6 @@ virQEMUCapsSupportsChardev(const virDomainDef *def, if ((def->os.arch != VIR_ARCH_ARMV7L) && (def->os.arch != VIR_ARCH_AARCH64)) return true; - /* The virt machine has a PCIe bus and allows plugging in the same type of - * devices as x86 systems do on a PCIe bus. */ - if (qemuDomainIsVirt(def)) - return true; - /* This may not be true for all ARM machine types, but at least * the only supported non-virtio serial devices of vexpress and versatile * don't have the -chardev property wired up. */