From patchwork Tue Jun 27 13:21:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 106422 Delivered-To: patch@linaro.org Received: by 10.140.101.48 with SMTP id t45csp1197777qge; Tue, 27 Jun 2017 06:22:39 -0700 (PDT) X-Received: by 10.200.12.198 with SMTP id o6mr3095173qti.230.1498569759218; Tue, 27 Jun 2017 06:22:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498569759; cv=none; d=google.com; s=arc-20160816; b=C9Kvljsa/v0TZlyYWTH553cotOQwuuLOgg7r/LUK9uZebscL4GgnPA4xIHKxl70vxA LleVF9p0dRhHtgg73Dy+KiMu/My2fOOl6wV9pDU+VOdK6+W5Afa838/xrsdDoLCdJzVk yFQIKABGpokEHQKP8smQ2S+qTpBuzN8UjE3GrGsHiihzsAJ47dbe0FCjh63YqyPlTh83 GzI7kiKeICamIlDIKPrQ12UBQkZ/DSliW/1/30nYPlsJy+kvcsBxMzSbWvcZ6cZKoLuf qSY5AgyxRxS7+aq/hXIgVR8qRYRvc7b3lNmNAK310OVEqU4BxhDRgk/ZHfsv8k2F8EMQ zcFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:delivered-to:arc-authentication-results; bh=JhGdylTTI5eyOgcl1vshO2EdQay4TA1UoOeh9ntb1PU=; b=w2ffBhTrDIViG8E0FbIp3jw/c4VAKQVDB7mumLityk0RynkUOQaf/Rs9rucuIM79xR TIPYI0calwW4VNPwTG6+CiltjRwofXK+2rbsrbl6YxOY0EgNZVmn8pchGSXzy57YM+Dh z2x1QVhYY8G9zRVltYlZm3RjeI99vJGxgmI272DXUAswkFYbngK7IsrAA5zbUEaJwXG+ eqN/n+HnzNPo/Q5/6gjkGCrY07oJbz2TrQ06Sz4TcgtzFBt7I7mgGPWy6mryVwl+8ODe sOaexmY423Fa+etQ7szrJmjcuE4XgKa8yAjkr8/hoilFLZ4vpA2iVNp9r4ajiihBCJIP JByg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 46si2755124qts.227.2017.06.27.06.22.38; Tue, 27 Jun 2017 06:22:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DFFD660C24; Tue, 27 Jun 2017 13:22:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 6B8A660D12; Tue, 27 Jun 2017 13:22:21 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id F2E4060C19; Tue, 27 Jun 2017 13:22:17 +0000 (UTC) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by lists.linaro.org (Postfix) with ESMTPS id 18BA360C19 for ; Tue, 27 Jun 2017 13:22:00 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id z75so5691528wmc.0 for ; Tue, 27 Jun 2017 06:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cQmFM8zNpkwadVM7kNk4XUaHdUOsBULlRsjDY9WhgFw=; b=R+zbBmZlP5alwRNNMe43Q2SHTpDvjJWb7IOwSoZousM3H2zshcqfrFs+eYES6VHunL wNWIYZmaKnveT+y0DQkflbeybO31vfflQHkII/CKXOyQbyOIZl/YGG6PaG40PwJ3XolW Q+o6FFvryl5Qde7vOXMB1Z7z5tcC17c1bmOSnRfY+9yqWF4PqAm3blLWJqY6qsZ2t3TE 6x3wpu+J+5AV6k0LzU0B1cZfsXp3QJWhHgMXy673v4hWWysd9bLykjx6/BPXOBnJVoMC 9CmkHvJV9BY/Uv6vgqcZJWYMY5uxicfcAoX6edVEk1dtHeCJ3ywE/AUpHw/657YcKfB3 +TTQ== X-Gm-Message-State: AKS2vOw1yoaLo++XRU6hNDQbQb4Y875xIblSrRX9St7+TQ/gzYUwQFVu Q3aNFrUqsTIR39mMMLMdsT3s X-Received: by 10.28.50.200 with SMTP id y191mr3517559wmy.104.1498569718888; Tue, 27 Jun 2017 06:21:58 -0700 (PDT) Received: from localhost.localdomain ([105.133.250.69]) by smtp.gmail.com with ESMTPSA id p99sm18801062wrb.6.2017.06.27.06.21.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jun 2017 06:21:58 -0700 (PDT) From: Ard Biesheuvel To: linaro-uefi@lists.linaro.org Date: Tue, 27 Jun 2017 13:21:37 +0000 Message-Id: <20170627132145.28159-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170627132145.28159-1-ard.biesheuvel@linaro.org> References: <20170627132145.28159-1-ard.biesheuvel@linaro.org> Cc: rfranz@cavium.com, alan@softiron.co.uk Subject: [Linaro-uefi] [PATCH v2 02/10] Platforms/AMD/Overdrive: disable second SATA port X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "For discussions about Linaro-related UEFI development. Not a substitute for edk2-devel." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" The second SATA port is only available on B1 silicon, but as it turns out, not on /all/ versions of it: the Overdrive 3000 is B1 based as well, but any attempts to use the second SATA controller cause the firmware to crash. So just disable it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc index 7ac3ce3760fa..9d533149af07 100644 --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc @@ -409,10 +409,13 @@ DEFINE DO_KCS = 1 gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xE112F000 # - # Overdrive B1 has 14 SATA ports across 2 controllers. + # AMD's B1 based Overdrive has 14 SATA ports across 2 controllers. However, + # it appears that Softiron's Overdrive 3000, which is also B1 based, does + # not have the second SATA controller enabled, and any attempts to use it + # will crash the firmware. So use the first controller only. # gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8 - gAmdStyxTokenSpaceGuid.PcdSata1PortCount|6 + gAmdStyxTokenSpaceGuid.PcdSata1PortCount|0 # PCIe Support gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000