From patchwork Wed Jun 28 11:19:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fathi Boudra X-Patchwork-Id: 106517 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp888469qge; Wed, 28 Jun 2017 04:20:12 -0700 (PDT) X-Received: by 10.84.231.198 with SMTP id g6mr11152575pln.110.1498648812385; Wed, 28 Jun 2017 04:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498648812; cv=none; d=google.com; s=arc-20160816; b=Lei0iSjS3LoWhw9Vz+u05idOEId58majBO8maO2bWfeM+t1RkulVPfG2jRyd4O9PFy 7fw8OMz6F75fEK1IJEpsNIAu2/iJ/Ck++iea+/WNe1Eks9D+KEYkIm8ybwezhB5KTmuu rGuW26gIDlalseBsGrlvKRULFAgr381tuEWQIoW5Z8XYggaHkP5VxzRB6TG2BxC2UNQO /sAZhQFb0cI2jchrSsppon+69F2Sfrk1adTyZrgr6iq0eq6XuORoC9ptn9Y3O9mQ/l2w k17hrICoHj7fIQPeanw5a5Ib+dNiX1aYzZFq43zBwS8JbM8gKosi5RzhfFNr9p/NCXNK Z4bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=p5W6yCBP1nOnP+FUNn/HzHXsLlLioAEqaEhTdFVuemU=; b=AP/DWmCgwT9VTj14TMEk4DNidOcnF2fLS7oLOYgopUiDg0QBcicCq56IqBRLQcKa+/ jccWPJBmM98FjF6eEUqNt+20dOcAv/q+j8ZH7ZIRoqkafOSw2EaQg5PjLm++mo1B3te5 GWu+BUzYtmTKr3KTesqoob4raSrlthBO3019XIKsOidErVV3SAUoJdxw4YraSa/9gTZ5 UcUhdHZhFR8mlu+hbG/QD3oWOjXvAKSJGNd1KxGJ31CTpH2zZFpLfRQkYvk2CygIn+Yp cX0Vlt+SuR5aMQyvc4gAxvw/u1sfeyjCyOMAG+cccTuF6krWroSrgO6sZIJIDLJVLMMv sevg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=Fwitp07E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si1359384pgu.95.2017.06.28.04.20.11; Wed, 28 Jun 2017 04:20:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=Fwitp07E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535AbdF1LUK (ORCPT + 25 others); Wed, 28 Jun 2017 07:20:10 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33549 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdF1LUD (ORCPT ); Wed, 28 Jun 2017 07:20:03 -0400 Received: by mail-lf0-f50.google.com with SMTP id m77so32910641lfe.0 for ; Wed, 28 Jun 2017 04:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=p5W6yCBP1nOnP+FUNn/HzHXsLlLioAEqaEhTdFVuemU=; b=Fwitp07E/RIwn/QRvF4cAV0RuBm/Tfv5ccP1JRhPLkDInLK6ep1GuANtsAK57m5uKm mlls5Zhxfh6t+NuJjYQGGBk62VF88TeFbmkZDfmXho+lZF0Z9n1rl/anhRG8N1KZWPZq JSEn9kr3IPhLqSdNRqqdnw67c9oBqjCk7kMuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p5W6yCBP1nOnP+FUNn/HzHXsLlLioAEqaEhTdFVuemU=; b=TBCKRyeHci4cb5dNpPq9xsbJbkZG7J4/bm94g/SYWqpsvu7cxGcjIAAORP2Nhs+bc/ fFGZ9487rHXcxwgYlprp3iBE7KmJOAT8MQl9UV/YPxGJmEEZT3e42MASaHOfxzCceCK0 z54+X1xqA2xt+gc8BMFWDgmu+ydpVYR0wU2iNQ170HyEWo8M0y+pruEbdWAsWRlTnlRC ovjmhXjffd37TrUrHFkHQv3aI+1lyuRtqhv9oXNi1auPlF27Momf9x7PUZiha0WVdxQz 97hQicrr3GbX/H5G2RjcAQyijDX32kNbl5SYbicznzHDNvZDDziELWBXYATh5aRgrrI7 KhQQ== X-Gm-Message-State: AKS2vOwlRRyTlG16YtRuvPmTkGD89srVMlQxooKKm2RkfCI5up3omusu Uq1h9DNuGLSb/dtH X-Received: by 10.46.75.1 with SMTP id y1mr3010177lja.128.1498648802097; Wed, 28 Jun 2017 04:20:02 -0700 (PDT) Received: from localhost.localdomain (a91-156-68-101.elisa-laajakaista.fi. [91.156.68.101]) by smtp.gmail.com with ESMTPSA id l69sm471951lfl.10.2017.06.28.04.20.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 04:20:01 -0700 (PDT) From: Fathi Boudra To: linux-kselftest@vger.kernel.org, Shuah Khan Cc: linux-kernel@vger.kernel.org, SeongJae Park , Fathi Boudra Subject: [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma Date: Wed, 28 Jun 2017 14:19:58 +0300 Message-Id: <20170628111958.22405-1-fathi.boudra@linaro.org> X-Mailer: git-send-email 2.13.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org reuseport_bpf_numa fails to build with undefined reference: aarch64-linaro-linux-gcc --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall -Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c -o /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa /tmp/ccfUuExT.o: In function `send_from_node': /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138: undefined reference to `numa_run_on_node' /tmp/ccfUuExT.o: In function `main': /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230: undefined reference to `numa_available' /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233: undefined reference to `numa_max_node' Use LDLIBS instead of LDFLAGS to properly link against libnuma. Signed-off-by: Fathi Boudra --- tools/testing/selftests/net/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.13.0 diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index 35cbb4cba410..17c732a19c4c 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -3,7 +3,7 @@ CFLAGS = -Wall -Wl,--no-as-needed -O2 -g CFLAGS += -I../../../../usr/include/ -reuseport_bpf_numa: LDFLAGS += -lnuma +reuseport_bpf_numa: LDLIBS += -lnuma TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh TEST_GEN_FILES = socket