| Message ID | 20170628200530.3070052-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
On Wed, 2017-06-28 at 22:05 +0200, Arnd Bergmann wrote: > I ran into a build error: > > kernel/sched/fair.c:2655:44: error: 'struct sched_domain' declared > inside parameter list will not be visible outside of this definition > or declaration [-Werror] > > Adding a forward declaration for the struct name is sufficient > to avoid it. > > Fixes: 3fed382b46ba ("sched/numa: Implement NUMA node level > wake_affine()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Peter pointed out another problem with that patch. I am running a few tests now on a kernel with that other bug fixed, which should also magically get rid of this compiler warning. -- All rights reversed
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6f4f155adf5f..eea8f0b7d9c0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2652,6 +2652,7 @@ static inline void account_numa_dequeue(struct rq *rq, struct task_struct *p) { } +struct sched_domain; static inline bool numa_wake_affine(struct sched_domain *sd, struct task_struct *p, int this_cpu, int prev_cpu, int sync)
I ran into a build error: kernel/sched/fair.c:2655:44: error: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Adding a forward declaration for the struct name is sufficient to avoid it. Fixes: 3fed382b46ba ("sched/numa: Implement NUMA node level wake_affine()") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/sched/fair.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0