From patchwork Fri Jun 30 05:46:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 106675 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp1904915qge; Thu, 29 Jun 2017 22:47:40 -0700 (PDT) X-Received: by 10.99.3.216 with SMTP id 207mr19230406pgd.161.1498801660390; Thu, 29 Jun 2017 22:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498801660; cv=none; d=google.com; s=arc-20160816; b=wNGocBzQN/tyHWkPw7rqeZRlbzM3W2LdkqIBxu/6wa5GO4/kDXRdc7zHofI5PlW5TA +Nf4Jj9b8bPbW9Kay+md97pOjC9MvEDViHuIIYgsjl5giXxIOjCGrDNbkQhIvx2UUvnv oNPOWJ4BdSa/iiBAa5NxMXy2tqVqs/PheCiLaddOYK44+EV690/Ntz9yaQsnTC8I2kf7 SKWrvA3LRltrZi/gTFSTQFaV7FgwMXygkNeoY89XldX2Bkls/UBx1MdUmxLNZfuq5084 hfLNqWginjORG0c8pK5gcxfrVwIlC9xLkrV6R2lRfsKZQ7VIml+pUlT2CvaTecScWlCI PqPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=r/fACoYiFik/Y/lawDmgBYOqr+/ZcgrbnJWZK+GRe5k=; b=OhqGoVdoihRF5aTihGwLW1lIgMWC5DDnbLHS9VLDXS9ARDwkKNkJme2guwO8PjNm7P dBv/WJZlh9/Digt4WsLRUkcoLceHgUAF7k33bWYdL2QEfWB8ucLCCmDnBEWQqTaGJYSZ p1Yy2dzPbSSgZlG6313pzioYXXt6RcU6OKiZLU+RqpkcSES4sC7jLV/K+MfNIuip6NlX 0oKc+dV7GyvIE967J+73KyFMenf2kbQpbZXojxTIuZqOEIn5Pbdx//AA1nvDNXP+Xi9P G9JnUBuE9zztlqcG2xUe1LJ6ecLiPr7qjPBy4KdjWTx8HLYt+aYorA18I6x8Z40eoaSz iTmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=g+RDsMzb; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si4519277pgj.463.2017.06.29.22.47.40; Thu, 29 Jun 2017 22:47:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=g+RDsMzb; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdF3Fri (ORCPT + 6 others); Fri, 30 Jun 2017 01:47:38 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35237 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbdF3Frg (ORCPT ); Fri, 30 Jun 2017 01:47:36 -0400 Received: by mail-pf0-f171.google.com with SMTP id c73so61644183pfk.2 for ; Thu, 29 Jun 2017 22:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r/fACoYiFik/Y/lawDmgBYOqr+/ZcgrbnJWZK+GRe5k=; b=g+RDsMzb4n091vnzhKhc2vSEI0dmtFDySVPwoBSS9aIMwZNKsa8G/KZ87fn2FWSqnh Fn2PRUOPvD0V2uHdq23mtZTeNc6e+eoImWqptOBZNFAKvHhfZMzhvGtU4WUZjOj+JDr4 GL2JzVodBTjRivSzmIuNqctreOorYqrz3gnzk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r/fACoYiFik/Y/lawDmgBYOqr+/ZcgrbnJWZK+GRe5k=; b=poapr4kwsRm0iaa5uwVsa9Uq9HWsoaspwz1GydZyn3yKJBSyVUVCzmC0PE2SkgQXcf q9RVZyI0HoU5ABwdxsWyf+H7UtGTSXh5SMRhAXgm0Kth/+m9pMvTzoWdPBqhiiAm/FmD B4rZiFBx12jLm9G5/K7oWT31BOT85/HXgkNFxPJ+Dukb4xdYZ8bLn4+ZDoz4ACgVbX5y t25LdIzNkOoCPZ/xFylatJ0H6grZ+BqJ+uIUBEWIR7yPoa4R12ZatErdpSrGCfTlbByx RZle4p4peLIbX058kinrBER3UwtiQke/oUEGV9c/3NTyZNASjosFkH80EJsN61qPW3vd uk/A== X-Gm-Message-State: AKS2vOy+E7T3xXGVp8zzYMWGCkCgxb7LrxC37I7JKLWn0GpOY0xY31kC ItPNGWFHR0oDUk8n X-Received: by 10.98.87.29 with SMTP id l29mr20528326pfb.3.1498801655360; Thu, 29 Jun 2017 22:47:35 -0700 (PDT) Received: from localhost.localdomain ([106.51.129.233]) by smtp.gmail.com with ESMTPSA id a187sm11405550pgc.37.2017.06.29.22.47.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Jun 2017 22:47:34 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Florian Fainelli , "David S . Miller" Subject: [PATCH for-4.4 16/16] net: bgmac: Remove superflous netif_carrier_on() Date: Fri, 30 Jun 2017 11:16:40 +0530 Message-Id: <1498801600-20896-17-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498801600-20896-1-git-send-email-amit.pundir@linaro.org> References: <1498801600-20896-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Florian Fainelli commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream. bgmac_open() calls phy_start() to initialize the PHY state machine, which will set the interface's carrier state accordingly, no need to force that as this could be conflicting with the PHY state determined by PHYLIB. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Amit Pundir --- drivers/net/ethernet/broadcom/bgmac.c | 2 -- 1 file changed, 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index a01f62ec12bb..70da30095b89 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1308,8 +1308,6 @@ static int bgmac_open(struct net_device *net_dev) phy_start(bgmac->phy_dev); - netif_carrier_on(net_dev); - netif_start_queue(net_dev); return 0;