From patchwork Sun Jul 2 14:42:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 106861 Delivered-To: patch@linaro.org Received: by 10.182.135.102 with SMTP id pr6csp8295504obb; Sun, 2 Jul 2017 07:47:37 -0700 (PDT) X-Received: by 10.84.128.14 with SMTP id 14mr5777458pla.285.1499006857389; Sun, 02 Jul 2017 07:47:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499006857; cv=none; d=google.com; s=arc-20160816; b=i3GjBpHwo68O5FADGbs11DmsIHHAS+L27yZ5zIuYgocjErS9tVtDPfcb7YUOUM8KLv JMM8B+G0mmu6KPTGFzP2GyrhqyBLcXzOEx+eAqrCq9AFuh6NsHLSxMFdSdcqB+aDEAGR 7SMqhmxm0NmcFnALGJbfTe7HiKqHvF8JQHLtvGfR08W1DBLt4ea9SX364VH31oHhSvUa iWiovtIUc553zP5HGYY7aDqu3GAVTBeaNUP+xqGYL88mDY7qkE0mgTnKJtFVj+mTof01 mRpI/G2HuglGqlmdjEdqhl4uKJebLradraCIYErEK3zZhvklNKQrv7WmMAc9GOuGojtJ 9LTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=+9UYqrNtfXheaFFtShApRws/5GiiNFcfxJCyinCxixc=; b=OgSqb3zgZOC6qlqRlargZ3BHDTlhi1jBzUZO2GlZC7g+mod0NaOPNMmQySmRmmWAGd eJhTqvPLkZWEcdQ4puUDnbnrKoVZi2gkWVM4nyITGWiLc32MpbW31VnKazUSHFgcrQ+Q mRi3DLw3ECjG5dEXc8MWDD601qrIYWwoPxMsXrU1WOFBukU/zp0wF5rtf+Y82EofY2Qo KA/csF/OhXyrIPChX4hCQsxbHs3xO42famMf7AR9aPqMqRI4wuFfQ7RicLpEVLINnJXX Nqwh5xPnRCrTqjj4uaNSON742fWtg2kjE1F7fUJXw7Kj3HW70RlH6orSSYjBMfvQczDT TNHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si11127819pli.90.2017.07.02.07.47.37; Sun, 02 Jul 2017 07:47:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbdGBOre (ORCPT + 1 other); Sun, 2 Jul 2017 10:47:34 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:54554 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbdGBOrU (ORCPT ); Sun, 2 Jul 2017 10:47:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 446FF344; Sun, 2 Jul 2017 07:47:19 -0700 (PDT) Received: from localhost.localdomain (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 69B993F578; Sun, 2 Jul 2017 07:47:11 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Cc: Ofir Drang Subject: [PATCH v3 22/28] cifs: move to generic async completion Date: Sun, 2 Jul 2017 17:42:04 +0300 Message-Id: <1499006535-19760-23-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1499006535-19760-1-git-send-email-gilad@benyossef.com> References: <1499006535-19760-1-git-send-email-gilad@benyossef.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org cifs starts an async. crypto op and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 30 ++++-------------------------- 1 file changed, 4 insertions(+), 26 deletions(-) -- 2.1.4 diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 00b1143..46abe62 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1809,22 +1809,6 @@ init_sg(struct smb_rqst *rqst, u8 *sign) return sg; } -struct cifs_crypt_result { - int err; - struct completion completion; -}; - -static void cifs_crypt_complete(struct crypto_async_request *req, int err) -{ - struct cifs_crypt_result *res = req->data; - - if (err == -EINPROGRESS) - return; - - res->err = err; - complete(&res->completion); -} - static int smb2_get_enc_key(struct TCP_Server_Info *server, __u64 ses_id, int enc, u8 *key) { @@ -1865,12 +1849,10 @@ crypt_message(struct TCP_Server_Info *server, struct smb_rqst *rqst, int enc) struct aead_request *req; char *iv; unsigned int iv_len; - struct cifs_crypt_result result = {0, }; + DECLARE_CRYPTO_WAIT(wait); struct crypto_aead *tfm; unsigned int crypt_len = le32_to_cpu(tr_hdr->OriginalMessageSize); - init_completion(&result.completion); - rc = smb2_get_enc_key(server, tr_hdr->SessionId, enc, key); if (rc) { cifs_dbg(VFS, "%s: Could not get %scryption key\n", __func__, @@ -1930,14 +1912,10 @@ crypt_message(struct TCP_Server_Info *server, struct smb_rqst *rqst, int enc) aead_request_set_ad(req, assoc_data_len); aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG, - cifs_crypt_complete, &result); + crypto_req_done, &wait); - rc = enc ? crypto_aead_encrypt(req) : crypto_aead_decrypt(req); - - if (rc == -EINPROGRESS || rc == -EIOCBQUEUED) { - wait_for_completion(&result.completion); - rc = result.err; - } + rc = crypto_wait_req(enc ? crypto_aead_encrypt(req) + : crypto_aead_decrypt(req), &wait); if (!rc && enc) memcpy(&tr_hdr->Signature, sign, SMB2_SIGNATURE_SIZE);