From patchwork Tue Jul 4 04:08:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 106921 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp555304qge; Mon, 3 Jul 2017 21:13:50 -0700 (PDT) X-Received: by 10.84.231.196 with SMTP id g4mr14163428pln.34.1499141630240; Mon, 03 Jul 2017 21:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499141630; cv=none; d=google.com; s=arc-20160816; b=NFavvuHOalcdXrViwaeWUmInvsk4HYEZR2uiFk1555LsvbCyn0kiWJy1lu/74ALxJy p2sQ+y++i3QFsreMV/YgSzHVfp23v++wJqG18/zq+0gtvyaNhF2sNBTZ/BLCAcaxA6NN 9d8cahUTO6M4L7WQ4ySNfjL2qQuNT+74DsxE1Y6dRlqn/5thKW53hs1SqZOqa+PRXuB2 SwIaP9GH7UvYzK7WTN/sS2pXHl5IWP8GWVsp+IGY7zvLSfr6sQigeiUIaz9R1P5qEdnD sCwhn039Etcu9ReBz5f2agRcIp9yj2GuEf/BuGQCLwMCEbAHCrYcCbmlaNVuNw4LiAtc Ehdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=yimnas22/ngM/BUYSwpEF0GwtZT13hvM363iHXBJMIU=; b=eZw4nNvDtnSmqu70WzC3vsEm87hDHlgOocGPP/TKbWhC/g6HmfDqzdIWsuewwA59+G CZNLqqj+ouLrW/bBrwzEHU6RLnkWdw7ZCSD2eXVgfMr8S2mba0w/I/vxnVMGbrSiPFig S9OzJFHYMH6WtV0LFwAJ3nvSdW+qlOGA3TRI2y3yJBQtV4pp7uNTYVv5GlTPa/YGPYVd Zh58HfwFF7erqnkox5+kDiw4GJ0GYDJNguQLZIHZ9MDhB51JX+AtNdLdIp+UFydUYDrz 0kJduo159sigvOU/prMdlx6E6DyYGvX+NIA4MTvm56/A9tIBDgkZfMobTujj0A+4eG5z LQZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p85si13542386pfd.319.2017.07.03.21.13.49; Mon, 03 Jul 2017 21:13:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbdGDENm (ORCPT + 25 others); Tue, 4 Jul 2017 00:13:42 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9270 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbdGDENl (ORCPT ); Tue, 4 Jul 2017 00:13:41 -0400 Received: from 172.30.72.56 (EHLO dggeml406-hub.china.huawei.com) ([172.30.72.56]) by dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id ARK87691; Tue, 04 Jul 2017 12:13:35 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by dggeml406-hub.china.huawei.com (10.3.17.50) with Microsoft SMTP Server id 14.3.301.0; Tue, 4 Jul 2017 12:13:29 +0800 From: Hanjun Guo To: Corey Minyard CC: G Gregory , , Hanjun Guo Subject: [PATCH] char: ipmi: eliminate misleading print info when being probed via ACPI Date: Tue, 4 Jul 2017 12:08:09 +0800 Message-ID: <1499141289-62335-1-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010202.595B15F0.0009, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 282c04915c7d9e248a6ee073422d889d Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hanjun Guo When ipmi is probed via ACPI, the boot log shows [ 17.945139] ipmi_si IPI0001:00: probing via device tree [ 17.950369] ipmi_si IPI0001:00: ipmi_si: probing via ACPI [ 17.955795] ipmi_si IPI0001:00: [io 0x00e4-0x3fff] regsize 1 spacing 1 irq 0 [ 17.962932] ipmi_si: Adding ACPI-specified bt state machine which "ipmi_si IPI0001:00: probing via device tree" is misleading with a ACPI HID "IPI0001" but probing via DT. Eliminate this misleading print info by checking of_node is valid or not before calling of_ipmi_probe(). Signed-off-by: Hanjun Guo --- drivers/char/ipmi/ipmi_si_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.12.4 diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 59ee93e..159950d 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -2810,7 +2810,7 @@ static int acpi_ipmi_probe(struct platform_device *dev) static int ipmi_probe(struct platform_device *dev) { - if (of_ipmi_probe(dev) == 0) + if (dev->dev.of_node && of_ipmi_probe(dev) == 0) return 0; return acpi_ipmi_probe(dev);