From patchwork Tue Jul 4 11:44:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 106949 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp897916qge; Tue, 4 Jul 2017 04:44:53 -0700 (PDT) X-Received: by 10.84.232.72 with SMTP id f8mr15766194pln.87.1499168693902; Tue, 04 Jul 2017 04:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499168693; cv=none; d=google.com; s=arc-20160816; b=F2iNCh6Cmt9ohvdL9gLajQBICKPb71dvhJRgFfGVhc0YmAWidweVr4BLSfocvU1Mwm a7UYkcF4NseYFn4JzgHnL1p2pfUse0hzDJbI8fFbQwSay+N/Wu/DqXS7Ml1wnFvq2AKo rz+UisAACrBr5jS4ARr6kbgcjK06T5lyxN8t9Yb9tgrORozhNos4qE2bt+dMVkvGpfbJ rpeIHbOD9KZSVQpSlD7Cn8Sv+WFDEQi/VxuYFzoauqF29jkFJjoUmIkzmuu58zL0ATe5 myWX+TjDay3uQdPy5DKFzZS+kVyzO4y8/yOGbSCqjJaCt2KtCOmZczpthmbRi9OksC/M eTOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=4LZD4q28AIURnd64G402xvZ7zauhabTtSicZCcsJUoc=; b=DD8IC0LLI7a+urSvWAk9nqfXGk5Shy/PryiFggsJ4GVNcvpHpLH0mHSv4h3EYV5U2Y IDyAmIg5Uulae0necB2UvR/BYDopDvfszY5HKBthX9V3Hv9nwvNggRKa9/g73tDKu3j3 W6zbcBmXMVxwCXq34ky90gVLkiO7ka10yec48k4ecLauf1AqqFEODTsg9HweKYokSVGv FNwYPOsvnKscdwZYAMu+Rrm+I9rEBi6jzYPsdAmWQ3PpCzN31wsb1OADfmMWwppa69xI Zkyf31pB//6Cze7GGHLSkA2ZTN9zqsnPM/7RICdw7lwDXRdEUT8NjpeMI/WCo3Vxf5ce 7B0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=fQyXge4R; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10si14416295pfi.192.2017.07.04.04.44.53; Tue, 04 Jul 2017 04:44:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=fQyXge4R; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbdGDLox (ORCPT + 6 others); Tue, 4 Jul 2017 07:44:53 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:34238 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdGDLow (ORCPT ); Tue, 4 Jul 2017 07:44:52 -0400 Received: by mail-pg0-f48.google.com with SMTP id t186so109751625pgb.1 for ; Tue, 04 Jul 2017 04:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4LZD4q28AIURnd64G402xvZ7zauhabTtSicZCcsJUoc=; b=fQyXge4RciZCIRHReGRNlBoEtT1pizXu//1NC2kMFwF4MVQIpNg+o+Uh+6ZvGZIROW HOZYnPSPPzvs1ixx4mMC31GRmyBCSOfDtkxoFCMFIwin2QbqTSyHePnKM2u8zI61fYJF V2+1a9M1r2Y/yM07xOLoa2776XyJegh3W/Zds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4LZD4q28AIURnd64G402xvZ7zauhabTtSicZCcsJUoc=; b=i0R/iq19bLrbwf2whNRLGK3+uq/Gcg7nEC5UJgnu6JUI2e9BQqWu/OOIIx0iYK9Pit anHtc1KrXFfHM0g44+PBxrxaNDiawZrx8R0rUdvGq/NZFCWytfrQicAhbLXwGEhs6J8G dj39tVhIcquxRTSdoKEiCsk9EGRNC8pNkcT/hivIuLafqX4sDFfvy3mo4gCU4MWxA3ev ITiWkU3nCDpN0F9LeBT+yXG2+es5qxemdT+HZDR96j5FN2BSxga1KSC0261xQLARwqxK wPXgwlNXMCmz78nQlE/RAq5qenaaz4eQfuKgAzpfo/NuTbjZ3Bw1OYJRJFme4nDCcGIA t4PA== X-Gm-Message-State: AIVw113TYpLfKSt+vnN9wlDJoP6P2DNCd872HanYiafwn4MW2VNZy7El qqomQjdf3scRGsaw X-Received: by 10.84.232.15 with SMTP id h15mr15950809plk.168.1499168692047; Tue, 04 Jul 2017 04:44:52 -0700 (PDT) Received: from localhost.localdomain ([106.51.234.165]) by smtp.gmail.com with ESMTPSA id t83sm39782750pfg.91.2017.07.04.04.44.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 04:44:50 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Jonas Gorski Subject: [PATCH for-3.18 5/5] usb: ehci-orion: fix probe for !GENERIC_PHY Date: Tue, 4 Jul 2017 17:14:24 +0530 Message-Id: <1499168664-25980-6-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499168664-25980-1-git-send-email-amit.pundir@linaro.org> References: <1499168664-25980-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonas Gorski commit db1319e166c5e872c4be54eac4e47454133708cf upstream. Commit d445913ce0ab7f ("usb: ehci-orion: add optional PHY support") added support for optional phys, but devm_phy_optional_get returns -ENOSYS if GENERIC_PHY is not enabled. This causes probe failures, even when there are no phys specified: [ 1.443365] orion-ehci f1058000.usb: init f1058000.usb fail, -38 [ 1.449403] orion-ehci: probe of f1058000.usb failed with error -38 Similar to dwc3, treat -ENOSYS as no phy. Fixes: d445913ce0ab7f ("usb: ehci-orion: add optional PHY support") Signed-off-by: Jonas Gorski Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman Signed-off-by: Amit Pundir --- drivers/usb/host/ehci-orion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c index 22e15cab8ea5..8de069abd15e 100644 --- a/drivers/usb/host/ehci-orion.c +++ b/drivers/usb/host/ehci-orion.c @@ -226,7 +226,8 @@ static int ehci_orion_drv_probe(struct platform_device *pdev) priv->phy = devm_phy_optional_get(&pdev->dev, "usb"); if (IS_ERR(priv->phy)) { err = PTR_ERR(priv->phy); - goto err_phy_get; + if (err != -ENOSYS) + goto err_phy_get; } else { err = phy_init(priv->phy); if (err)