diff mbox series

[v3,2/2] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20

Message ID 1499255595-31805-3-git-send-email-hayashi.kunihiko@socionext.com
State New
Headers show
Series [v3,1/2] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 | expand

Commit Message

Kunihiko Hayashi July 5, 2017, 11:53 a.m. UTC
Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
The thermal monitor is included in sysctrl.

Furthermore, since the reference board doesn't have a calibrated value of
thermal monitor, this patch gives the default value for LD20 reference
board.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

---
 .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts |  4 +++
 arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi   | 40 ++++++++++++++++++++++
 2 files changed, 44 insertions(+)

-- 
2.7.4

Comments

Kunihiko Hayashi Sept. 4, 2017, 4:43 a.m. UTC | #1
Yamada-san,

On Thu, 10 Aug 2017 19:48:22 +0900 <yamada.masahiro@socionext.com> wrote:

> Hi Hayashi-san,

> 

> 

> 2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:

> > Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.

> > The thermal monitor is included in sysctrl.

> >

> > Furthermore, since the reference board doesn't have a calibrated value of

> > thermal monitor, this patch gives the default value for LD20 reference

> > board.

> >

> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

> > ---

> >  .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts |  4 +++

> >  arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi   | 40 ++++++++++++++++++++++

> >  2 files changed, 44 insertions(+)

> >

> > diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts

> > index 609162a..d7f6b39 100644

> > --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts

> > +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts

> > @@ -86,3 +86,7 @@

> >  &i2c0 {

> >         status = "okay";

> >  };

> > +

> > +&pvtctl {

> > +       socionext,tmod-calibration = <0x0f22 0x68ee>;

> > +};

> 

> 

> I think this calib value is shared among all boards

> (ref and global).

> 

> 

> Please move it to the SoC dtsi.


I see. I'll move it.

> > +                       cooling-maps {

> > +                               map0 {

> > +                                       trip = <&cpu_alert>;

> > +                                       cooling-device = <&cpu0 (-1) (-1)>;

> > +                               };

> > +                               map1 {

> > +                                       trip = <&cpu_alert>;

> > +                                       cooling-device = <&cpu2 (-1) (-1)>;

> > +                               };

> > +                       };

> > +               };

> > +       };

> > +

> 

> After all, I decided to use dt-bindings headers.

> Could you use THERMAL_NO_LIMIT for clarification?


Okay, I'll replace '(-1)' to THERMAL_NO_LIMIT and add the '#include' directive.

---
Best Regards,
Kunihiko Hayashi
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
index 609162a..d7f6b39 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
@@ -86,3 +86,7 @@ 
 &i2c0 {
 	status = "okay";
 };
+
+&pvtctl {
+	socionext,tmod-calibration = <0x0f22 0x68ee>;
+};
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
index a6b3a70..22d04111 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
@@ -82,6 +82,7 @@ 
 			clocks = <&sys_clk 32>;
 			enable-method = "psci";
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		cpu1: cpu@1 {
@@ -100,6 +101,7 @@ 
 			clocks = <&sys_clk 33>;
 			enable-method = "psci";
 			operating-points-v2 = <&cluster1_opp>;
+			#cooling-cells = <2>;
 		};
 
 		cpu3: cpu@101 {
@@ -209,6 +211,38 @@ 
 			     <1 10 4>;
 	};
 
+	thermal-zones {
+		cpu_thermal {
+			polling-delay-passive = <250>;	/* 250ms */
+			polling-delay = <1000>;		/* 1000ms */
+			thermal-sensors = <&pvtctl>;
+
+			trips {
+				cpu_crit: cpu_crit {
+					temperature = <110000>;	/* 110C */
+					hysteresis = <2000>;
+					type = "critical";
+				};
+				cpu_alert: cpu_alert {
+					temperature = <100000>;	/* 100C */
+					hysteresis = <2000>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_alert>;
+					cooling-device = <&cpu0 (-1) (-1)>;
+				};
+				map1 {
+					trip = <&cpu_alert>;
+					cooling-device = <&cpu2 (-1) (-1)>;
+				};
+			};
+		};
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -417,6 +451,12 @@ 
 				compatible = "socionext,uniphier-ld20-reset";
 				#reset-cells = <1>;
 			};
+
+			pvtctl: pvtctl {
+				compatible = "socionext,uniphier-ld20-thermal";
+				interrupts = <0 3 4>;
+				#thermal-sensor-cells = <0>;
+			};
 		};
 	};
 };