[22/22] testimage: Use the renamed buildlzip

Message ID 3107cc24993f111ff2d5714213bd85ff15173221.1499351361.git.raj.khem@gmail.com
State Accepted
Commit 57cd682e05f82b63090b0cbb4a1d8feb3bfbff23
Headers show
Series
  • Glibc 2.26 update and musl updates
Related show

Commit Message

Khem Raj July 6, 2017, 2:33 p.m.
buildiptables has been replaced with buildlzip

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/classes/testimage.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.13.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Jose Perez Carranza July 6, 2017, 3:34 p.m. | #1
On 07/06/2017 09:33 AM, Khem Raj wrote:
> buildiptables has been replaced with buildlzip
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   meta/classes/testimage.bbclass | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
> index 6fa2d6fd9f..0c4a84e111 100644
> --- a/meta/classes/testimage.bbclass
> +++ b/meta/classes/testimage.bbclass
> @@ -49,10 +49,10 @@ DEFAULT_TEST_SUITES_pn-core-image-x11 = "${MINTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam parselogs ${RPMTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman xorg parselogs ${RPMTESTSUITE} \
>       ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
>       connman ${DEVTESTSUITE} logrotate perl parselogs python ${RPMTESTSUITE} xorg"
>   DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl python parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
>       connman ${DEVTESTSUITE} logrotate pam parselogs perl python ${RPMTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>   
> @@ -61,7 +61,7 @@ DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
>   
>   # qemumips is quite slow and has reached the timeout limit several times on the YP build cluster,
>   # mitigate this by removing build tests for qemumips machines.
> -MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
> +MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
>   DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
>   DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"
>   
I think this patch is not applicable as for runtime tests 
(meta/lib/oeqa/runtime/cases/) we do actually use buildiptables test, 
for sdk test there are not filters so in the case of using "testsdk" all 
the available test under meta/lib/oeqa/sdk/cases should be executed.
Khem Raj July 6, 2017, 3:40 p.m. | #2
On Thu, Jul 6, 2017 at 8:34 AM, Jose Perez Carranza
<jose.perez.carranza@linux.intel.com> wrote:
>
> On 07/06/2017 09:33 AM, Khem Raj wrote:
>>
>> buildiptables has been replaced with buildlzip
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   meta/classes/testimage.bbclass | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/classes/testimage.bbclass
>> b/meta/classes/testimage.bbclass
>> index 6fa2d6fd9f..0c4a84e111 100644
>> --- a/meta/classes/testimage.bbclass
>> +++ b/meta/classes/testimage.bbclass
>> @@ -49,10 +49,10 @@ DEFAULT_TEST_SUITES_pn-core-image-x11 =
>> "${MINTESTSUITE}"
>>   DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam parselogs
>> ${RPMTESTSUITE}"
>>   DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman xorg
>> parselogs ${RPMTESTSUITE} \
>>       ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
>> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>> buildiptables buildgalculator \
>> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>> buildlzip buildgalculator \
>>       connman ${DEVTESTSUITE} logrotate perl parselogs python
>> ${RPMTESTSUITE} xorg"
>>   DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl
>> python parselogs ${RPMTESTSUITE}"
>> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>> buildiptables buildgalculator \
>> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>> buildlzip buildgalculator \
>>       connman ${DEVTESTSUITE} logrotate pam parselogs perl python
>> ${RPMTESTSUITE}"
>>   DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>>   @@ -61,7 +61,7 @@ DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
>>     # qemumips is quite slow and has reached the timeout limit several
>> times on the YP build cluster,
>>   # mitigate this by removing build tests for qemumips machines.
>> -MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
>> +MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
>>   DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
>>   DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"
>>
>
> I think this patch is not applicable as for runtime tests
> (meta/lib/oeqa/runtime/cases/) we do actually use buildiptables test, for
> sdk test there are not filters so in the case of using "testsdk" all the
> available test under meta/lib/oeqa/sdk/cases should be executed.
>

Thats fine, send a followup. Without this patch I was still seeing
that bitbake -ctestimage <image> would not execute the new test and
looking for old test.

As can be seen the patch is just a rename the occurrences of old test
with new test.

> --
> Saludos
> José
>
Khem Raj July 6, 2017, 4:05 p.m. | #3
On Thu, Jul 6, 2017 at 9:05 AM, Jose Perez Carranza
<jose.perez.carranza@linux.intel.com> wrote:
>
>
> On 07/06/2017 10:40 AM, Khem Raj wrote:
>>
>> On Thu, Jul 6, 2017 at 8:34 AM, Jose Perez Carranza
>> <jose.perez.carranza@linux.intel.com> wrote:
>>>
>>> On 07/06/2017 09:33 AM, Khem Raj wrote:
>>>>
>>>> buildiptables has been replaced with buildlzip
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>>    meta/classes/testimage.bbclass | 6 +++---
>>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/meta/classes/testimage.bbclass
>>>> b/meta/classes/testimage.bbclass
>>>> index 6fa2d6fd9f..0c4a84e111 100644
>>>> --- a/meta/classes/testimage.bbclass
>>>> +++ b/meta/classes/testimage.bbclass
>>>> @@ -49,10 +49,10 @@ DEFAULT_TEST_SUITES_pn-core-image-x11 =
>>>> "${MINTESTSUITE}"
>>>>    DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam
>>>> parselogs
>>>> ${RPMTESTSUITE}"
>>>>    DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman
>>>> xorg
>>>> parselogs ${RPMTESTSUITE} \
>>>>        ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
>>>> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>>>> buildiptables buildgalculator \
>>>> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>>>> buildlzip buildgalculator \
>>>>        connman ${DEVTESTSUITE} logrotate perl parselogs python
>>>> ${RPMTESTSUITE} xorg"
>>>>    DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl
>>>> python parselogs ${RPMTESTSUITE}"
>>>> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>>>> buildiptables buildgalculator \
>>>> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>>>> buildlzip buildgalculator \
>>>>        connman ${DEVTESTSUITE} logrotate pam parselogs perl python
>>>> ${RPMTESTSUITE}"
>>>>    DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>>>>    @@ -61,7 +61,7 @@ DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
>>>>      # qemumips is quite slow and has reached the timeout limit several
>>>> times on the YP build cluster,
>>>>    # mitigate this by removing build tests for qemumips machines.
>>>> -MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
>>>> +MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
>>>>    DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
>>>>    DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"
>>>>
>>> I think this patch is not applicable as for runtime tests
>>> (meta/lib/oeqa/runtime/cases/) we do actually use buildiptables test, for
>>> sdk test there are not filters so in the case of using "testsdk" all the
>>> available test under meta/lib/oeqa/sdk/cases should be executed.
>>>
>> Thats fine, send a followup. Without this patch I was still seeing
>> that bitbake -ctestimage <image> would not execute the new test and
>> looking for old test.
>
> The new test is only applicable to sdk test, to execute this tests "bitbake
> -c testsdk <image>" should be used an this actually executes new lzip tests,
> on the bug 11713 is tatetd tht the problems are in sdl/cases/iptables, are
> you also having issues on the "runtime/cases/buildiptables"? if that is the
> case please add a comment on the bug as this will need some more effort.
>

its needed for executing with -c testimage as well when we use
core-image-sato-sdk e.g.


>> "
>> As can be seen the patch is just a rename the occurrences of old test
>> with new test.
>>
>>> --
>>> Saludos
>>> José
>>>
>
> --
> Saludos
> José
>
Jose Perez Carranza July 6, 2017, 4:05 p.m. | #4
On 07/06/2017 10:40 AM, Khem Raj wrote:
> On Thu, Jul 6, 2017 at 8:34 AM, Jose Perez Carranza
> <jose.perez.carranza@linux.intel.com> wrote:
>> On 07/06/2017 09:33 AM, Khem Raj wrote:
>>> buildiptables has been replaced with buildlzip
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>>    meta/classes/testimage.bbclass | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/classes/testimage.bbclass
>>> b/meta/classes/testimage.bbclass
>>> index 6fa2d6fd9f..0c4a84e111 100644
>>> --- a/meta/classes/testimage.bbclass
>>> +++ b/meta/classes/testimage.bbclass
>>> @@ -49,10 +49,10 @@ DEFAULT_TEST_SUITES_pn-core-image-x11 =
>>> "${MINTESTSUITE}"
>>>    DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam parselogs
>>> ${RPMTESTSUITE}"
>>>    DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman xorg
>>> parselogs ${RPMTESTSUITE} \
>>>        ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
>>> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>>> buildiptables buildgalculator \
>>> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio
>>> buildlzip buildgalculator \
>>>        connman ${DEVTESTSUITE} logrotate perl parselogs python
>>> ${RPMTESTSUITE} xorg"
>>>    DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl
>>> python parselogs ${RPMTESTSUITE}"
>>> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>>> buildiptables buildgalculator \
>>> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio
>>> buildlzip buildgalculator \
>>>        connman ${DEVTESTSUITE} logrotate pam parselogs perl python
>>> ${RPMTESTSUITE}"
>>>    DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>>>    @@ -61,7 +61,7 @@ DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
>>>      # qemumips is quite slow and has reached the timeout limit several
>>> times on the YP build cluster,
>>>    # mitigate this by removing build tests for qemumips machines.
>>> -MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
>>> +MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
>>>    DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
>>>    DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"
>>>
>> I think this patch is not applicable as for runtime tests
>> (meta/lib/oeqa/runtime/cases/) we do actually use buildiptables test, for
>> sdk test there are not filters so in the case of using "testsdk" all the
>> available test under meta/lib/oeqa/sdk/cases should be executed.
>>
> Thats fine, send a followup. Without this patch I was still seeing
> that bitbake -ctestimage <image> would not execute the new test and
> looking for old test.
The new test is only applicable to sdk test, to execute this tests 
"bitbake -c testsdk <image>" should be used an this actually executes 
new lzip tests, on the bug 11713 is tatetd tht the problems are in 
sdl/cases/iptables, are you also having issues on the 
"runtime/cases/buildiptables"? if that is the case please add a comment 
on the bug as this will need some more effort.
> "
> As can be seen the patch is just a rename the occurrences of old test
> with new test.
>
>> --
>> Saludos
>> José
>>
Jose Perez Carranza July 6, 2017, 9:09 p.m. | #5
On 07/06/2017 09:33 AM, Khem Raj wrote:
> buildiptables has been replaced with buildlzip
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   meta/classes/testimage.bbclass | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
> index 6fa2d6fd9f..0c4a84e111 100644
> --- a/meta/classes/testimage.bbclass
> +++ b/meta/classes/testimage.bbclass
> @@ -49,10 +49,10 @@ DEFAULT_TEST_SUITES_pn-core-image-x11 = "${MINTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam parselogs ${RPMTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman xorg parselogs ${RPMTESTSUITE} \
>       ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
>       connman ${DEVTESTSUITE} logrotate perl parselogs python ${RPMTESTSUITE} xorg"
>   DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl python parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
>       connman ${DEVTESTSUITE} logrotate pam parselogs perl python ${RPMTESTSUITE}"
>   DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>   
> @@ -61,7 +61,7 @@ DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
>   
>   # qemumips is quite slow and has reached the timeout limit several times on the YP build cluster,
>   # mitigate this by removing build tests for qemumips machines.
> -MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
> +MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
>   DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
>   DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"
>   
I sent a series including this patch and the complement to fully apply 
changes for runtime tests

https://patchwork.openembedded.org/series/7615/

Patch

diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
index 6fa2d6fd9f..0c4a84e111 100644
--- a/meta/classes/testimage.bbclass
+++ b/meta/classes/testimage.bbclass
@@ -49,10 +49,10 @@  DEFAULT_TEST_SUITES_pn-core-image-x11 = "${MINTESTSUITE}"
 DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam parselogs ${RPMTESTSUITE}"
 DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman xorg parselogs ${RPMTESTSUITE} \
     ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
-DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
+DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
     connman ${DEVTESTSUITE} logrotate perl parselogs python ${RPMTESTSUITE} xorg"
 DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam perl python parselogs ${RPMTESTSUITE}"
-DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildiptables buildgalculator \
+DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE} buildcpio buildlzip buildgalculator \
     connman ${DEVTESTSUITE} logrotate pam parselogs perl python ${RPMTESTSUITE}"
 DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
 
@@ -61,7 +61,7 @@  DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
 
 # qemumips is quite slow and has reached the timeout limit several times on the YP build cluster,
 # mitigate this by removing build tests for qemumips machines.
-MIPSREMOVE ??= "buildcpio buildiptables buildgalculator"
+MIPSREMOVE ??= "buildcpio buildlzip buildgalculator"
 DEFAULT_TEST_SUITES_remove_qemumips = "${MIPSREMOVE}"
 DEFAULT_TEST_SUITES_remove_qemumips64 = "${MIPSREMOVE}"