| Message ID | 20170708131744.33927-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 5693b474a5014b27db5d842ebd1a690dec9ccc17 |
| Headers | show |
| Series | [oe,meta-oe,1/5] libdbus-c++: Fix build with gcc7 and unblacklist | expand |
Unfortunately still fails: http://errors.yoctoproject.org/Errors/Details/147042/ On Sat, Jul 8, 2017 at 3:17 PM, Khem Raj <raj.khem@gmail.com> wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > .../0001-pipe.c-Use-a-string-instead-of-char.patch | 27 > ++++++++++++++++++++++ > meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb | 20 ++++++++-------- > 2 files changed, 36 insertions(+), 11 deletions(-) > create mode 100644 meta-oe/recipes-core/dbus/ > libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > > diff --git a/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c- > Use-a-string-instead-of-char.patch b/meta-oe/recipes-core/dbus/ > libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > new file mode 100644 > index 000000000..6883f9a0b > --- /dev/null > +++ b/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c- > Use-a-string-instead-of-char.patch > @@ -0,0 +1,27 @@ > +From 6bcb58bd69c38b9200e8ec6c382247167571189d Mon Sep 17 00:00:00 2001 > +From: Khem Raj <raj.khem@gmail.com> > +Date: Sat, 1 Jul 2017 16:44:15 -0700 > +Subject: [PATCH] pipe.c: Use a string instead of char > + > +Fixes > +error: invalid conversion from 'char' to 'const void*' [-fpermissive] > + > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > +--- > + src/pipe.cpp | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/src/pipe.cpp b/src/pipe.cpp > +index 45c2ba6..1303c2d 100644 > +--- a/src/pipe.cpp > ++++ b/src/pipe.cpp > +@@ -83,5 +83,5 @@ ssize_t Pipe::read(void *buffer, unsigned int &nbytes) > + void Pipe::signal() > + { > + // TODO: ignoring return of read/write generates warning; maybe > relevant for eventloop work... > +- ::write(_fd_write, '\0', 1); > ++ ::write(_fd_write, "", 1); > + } > +-- > +2.13.2 > + > diff --git a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > index 4412716a6..4cc133301 100644 > --- a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > +++ b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > @@ -6,15 +6,15 @@ LICENSE = "LGPLv2.1" > LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24" > DEPENDS = "dbus expat glib-2.0 libpcre" > > -SRC_URI = "\ > - ${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz > \ > - file://fix-missing-unistd.h-include.patch \ > - file://remove-CXX_FOR_BUILD-stuff.patch \ > - file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch > \ > - file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch > \ > - file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch > \ > - file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ > -" > +SRC_URI = "${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz > \ > + file://fix-missing-unistd.h-include.patch \ > + file://remove-CXX_FOR_BUILD-stuff.patch \ > + file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch > \ > + file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch > \ > + file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch > \ > + file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ > + file://0001-pipe.c-Use-a-string-instead-of-char.patch \ > + " > SRC_URI[md5sum] = "e752116f523fa88ef041e63d3dee4de2" > SRC_URI[sha256sum] = "bc11ac297b3cb010be904c72789695 > 543ee3fdf3d75cdc8225fd371385af4e61" > > @@ -27,5 +27,3 @@ PACKAGE_BEFORE_PN = "${PN}-tools" > FILES_${PN}-tools = "${bindir}" > > BBCLASSEXTEND = "native" > - > -PNBLACKLIST[libdbus-c++] ?= "Fails to build with RSS > http://errors.yoctoproject.org/Errors/Details/130644/ - the recipe will > be removed on 2017-09-01 unless the issue is fixed" > -- > 2.13.2 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
On 7/10/17 3:18 AM, Martin Jansa wrote: > Unfortunately still fails: > http://errors.yoctoproject.org/Errors/Details/147042/ > hmmm, i dont see it locally, I do not use gold linker as default ld. It looks like you do. Its most probably thats the difference. In anycase adding -pthread to LDFLAGS should fix it. Let me try it out and update the patch > On Sat, Jul 8, 2017 at 3:17 PM, Khem Raj <raj.khem@gmail.com > <mailto:raj.khem@gmail.com>> wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> > --- > .../0001-pipe.c-Use-a-string-instead-of-char.patch | 27 > ++++++++++++++++++++++ > meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb <http://0.9.0.bb> > | 20 ++++++++-------- > 2 files changed, 36 insertions(+), 11 deletions(-) > create mode 100644 > meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > > diff --git > a/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > b/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > new file mode 100644 > index 000000000..6883f9a0b > --- /dev/null > +++ > b/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch > @@ -0,0 +1,27 @@ > +From 6bcb58bd69c38b9200e8ec6c382247167571189d Mon Sep 17 00:00:00 2001 > +From: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> > +Date: Sat, 1 Jul 2017 16:44:15 -0700 > +Subject: [PATCH] pipe.c: Use a string instead of char > + > +Fixes > +error: invalid conversion from 'char' to 'const void*' [-fpermissive] > + > +Signed-off-by: Khem Raj <raj.khem@gmail.com > <mailto:raj.khem@gmail.com>> > +--- > + src/pipe.cpp | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/src/pipe.cpp b/src/pipe.cpp > +index 45c2ba6..1303c2d 100644 > +--- a/src/pipe.cpp > ++++ b/src/pipe.cpp > +@@ -83,5 +83,5 @@ ssize_t Pipe::read(void *buffer, unsigned int > &nbytes) > + void Pipe::signal() > + { > + // TODO: ignoring return of read/write generates warning; maybe > relevant for eventloop work... > +- ::write(_fd_write, '\0', 1); > ++ ::write(_fd_write, "", 1); > + } > +-- > +2.13.2 > + > diff --git a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > <http://0.9.0.bb> b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb > <http://0.9.0.bb> > index 4412716a6..4cc133301 100644 > --- a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb <http://0.9.0.bb> > +++ b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb <http://0.9.0.bb> > @@ -6,15 +6,15 @@ LICENSE = "LGPLv2.1" > LIC_FILES_CHKSUM = > "file://COPYING;md5=fbc093901857fcd118f065f900982c24" > DEPENDS = "dbus expat glib-2.0 libpcre" > > -SRC_URI = "\ > - > ${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz > \ > - file://fix-missing-unistd.h-include.patch \ > - file://remove-CXX_FOR_BUILD-stuff.patch \ > - > file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch \ > - > file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch \ > - > file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch \ > - file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ > -" > +SRC_URI = > "${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz > \ > + file://fix-missing-unistd.h-include.patch \ > + file://remove-CXX_FOR_BUILD-stuff.patch \ > + > file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch > \ > + > file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch > \ > + > file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch \ > + file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ > + file://0001-pipe.c-Use-a-string-instead-of-char.patch \ > + " > SRC_URI[md5sum] = "e752116f523fa88ef041e63d3dee4de2" > SRC_URI[sha256sum] = > "bc11ac297b3cb010be904c72789695543ee3fdf3d75cdc8225fd371385af4e61" > > @@ -27,5 +27,3 @@ PACKAGE_BEFORE_PN = "${PN}-tools" > FILES_${PN}-tools = "${bindir}" > > BBCLASSEXTEND = "native" > - > -PNBLACKLIST[libdbus-c++] ?= "Fails to build with RSS > http://errors.yoctoproject.org/Errors/Details/130644/ > <http://errors.yoctoproject.org/Errors/Details/130644/> - the recipe > will be removed on 2017-09-01 unless the issue is fixed" > -- > 2.13.2 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > <mailto:Openembedded-devel@lists.openembedded.org> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > <http://lists.openembedded.org/mailman/listinfo/openembedded-devel> > > -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff --git a/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch b/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch new file mode 100644 index 000000000..6883f9a0b --- /dev/null +++ b/meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch @@ -0,0 +1,27 @@ +From 6bcb58bd69c38b9200e8ec6c382247167571189d Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Sat, 1 Jul 2017 16:44:15 -0700 +Subject: [PATCH] pipe.c: Use a string instead of char + +Fixes +error: invalid conversion from 'char' to 'const void*' [-fpermissive] + +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + src/pipe.cpp | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/pipe.cpp b/src/pipe.cpp +index 45c2ba6..1303c2d 100644 +--- a/src/pipe.cpp ++++ b/src/pipe.cpp +@@ -83,5 +83,5 @@ ssize_t Pipe::read(void *buffer, unsigned int &nbytes) + void Pipe::signal() + { + // TODO: ignoring return of read/write generates warning; maybe relevant for eventloop work... +- ::write(_fd_write, '\0', 1); ++ ::write(_fd_write, "", 1); + } +-- +2.13.2 + diff --git a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb index 4412716a6..4cc133301 100644 --- a/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb +++ b/meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb @@ -6,15 +6,15 @@ LICENSE = "LGPLv2.1" LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24" DEPENDS = "dbus expat glib-2.0 libpcre" -SRC_URI = "\ - ${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz \ - file://fix-missing-unistd.h-include.patch \ - file://remove-CXX_FOR_BUILD-stuff.patch \ - file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch \ - file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch \ - file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch \ - file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ -" +SRC_URI = "${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BP}.tar.gz \ + file://fix-missing-unistd.h-include.patch \ + file://remove-CXX_FOR_BUILD-stuff.patch \ + file://0001-src-eventloop.cpp-use-portable-method-for-initializi.patch \ + file://0002-tools-generate_proxy.cpp-avoid-possibly-undefined-ui.patch \ + file://0003-Fixed-undefined-ssize_t-for-clang-3.8.0-on-FreeBSD.patch \ + file://0004-use-POSIX-poll.h-instead-of-sys-poll.h.patch \ + file://0001-pipe.c-Use-a-string-instead-of-char.patch \ + " SRC_URI[md5sum] = "e752116f523fa88ef041e63d3dee4de2" SRC_URI[sha256sum] = "bc11ac297b3cb010be904c72789695543ee3fdf3d75cdc8225fd371385af4e61" @@ -27,5 +27,3 @@ PACKAGE_BEFORE_PN = "${PN}-tools" FILES_${PN}-tools = "${bindir}" BBCLASSEXTEND = "native" - -PNBLACKLIST[libdbus-c++] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130644/ - the recipe will be removed on 2017-09-01 unless the issue is fixed"
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../0001-pipe.c-Use-a-string-instead-of-char.patch | 27 ++++++++++++++++++++++ meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb | 20 ++++++++-------- 2 files changed, 36 insertions(+), 11 deletions(-) create mode 100644 meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/0001-pipe.c-Use-a-string-instead-of-char.patch -- 2.13.2 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel