diff mbox

9p: hide cachetag option for non-CONFIG_9P_FSCACHE

Message ID 20170710112154.940606-1-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann July 10, 2017, 11:21 a.m. UTC 
show_options cannot print this option when it is disabled in Kconfig:

fs/9p/v9fs.c: In function 'v9fs_show_options':
fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?

Fixes: ccb0055985b9 ("9p: Implement show_options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 fs/9p/v9fs.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.0

Comments

David Howells July 11, 2017, 3:28 p.m. UTC | #1 
Arnd Bergmann <arnd@arndb.de> wrote:

> show_options cannot print this option when it is disabled in Kconfig:

> 

> fs/9p/v9fs.c: In function 'v9fs_show_options':

> fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?

> 

> Fixes: ccb0055985b9 ("9p: Implement show_options")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: David Howells <dhowells@redhat.com>
diff mbox

Patch

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index d69046650a36..8fb89ddc6cc7 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -137,8 +137,10 @@  int v9fs_show_options(struct seq_file *m, struct dentry *root)
 		seq_puts(m, ",nodevmap");
 	if (v9ses->cache)
 		seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
+#ifdef CONFIG_9P_FSCACHE
 	if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
 		seq_printf(m, ",cachetag=%s", v9ses->cachetag);
+#endif
 
 	switch (v9ses->flags & V9FS_ACCESS_MASK) {
 	case V9FS_ACCESS_USER: