[oe,meta-browser] chromium: Do not enforce gold as default linker

Message ID 20170710213324.43346-1-raj.khem@gmail.com
State New
Headers show

Commit Message

Khem Raj July 10, 2017, 9:33 p.m.
Provide a knob USEGOLD however to enable it if desired

Signed-off-by: Khem Raj <raj.khem@gmail.com>

Cc: Denys Dmytriyenko <denis@denix.org>
---
 recipes-browser/chromium/chromium-browser.inc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.13.2

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Martin Jansa July 11, 2017, 7:04 a.m. | #1
USEGOLD
or
USE_GOLD
?

On Mon, Jul 10, 2017 at 11:33 PM, Khem Raj <raj.khem@gmail.com> wrote:

> Provide a knob USEGOLD however to enable it if desired

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> Cc: Denys Dmytriyenko <denis@denix.org>

> ---

>  recipes-browser/chromium/chromium-browser.inc | 7 ++++++-

>  1 file changed, 6 insertions(+), 1 deletion(-)

>

> diff --git a/recipes-browser/chromium/chromium-browser.inc

> b/recipes-browser/chromium/chromium-browser.inc

> index 094a3d3..1e4fb1e 100644

> --- a/recipes-browser/chromium/chromium-browser.inc

> +++ b/recipes-browser/chromium/chromium-browser.inc

> @@ -200,7 +200,12 @@ python add_ozone_wayland_patches() {

>      d.appendVar('SRC_URI', ' ' + d.getVar('OZONE_WAYLAND_EXTRA_PATCHES',

> False))

>  }

>

> -USEGOLD ?= "-Dlinux_use_gold_flags=1"

> +# uncomment below or set it in a bbappend if you want to use gold linker

> +# to link chromium irrespective of system linker, gold speeds up linking

> +# chromium ( 8mins to < 2mins on a decent xeon system)

> +#

> +#USEGOLD = "-Dlinux_use_gold_flags=1"

> +USE_GOLD ??= ""

>

>  EXTRA_OEGYP = " \

>         -Dangle_use_commit_id=0 \

> --

> 2.13.2

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes-browser/chromium/chromium-browser.inc b/recipes-browser/chromium/chromium-browser.inc
index 094a3d3..1e4fb1e 100644
--- a/recipes-browser/chromium/chromium-browser.inc
+++ b/recipes-browser/chromium/chromium-browser.inc
@@ -200,7 +200,12 @@  python add_ozone_wayland_patches() {
     d.appendVar('SRC_URI', ' ' + d.getVar('OZONE_WAYLAND_EXTRA_PATCHES', False))
 }
 
-USEGOLD ?= "-Dlinux_use_gold_flags=1"
+# uncomment below or set it in a bbappend if you want to use gold linker
+# to link chromium irrespective of system linker, gold speeds up linking
+# chromium ( 8mins to < 2mins on a decent xeon system)
+#
+#USEGOLD = "-Dlinux_use_gold_flags=1"
+USE_GOLD ??= ""
 
 EXTRA_OEGYP = " \
 	-Dangle_use_commit_id=0 \