PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table

Message ID 3b5b0e789b7296f7b38f4ab9503a53031280a672.1499831484.git.viresh.kumar@linaro.org
State Accepted
Commit 5b60697cd89cf5a438b2984e11859228e5ec1c6b
Headers show

Commit Message

Viresh Kumar July 12, 2017, 3:51 a.m.
Some platforms add the OPPs dynamically from platform specific drivers
instead of getting them statically from DT. The cpufreq-dt driver
already ignores the return value of dev_pm_opp_of_cpumask_add_table() to
not error out for such cases, but we still end up printing error message
from that routine. That's not nice.

Convert the print message to use pr_debug() instead.

Reported-by: Mason <slash.tmp@free.fr>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 drivers/base/power/opp/of.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

-- 
2.13.0.71.gd7076ec9c9cb

Comments

Stephen Boyd July 13, 2017, 6:10 a.m. | #1
On 07/12, Viresh Kumar wrote:
> Some platforms add the OPPs dynamically from platform specific drivers

> instead of getting them statically from DT. The cpufreq-dt driver

> already ignores the return value of dev_pm_opp_of_cpumask_add_table() to

> not error out for such cases, but we still end up printing error message

> from that routine. That's not nice.

> 

> Convert the print message to use pr_debug() instead.

> 

> Reported-by: Mason <slash.tmp@free.fr>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---


Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Rafael J. Wysocki July 21, 2017, 10:40 p.m. | #2
On Wednesday, July 12, 2017 11:10:14 PM Stephen Boyd wrote:
> On 07/12, Viresh Kumar wrote:

> > Some platforms add the OPPs dynamically from platform specific drivers

> > instead of getting them statically from DT. The cpufreq-dt driver

> > already ignores the return value of dev_pm_opp_of_cpumask_add_table() to

> > not error out for such cases, but we still end up printing error message

> > from that routine. That's not nice.

> > 

> > Convert the print message to use pr_debug() instead.

> > 

> > Reported-by: Mason <slash.tmp@free.fr>

> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> > ---

> 

> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>


Applied, thanks!

Patch

diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c
index 779428676f63..f1d8b01db546 100644
--- a/drivers/base/power/opp/of.c
+++ b/drivers/base/power/opp/of.c
@@ -533,8 +533,12 @@  int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask)
 
 		ret = dev_pm_opp_of_add_table(cpu_dev);
 		if (ret) {
-			pr_err("%s: couldn't find opp table for cpu:%d, %d\n",
-			       __func__, cpu, ret);
+			/*
+			 * OPP may get registered dynamically, don't print error
+			 * message here.
+			 */
+			pr_debug("%s: couldn't find opp table for cpu:%d, %d\n",
+				 __func__, cpu, ret);
 
 			/* Free all other OPPs */
 			dev_pm_opp_of_cpumask_remove_table(cpumask);