From patchwork Wed Jul 12 03:51:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 107439 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp303818qge; Tue, 11 Jul 2017 20:52:18 -0700 (PDT) X-Received: by 10.84.193.129 with SMTP id f1mr1877979pld.158.1499831538799; Tue, 11 Jul 2017 20:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499831538; cv=none; d=google.com; s=arc-20160816; b=BXCHUCM6/TW38Vu6HWOfARDbTQQmW6lJQC8S9bEapBoje/S/WkYtrgU5h3NaiqTTEO Dui0QEFGvxt0hToWhJk6xiEk7FCPQHs7GSJMZtBU0LZJTmaeIKqaFEoyVtlowJbWBePj HO0QLNThBLUECA12WNiPJo5LI9i0JfNDAr3OgeenypZSmpHjZ783ufotaTZ2lgSiwlKh p/VAms5AJPIZkGsRUzPXbbU7rh1AEZm7B6d8Po571ubEr5AqR7i5JhyOU/vs/XSce7N2 cwoYy5RaN5Ral18kOjD6YCIomTPdHkDPVe9bYLyvECkljhcDq0PM2XKBBSOLhlzwna1y DLsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=69yO0mZrY9Ppi2IhPN/rm7bP6NwHEk+yEqJU6b9lN6w=; b=XfdtAuE+x4/ckmuo6l5gC1VwYOuLkW3A+GR/Fch3ZW5KCFyFT1vNmVxH4ceQe/SfJm QVSnZv2bdaBFDJvl3lA8ID4+7GfZBYmMIUOOEHf9SXUt88WZh+JEiFQCtoAPp2WxnTt8 f2ngQy1ZOrWa1dHQ21pD1WIase7QMuxRNxEYRhxkDLjsio1Veqjm88f1nN2t65u2FwSH HEIhC8Q7yNBXAUhSy+iBP+2BUPjqZlpdlhtUYb9dpQu/EXfNgGRqxXD5M0aN7m7WS8Qx b0bslX7nnny4utJgShC1nrA2wpU9GF7Ce9LtJHEyT5L+tp/kfaWE+xeprsiXTEl5yl+Q EJvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=DWG3l0i7; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y66si976327pgb.540.2017.07.11.20.52.18; Tue, 11 Jul 2017 20:52:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=DWG3l0i7; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756024AbdGLDwR (ORCPT + 14 others); Tue, 11 Jul 2017 23:52:17 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36736 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755749AbdGLDwQ (ORCPT ); Tue, 11 Jul 2017 23:52:16 -0400 Received: by mail-pf0-f177.google.com with SMTP id q86so6067007pfl.3 for ; Tue, 11 Jul 2017 20:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=69yO0mZrY9Ppi2IhPN/rm7bP6NwHEk+yEqJU6b9lN6w=; b=DWG3l0i7DD1Jn8mUR+HrwZ+eLA3NmQG+sD1rLA4jGszDm01cBJ1oMCmm8tVAZEXj48 PM0hgchATqLmwdeDdQravCaW5ugCsHs1aJebqnNtzFGOfIh21L9hZ4q04BPdfEq0cq6p BRXSsMRPy5H5OuEgYfiIB+fgIp7s0kw/qhYBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=69yO0mZrY9Ppi2IhPN/rm7bP6NwHEk+yEqJU6b9lN6w=; b=UkKoMTWSislRZRxvhwG3j2k3ysD7GrROSAhMXzNboAfTmpTzFd3/5RX2JAe0FssEO6 /NeCWg0FmAaC3mh9B2pAHJvAymFmL+SR9pbtRNb8M7NPBcpmWNndUlDS964M2Usfsz3U J/co2jzKJNsJvoxF/nuOBVKUsE8ENmdoU9vXG7VR+T/NWgNO8drWoxpOjmJJmwx67+R2 bWZ1/vmJta7FgOCRqlanl+ucc/UnyZnAFpNpHHFlRbT2WmPYMswdLVkd49fMQkCk/3eQ BRrLP5ySndF/DkpTQ4jQM7R73wrfQcHiS+9/pkoi+bVfmVht4pm+jmtNz3ezT7xwO4/F hUPw== X-Gm-Message-State: AIVw112CVP0tteOtv2FQ7XkUFgyFe0DputmDMLIGqMhOe9Lfqv+FXL9P mG67fXUG3BLY8GHT X-Received: by 10.99.185.5 with SMTP id z5mr1790579pge.231.1499831535392; Tue, 11 Jul 2017 20:52:15 -0700 (PDT) Received: from localhost ([122.167.138.108]) by smtp.gmail.com with ESMTPSA id 8sm1515442pfs.23.2017.07.11.20.52.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 20:52:14 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Mason , linux-kernel@vger.kernel.org Subject: [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table Date: Wed, 12 Jul 2017 09:21:49 +0530 Message-Id: <3b5b0e789b7296f7b38f4ab9503a53031280a672.1499831484.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.13.0.71.gd7076ec9c9cb Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Some platforms add the OPPs dynamically from platform specific drivers instead of getting them statically from DT. The cpufreq-dt driver already ignores the return value of dev_pm_opp_of_cpumask_add_table() to not error out for such cases, but we still end up printing error message from that routine. That's not nice. Convert the print message to use pr_debug() instead. Reported-by: Mason Signed-off-by: Viresh Kumar --- drivers/base/power/opp/of.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.13.0.71.gd7076ec9c9cb Reviewed-by: Stephen Boyd diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 779428676f63..f1d8b01db546 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -533,8 +533,12 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask) ret = dev_pm_opp_of_add_table(cpu_dev); if (ret) { - pr_err("%s: couldn't find opp table for cpu:%d, %d\n", - __func__, cpu, ret); + /* + * OPP may get registered dynamically, don't print error + * message here. + */ + pr_debug("%s: couldn't find opp table for cpu:%d, %d\n", + __func__, cpu, ret); /* Free all other OPPs */ dev_pm_opp_of_cpumask_remove_table(cpumask);