From patchwork Thu Jul 13 14:19:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 107685 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp2277817qge; Thu, 13 Jul 2017 07:22:07 -0700 (PDT) X-Received: by 10.200.46.100 with SMTP id s33mr5761857qta.48.1499955726949; Thu, 13 Jul 2017 07:22:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499955726; cv=none; d=google.com; s=arc-20160816; b=y2J4FRHqfFytc8iyk9GW+o9b2kxxyxIm3rKItP++OHcpWoN6E1bJNpyxzoZ8v9qBmN Ltl3XehnAmWTGbSNWsnl3ch5v4c6ZU3od4frtQqDpPiHTTFA8qlGsv3ZOgw8PzWqyfXw OIT487R/e+1j5E0lcSRYA1IWrhrRG3HXbuTBbcY98crQfTXsKajqU6LGCLh+I+qJth0l pUYHKsoCK9yiggtlrKrCPGFLHNpRtU4pzbBGE82qZz6LxGcY/Bcs0F0W41s5/EcTSci8 unMKPIF6O9f24EFBWmmbVEKcN5ygVE1X8Me6R0nZM+CpXFdqm0ZjoOhahn5amhytUWcq 0zyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=Sr8o+3tjQx2t/K77/yaF5cgzsOletCSlvQA5JifnICWP0mvsNZnIC6DiTCskKkl0oE u8L7btr0itzsYcJBpQNq//DeKT15d0L+Xlvgmab6s0Q+G5YsJju5Gedh3SoR7FM+AhQT MwLEmgeA6U3vLR/ftrJ0F50vBTBD9B/0+LxR3wDXi80LumRt0pxhWmEfKuSDhAZAF6l/ RLJeOMCmWWtSxlXBENzWwXha1fHsSHE208BwC/vc1lU5kLcHZ+YXZUQKWU83VbMC0M0D T70nxVWupL3oUBQwkxfcVhSgmJK5mTlyHmuhf06bMP6sPaVpeqQWY/Wiwku3W0U5JS0X lX7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.b=jEqsbLpj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id m37si5556391qtf.131.2017.07.13.07.22.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Jul 2017 07:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.b=jEqsbLpj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVf0G-0005vZ-H7 for patch@linaro.org; Thu, 13 Jul 2017 10:22:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVexv-0003wl-2O for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVexr-0006Gl-1F for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:19:39 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:37170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVexq-0006GD-Qj for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:19:34 -0400 Received: by mail-wm0-x230.google.com with SMTP id i127so27713679wma.0 for ; Thu, 13 Jul 2017 07:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=jEqsbLpjwfTJyWp5CHOrEauv3LuDFovfxVMqMjR/Fvc28eEPHpg/FBDgZcg7tLqt2g arjbDDOeo9XOs+kaztFQOuYEVj4/2lStzH9GOYzMOS7UIp9lpaDl5fwuLnQMUCiWk7LS mnh6mKUDYZRucHqgVyShCaZ9rO7Kfqo+jI65M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=N/o3DjuEWCZgNOt/eeaTE7vN+Vt/20IIslCbwE+je1vciWs/3kf/LAqL5zzX7J/gaz usFifnijsH+obHyoTzpp7iPr+AxdEAywePRHuk+QFsMzXl9P9c0gTdypCGPAnwf04Kdu 0OEicT4hJi/XeW2bGTunbdQrhFg00gLBbg1xmfR3tz+y1cCkmRXbPH1loc7oAYC85MIb aWCR2fNlvZB7i+qrAHrQz0tFVNDPvanHFs+Cm4r5Km3gutNIF80ILLlauRsb8HGOXrZC MRqQvXqKQozoSYcTtpKlOzQK9pjZRvRvGfNglZ41MpaE/USmW2dRQwqtDWI+Pbdlrn0k /ipQ== X-Gm-Message-State: AIVw111EjXwNkvkGu3Ii9NrAusRnqyONSp0onc3gy5k5sU66WpGmibmE 8mMliosJGGFAMcPnwltlpw== X-Received: by 10.28.111.84 with SMTP id k81mr2152087wmc.67.1499955573869; Thu, 13 Jul 2017 07:19:33 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t12sm7119424wmd.32.2017.07.13.07.19.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 07:19:31 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 1C08F3E07A0; Thu, 13 Jul 2017 15:19:29 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Thu, 13 Jul 2017 15:19:25 +0100 Message-Id: <20170713141928.25419-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170713141928.25419-1-alex.bennee@linaro.org> References: <20170713141928.25419-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::230 Subject: [Qemu-devel] [PATCH v4 3/6] target/arm/translate.h: expand comment on DISAS_EXIT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.13.0 diff --git a/target/arm/translate.h b/target/arm/translate.h index 15d383d9af..12fd79ba8e 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -140,7 +140,10 @@ static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) */ #define DISAS_BX_EXCRET 11 /* For instructions which want an immediate exit to the main loop, - * as opposed to attempting to use lookup_and_goto_ptr. + * as opposed to attempting to use lookup_and_goto_ptr. Unlike + * DISAS_UPDATE this doesn't write the PC on exiting the translation + * loop so you need to ensure something (gen_a64_set_pc_im or runtime + * helper) has done so before we reach return from cpu_tb_exec. */ #define DISAS_EXIT 12