From patchwork Fri Jul 14 11:46:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 107778 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp786503qge; Fri, 14 Jul 2017 04:46:42 -0700 (PDT) X-Received: by 10.101.70.198 with SMTP id n6mr14705258pgr.249.1500032802603; Fri, 14 Jul 2017 04:46:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500032802; cv=none; d=google.com; s=arc-20160816; b=yUUD2DG6tgdNdV6w5lYMF+8Cq78O2hcOB0Pb4tcD4jsEeNclxQ7ylqqzE1DdbOcif/ AARUFcoJYTd6JlNgCJpzkaSSL9UBvFBlW87art9ah4kIEPdar1r9f2F+zuJTWkoR72VF wy/B7tsojC1mJdH/VqS1/whHTrX2paFCmeIF8YZMbldpIapnDzeDpW46STbj8P104fq0 oVTzUY3Sp0PJlIin03WjLLwOZgjts0LwO55EaCS+sCHqdb8SqvNu5LH+6HvxhbH2UgST yUO01/Mi/uIo7bi/zwhHQCdrtwPqv4QUj/0C0CI+bHYDGdFtAT2krzkSzWhsFQWhbDoj DD4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=LO0N3KpPlkiOar0zvtkIFCCChTfZFWTVRq9Pendcgfc=; b=JaH1DtklDUH9z3c6uSc0IFq1oX6DECBeMz7+RZ3KZE6hx54MzZQNxSEOmpzduFNhCt DMWSFVHM52QCJJprQmpk5/7TI564ZB2ZXRuXDsAH7HwxLML2sf38y/Y16Y5+kL4Yw3v1 XCk24vNSMA4FOB852Qs82CT5XYxybmAeMlqyK9MynQgAfPgkxJ/eQrO/CrT9qespm4zQ I9vqH5Kn9GXtVWsHVn25FcC3u/FoTGXKjDdHmb+bTfWfVl3N3DeMsRv78fMxHxQn84u0 vW6Fc8PWmsOeNG99F5EJWGhBx4wlvV+GUUO5QBXeI6XeCggrsh3zZoI9a146spo1ms57 IeuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=iSRCRXWf; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si6339864pgf.182.2017.07.14.04.46.42; Fri, 14 Jul 2017 04:46:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=iSRCRXWf; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577AbdGNLql (ORCPT + 6 others); Fri, 14 Jul 2017 07:46:41 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:36372 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbdGNLql (ORCPT ); Fri, 14 Jul 2017 07:46:41 -0400 Received: by mail-lf0-f44.google.com with SMTP id h22so52183681lfk.3 for ; Fri, 14 Jul 2017 04:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=LO0N3KpPlkiOar0zvtkIFCCChTfZFWTVRq9Pendcgfc=; b=iSRCRXWfC8BasHVs6CSJJSwMONYnMMIfrn2K8fRLuh+S54S7hfSFdHw0s5EJoifuTd NM4OybRG82wic43SNRHc91UlbGGK3138BoXRRLYX3HVhRqH2OdjNX+Db0hjXO+Su1PXt m52rDD1wI0+H9QPoDpTvJvX7ePtA+HGgAfKYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LO0N3KpPlkiOar0zvtkIFCCChTfZFWTVRq9Pendcgfc=; b=IlyLJbLKOHXsFLBpnkzSbC89aG4eFImgIuI7rEMcLmn5LXsYuDAMrjXxhaL7Lpr71i xZt0ibo0BJBg/KyyjGYKHAIi5eXGC7PjyHKZdczIQ0r+BnPZQQvnbfhQFvX7g1yodBlH EWnpX1wGxVFxe+VbervNjCUlAqI8LDHLeJ57l4vjTln/Oqg3BvoNVuCcyF20JxUY51+/ 9kkaQl/Cb+Vw0uJuMcgH9N1N9P2C1Ae1uUfX2oKiv8B20nOAwbj+DKmGzWgyGA4izdhf 8/CSSDzgHSNPspkevfQi88LeJv/RkhNjF066Fctvm9YFFKPq+cqRh2yqiCy+H4MLK9yz iD2g== X-Gm-Message-State: AIVw110ZpNI5ajLwBUSPQUboJlTORLsr4En414BgAf6ckzyqaeQxMdqb KOq7hla2rbxjmTuSSVh0jA== X-Received: by 10.46.84.74 with SMTP id y10mr775032ljd.77.1500032799497; Fri, 14 Jul 2017 04:46:39 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id h4sm1748283ljb.50.2017.07.14.04.46.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jul 2017 04:46:38 -0700 (PDT) From: Linus Walleij To: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, opensuse-ppc@opensuse.org, Linus Walleij , stable@vger.kernel.org Subject: [PATCH] machintosh: select defaults for cooling Date: Fri, 14 Jul 2017 13:46:29 +0200 Message-Id: <20170714114629.1512-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.4 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org I have this pretty nasty problem when trying to boot up a fresh openSuSE DVD on a PowerMac G5: the kernel by default does not have CONFIG_WINDFARM_PM72 enabled, with the effect that the cooling is not functioning. The BIOS on the PowerMac G5 reacts to this by, after a grace period when the BIOS has waited for the OS to take over, increasing the fan speeds so it sounds like an airplane is in the room, and after another grace period simply cutting the power to the machine. This is done not beacuse the cooling is not working, but because the BIOS is not recieving handover of cooling from the OS, so it panics and give up. The problem has been reported by Linux users online. Needless to say, this makes it impossible to install the OS before the machine turns itself off. The g5_defconfig looks like this: CONFIG_PMAC_SMU=y CONFIG_WINDFARM=y CONFIG_WINDFARM_PM81=y CONFIG_WINDFARM_PM91=y CONFIG_WINDFARM_PM112=y CONFIG_WINDFARM_PM121=y Notably PM72 is missing, making the PowerMac G5 fail. The defconfig is not the right place to do this: it should be done by default when selecting Mac support for PPC/PPC64 and especially for the Macs CPUfreq driver. We select SMU by default for PPC_PMAC64, WINDFARM by default on PPC_PMAC and all the WINDFARM thermal managers by default if CPU_FREQ_PMAC64 is selected. I think this will make install images work in the G5 Macs. Cc: stable@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/macintosh/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.9.4 diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig index 97a420c11eed..d7186d8f30a9 100644 --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -101,6 +101,7 @@ config ADB_PMU_LED_DISK config PMAC_SMU bool "Support for SMU based PowerMacs" depends on PPC_PMAC64 + default PPC_PMAC64 help This option adds support for the newer G5 iMacs and PowerMacs based on the "SMU" system control chip which replaces the old PMU. @@ -194,11 +195,13 @@ config THERM_ADT746X config WINDFARM tristate "New PowerMac thermal control infrastructure" depends on PPC + default PPC_PMAC config WINDFARM_PM81 tristate "Support for thermal management on iMac G5" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the iMacG5 @@ -206,6 +209,7 @@ config WINDFARM_PM72 tristate "Support for thermal management on PowerMac G5 (AGP)" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && ADB_PMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the PowerMac G5 "AGP" variants (PowerMac 7,2 and 7,3) @@ -214,6 +218,7 @@ config WINDFARM_RM31 tristate "Support for thermal management on Xserve G5" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && ADB_PMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the Xserve G5 (RackMac3,1) @@ -222,6 +227,7 @@ config WINDFARM_PM91 tristate "Support for thermal management on PowerMac9,1" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the PowerMac9,1 which is the recent (SMU based) single CPU desktop G5