From patchwork Fri Jul 14 12:07:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 107788 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp890509obm; Fri, 14 Jul 2017 05:11:43 -0700 (PDT) X-Received: by 10.84.213.9 with SMTP id f9mr15499010pli.22.1500034303737; Fri, 14 Jul 2017 05:11:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500034303; cv=none; d=google.com; s=arc-20160816; b=NQgVGaKAwKho+30BpKf1qpw3gLU0Hi0T0RYOqxVPY/mzRCrINw8jmZEUCsmj0Y0peP O9B0Gqq35bYxjfTJpsIkCRn5QUwElQ6/7UCDK/QEL80NZJmLIN5mlkLoyYn+0Wef6oxl aUxYg7hzFFnB+ZxTNmoAW2WyyJgIkgPyZUyStefKuamnyJuOy7aMDXKzj9beYNA3O2Xo GE6BrzfJ0TvRJkkSyLqC2jNndScG7dXZ+KPzKqrGfkvX/PlwhJFT2qpuwld9Os6QflKl YNBLr9lrOmSMbHN0DzSztqa4x8EtGsIdEChDCQgohdnCPHUQkl47fqtQx4VFCAMWcivQ VGpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=xYmXynSj/pgXREBne+MOISYsbF3pLQCtiuMJf7EOyxY=; b=HeU/Wxt6F+yXVxJ+mor8yTJejXKHDutJ7696UYAp/beM/RBLF0L+DogkDM/+2HK77v isPpYB64oBKJzVI6Rbz12MbpIynMfirxRFM62gNN9faHicbSkfqM5/lf9hNlQogM5+vy bHJPkbPLx362pv5sUQK/Dp/oE9XjtGJSJ9Bd85M3pdoJOeTkNOBUmH9PWmbfN2jcK1nG tyBy2O9LMZHvQAuy0/IaGL0U9KKEg8leokBb6Oc6YeMN+t76G3L19J0Nl+FHh1yR9s0d VayxNcXlAbYyKVhPzwK5OaOE0pR0pbJ+EN0UrRtoAkxpjXOrwFEapcMkbVx4aYZ02I2f B4lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l191si6428943pge.205.2017.07.14.05.11.43; Fri, 14 Jul 2017 05:11:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754211AbdGNMLh (ORCPT + 25 others); Fri, 14 Jul 2017 08:11:37 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:65148 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbdGNMLe (ORCPT ); Fri, 14 Jul 2017 08:11:34 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lu4L0-1dgKkB2QdS-011OS1; Fri, 14 Jul 2017 14:10:01 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Yuval Mintz , Ariel Elior , everest-linux-l2@cavium.com Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Colin Ian King , Philippe Reynes Subject: [PATCH 10/22] bnx2x: fix format overflow warning Date: Fri, 14 Jul 2017 14:07:02 +0200 Message-Id: <20170714120720.906842-11-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:c1bSjVs/2GMQQiT68q3qy+sPqeH3FzltEjy9ppcUrZNtbPrRJql 2xRWAZ8BCpVzdP++5F7+Ee8Wu6GTvsufzftnFKNwhwSsBd/UoQOcXlcnCKcrCd1i+dnzAvk 8yHMpLwfwziYDQM/0RiEdmkPBwshU2YbN+hrHwEaSXSAHHzTyPkW6OrAlKl6gEr1ee9NYZK ZaQk8NHv6vS4nhgattWVQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:L1CZd1kqvUM=:5oXwQIipJPnhYLdftUY4Yc p+lSBYrzTKGgFHptjYeCxsniqQrvPCDKyo8EmbEFWfxqeN9i7oBx5gykj5Ey4+p8j/b4ShzCs bC9EjCS6Po1KfT6nXfNGWp3e6qdaaPy+Vr97a14A9sXFpUjqA+hNS5RRJ6azh9OL8maZk4KwL l6s2BSeYdFVerLQUH+YyFW/3Hv2Hcspfp5u9Gs5VwJHFRJuaZig0j9tZf2ihFYWp5DNUjETDw Oo42KT9fyKI2CRuqnx71qv2lgyAND67dO8QOJFUy0Zli5wO/cG7LRS5OOW9r85lioSTau0+Q2 iwlP9zOrrx2l8LakuRHpWqYsMbLqzgYTQ+znm600UQhE1x6QGzqSGjRB5+9et9CPUtMvv5jm1 tcnXopc+Ibd5JQ0M9qfRTbnDyguIWaD6yHblLs5xYPBw8GK2RaUIksvcdlDF4Q+02ceqrC+vn 8XUS50tGogEg0bNt/tgrnUj6OLMWqTy6hArd9tle5vNTuKEXX7Loq88gQ8Ker8gOvNr4Q2rop xDpXiQ0P+pABGm0n7vX3CVBS80OY7CEUutujDhzHr34EI8JZ9Al6uv2H7gWXLdi4TUjvwYtw6 NwcQ4DkJRU91MYd5m9VXWcSUbm88MzPagk14HNlf0BiZtwwRQt3scC9juv/Ijn5ZU8wpFcoWZ ORfrMuIRQLlkvOsYVN8e8JpoYWarMobjTQ7thgawjfD29NeNIs9xz3gT+o2W1SXh/KRpRCeS2 o7AdhL4eq/WX7VMJW2LAKcR0Bz9PRy4Dfdu5Ng== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc notices that large queue numbers would overflow the queue name string: drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function 'bnx2x_get_strings': drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=] drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: note: directive argument in the range [0, 2147483647] drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:5: note: 'sprintf' output between 2 and 11 bytes into a destination of size 5 There is a hard limit in place that makes the number at most two digits, so the code is fine. This changes it to use snprintf() to truncate instead of overflowing, which shuts up that warning. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c index 21bc4bed6b26..1e33abde4a3e 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c @@ -3162,7 +3162,8 @@ static void bnx2x_get_strings(struct net_device *dev, u32 stringset, u8 *buf) if (is_multi(bp)) { for_each_eth_queue(bp, i) { memset(queue_name, 0, sizeof(queue_name)); - sprintf(queue_name, "%d", i); + snprintf(queue_name, sizeof(queue_name), + "%d", i); for (j = 0; j < BNX2X_NUM_Q_STATS; j++) snprintf(buf + (k + j)*ETH_GSTRING_LEN, ETH_GSTRING_LEN,