From patchwork Fri Jul 14 12:07:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 107789 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp890713obm; Fri, 14 Jul 2017 05:11:55 -0700 (PDT) X-Received: by 10.99.121.77 with SMTP id u74mr14383957pgc.107.1500034315740; Fri, 14 Jul 2017 05:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500034315; cv=none; d=google.com; s=arc-20160816; b=VDXzTQdp7Wnhd6KDQLmaBiX0R/StYuu/xuKdSVUn9kS2g94AsR3ip7KR5wpgDqbqhD YR6z+mXCuGYvWDr61nbO+Ebf/b3UsEvfOHwVx3VsLOZ3I/j7+s5awvtIXwbs5Vux4lJH MUIjywXDZGfWBorPz8miJEAk0XGS7pL9bGYxE6b5d+wC0qfBlgAIKzPN35Yd5fnldcUH sGWp7cSfQ30+xQZRizuPdnFZHjl2h0hDHMnRT+Nn8EQb6DKQNVwy9d9lRvgw7PD4GBLT 3BIA1eD41NRoaMXbJDMILhqv1JIFIq3cu2CLw7Kd5Rqkuj2cEq5C7eTnHCqXMzfQYbrG 1R4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=d5uF4os3gopoODiJiEacNZbhaOgfo9g1Y2mbucjhNMc=; b=HnNkSou7CjlER3gJDgqK0GHB8ng3PbUtbfn71S9zC5xRTiqjEgZ/2/F7wjE7TcIi9K 1kjyl60+QZ3sxqAI81crOQwE44hz4PbaAuGHZGEpFElFJY6f0bDNPohnn5QS1KdsSw6E qfiAx/d1gKHU6GAkkRYvt6JBMgnLEQg0Js0+8rLzfU98oCo384T003dm+faelQWQui7I Q59x3auRbMoTP/phfqmODLkckijJAy1qtOrBCSuZTGjzfYRRZJ8U/lNIi1QIfQCNaiRl COflclnIAML3NuEOjYtJ8S7E3fMwsEr2f9wyzqsRJOJi/+ZDtJSYZxMB8a45HlwoyoIJ ikYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6si6855494pln.23.2017.07.14.05.11.55; Fri, 14 Jul 2017 05:11:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932130AbdGNMLm (ORCPT + 25 others); Fri, 14 Jul 2017 08:11:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61645 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbdGNMLj (ORCPT ); Fri, 14 Jul 2017 08:11:39 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0Mf1KL-1dGvXl2BDN-00OWv0; Fri, 14 Jul 2017 14:10:32 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Shrikrishna Khare , "VMware, Inc." Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann Subject: [PATCH 12/22] vmxnet3: avoid format strint overflow warning Date: Fri, 14 Jul 2017 14:07:04 +0200 Message-Id: <20170714120720.906842-13-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:P2RaBenBKc4eTUfOsEZ4xqyJbEaYR3P5Vx8j3pSAdMLqJpaRwfC 7YuUUvIqkOXnmzHPFAcDhK3GwxTVwZetsLoWRW8Ko+twyNs+Yy/SPGWP3BFmqSxLLb2wzIz Y32QvDuCauxji8VfES/xpvLbkktfzxZpEhRBO8FXwG7ohUVAt8Me86BlAOjLEfBlag5NToq 2Snyjvpdh4eygbl3UFtZw== X-UI-Out-Filterresults: notjunk:1; V01:K0:clGIvw0dkoA=:JGIzyFf24d82hzneC2fnEQ F8tHoPJjdgrUJaHOKRlG4P1f0SduwBWmoAU6Kb6FbyF29pTfmL9RZxTisyamHupo70hW3ZI9F Wf6wY6uLmTUEMY+IRAmgh3Y06iRX7x1OYIsHRf0v5c/y9Ly1PSQC7rI9171dD1PKP0P3meCGK nIPRPEpMRqnFZ+zFZJrjWzINPr/CO7T76RLxL5GSIUrgQmSbTvX0MulXyMr9IQqWAdEDpGGo2 NJyK0fb3fGBSxxZunPedY8vnUWSLSi93lZEuQ9i3DGKtnGEq97YGLTffCj6DOtzvLWhiNDD9a yBcqB26yLjSA6VUEbMjQSKOhW1U/m5Y2lkdT/xK3utu1181azvQECr0y0JnFcRv0aOuBYR7Aa ZyUO9jDHiRfREEY3mwX8RptWgkmLmKTZCokaCbDP3VmLXCuHQvQQ9ju6pA6ys2qj5lt0c7CS8 dBdLd2cWiZeQ6u80LVylOfBMtmxWLuldfVEmnW0CCzSyhDASEg0UXVHWuf1z6nJNZhRZTdVU4 NaqG6D8WjivE/dmaQuBEOJW/FLzENA+Egkb7eTv7tmbPKpBrWaK1RMWUKViXW/+jZvvBPY0Hr u2uX/56V4WSdowf5Fn/g6WST8zf9atLGTrel36XfGD9RX+r5Lcw7VXn5TiQPH5UlHJF5xUEQ4 b5kZQ35cMNwWGg2BU2YGOi3mBFqRmt1Nm8YYU1ej7qQcN1GIIjxqMwE7iskW5B9UFFaVKvXm5 vZtacPa1CG/C6FkR2GwTc8TD3kJzB67WkoD3bA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 notices that "-event-%d" could be more than 11 characters long if we had larger 'vector' numbers: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev': drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(intr->event_msi_vector_name, "%s-event-%d", ^~~~~~~~~~~~~ drivers/net/vmxnet3/vmxnet3_drv.c:2095:3: note: 'sprintf' output between 9 and 33 bytes into a destination of size 32 The current code is safe, but making the string a little longer is harmless and lets gcc see that it's ok. Signed-off-by: Arnd Bergmann --- drivers/net/vmxnet3/vmxnet3_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index ba1c9f93592b..9c51b8be0038 100644 --- a/drivers/net/vmxnet3/vmxnet3_int.h +++ b/drivers/net/vmxnet3/vmxnet3_int.h @@ -311,7 +311,7 @@ struct vmxnet3_intr { u8 num_intrs; /* # of intr vectors */ u8 event_intr_idx; /* idx of the intr vector for event */ u8 mod_levels[VMXNET3_LINUX_MAX_MSIX_VECT]; /* moderation level */ - char event_msi_vector_name[IFNAMSIZ+11]; + char event_msi_vector_name[IFNAMSIZ+17]; #ifdef CONFIG_PCI_MSI struct msix_entry msix_entries[VMXNET3_LINUX_MAX_MSIX_VECT]; #endif