From patchwork Fri Jul 14 12:07:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 107793 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp892335obm; Fri, 14 Jul 2017 05:13:12 -0700 (PDT) X-Received: by 10.84.216.13 with SMTP id m13mr15575553pli.201.1500034392649; Fri, 14 Jul 2017 05:13:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500034392; cv=none; d=google.com; s=arc-20160816; b=xNsOlajLA5+GVp13Dlt15RGtmrai4I/PCX8trlX6puaPSLwAqrRjzxV08RZldv75HL 2zyPlIDnbqTXI1KHYK3Vzgip5JjP5GFkQ6R9oF20KxOhfT4MNLcRvvEHCP03AZjTAW+h k4PrfCAD2kPZqQoGjiy3JLkI9q0ryh4g2aFvkKhE6gOaMWgSJSCKGdTgu1cNYHF5OchB nJTbkuW2EG1jBU7+jVrDklPnPHrRdaEy2B2dBlAm4C9soTyTbSb9KYKh3brbSNNkVjdW yOVmsQHYtUcWxpvLExzCvEu8DEtaykqYugOWFluED0e3dwnaL7oY7SVt2WuzCY01XOzu MsBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=wkTV8lUrV/j/eIBpbCJFMTm/QWgJEMpbn0xXcny/S6I=; b=xDRDLJlTFtRtBdq649HLunpX/kVQPRx0k3qxrGmUlrloA2yby1/nTtbT2Y+g64pG9B U421vjOcvjYGzN4+Dc0qWPRiAeBeePXN1vtueIf/3iDmYPXIjaDNR51b+Z3L+ggCanUi Tb+PMJIWNNFyi2wlKDOU4Dnh/eyYCB1oK9cTHxgfN8VkQR+M1ABSUt97v0tHVl6jT50M wgFLlnzP7mbkZrDTcmUnvDolutyG9o4sOQCx0J5JeJTEowLLriQGO+nPGtRbQIsPahpZ gF4umVpn8u5o/13mrc+JdnnuNktrgocGNlz3o08YL+19wOMo/yS+iWCMyI0UAFIEe8mM 3p0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y22si6917635pli.164.2017.07.14.05.13.12; Fri, 14 Jul 2017 05:13:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932169AbdGNMNI (ORCPT + 25 others); Fri, 14 Jul 2017 08:13:08 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60900 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754256AbdGNMMc (ORCPT ); Fri, 14 Jul 2017 08:12:32 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MSrBt-1d6zuO0zYr-00RmaI; Fri, 14 Jul 2017 14:11:05 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Sakari Ailus , linux-media@vger.kernel.org Subject: [PATCH 14/22] [media] usbvision-i2c: fix format overflow warning Date: Fri, 14 Jul 2017 14:07:06 +0200 Message-Id: <20170714120720.906842-15-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:2XJD1jUlPzw9FKBfso5qF39QSPl71WsFcuA6LbOeeBJSW10bY0P DCHuNRZ/h/1TQR5+eS0fxzl7st9a+s6cO3MmEi2aBP6U/MzP+i0JLJLkFbSTKGUY5ZDpK8c 5EaJ6gFgKbGXEBi2p2/yARMQtwL78GeAe4vRJoUt1JJFz2sq3jae1NpkSF4HE436rWLizUn UVg6GIJaBX1tU8ZCFnNEQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:OnmJhxsmQiQ=:PkFulciumtMPaR9bQqxcA3 viKStjAgs89yynULMvF3N3eIeeanzDsEczFU8xClV98+b2rK5HULDXif9pvDmLvZSy9Qz/9xh D2B+98p2pnw+EMfz5Krg12WwQ6T0eG2QAsnf+wCTAH490FV3XOxVI8ASj1U5/7mMjWG1nVOnm lQVvEXelQSJ4q8ON9bMhQWLxM/AS1k5x5yMj2TSDFouxmN7wrJxPnzFNCPk2tYDZlUEt+ErMj fuk0gU9R6+Bt6bC7TGtjQjI+qhPm6cwGb8shNYOn+ZkQ3I6+hR5WwVB6NPT/bkDT800kcyyNX j+VPY6ojemWd8krsL1V4RIWfYYk6dY+dqfHWTZslBTAC+MWUkpZyaZQk0OIebI5PcbsKE4auF vIKbPj8j7f9dhvDhb1mcbzIT6O6T5R4ny9hrtkpOc7Rn+d/PI9W6CTnh9ntvx9mRYSnt4Ueb+ 1CpAdkHNUKPsfZwzu05TfZp6f4rrsaiAP4o7z2Lzafr4a+ewjdxflwOvjOqo1KcLfs/QUrf95 ZfoF+Y5HNtAALONwUvt9vb0EU0ARj0k4HzIdrwMf1wODePs1/4jX/IPCmiTwnkldfmH0mvakv gMKXxk0KZNR6sPQML571EPrETo7pMG7v+pXBiMjbX0nWXpEjLrFYEfw2Gyc5h5cYha0q3P565 hDCLKLxujMP5r4domarJEc4OOfb+F+f39Ag+TSpSBWX/4PYx3q0QnMoUYgMCTX+hK46IabPMD zEd8LG9JzkywIfT6+DvuMBO9qmM/oVMQB3zgow== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 notices that we copy a fixed length string into another string of the same size, with additional characters: drivers/media/usb/usbvision/usbvision-i2c.c: In function 'usbvision_i2c_register': drivers/media/usb/usbvision/usbvision-i2c.c:190:36: error: '%d' directive writing between 1 and 11 bytes into a region of size between 0 and 47 [-Werror=format-overflow=] sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name, ^~~~~~~~~~ drivers/media/usb/usbvision/usbvision-i2c.c:190:2: note: 'sprintf' output between 4 and 76 bytes into a destination of size 48 We know this is fine as the template name is always "usbvision", so we can easily avoid the warning by using this as the format string directly. Signed-off-by: Arnd Bergmann --- drivers/media/usb/usbvision/usbvision-i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/media/usb/usbvision/usbvision-i2c.c b/drivers/media/usb/usbvision/usbvision-i2c.c index fdf6b6e285da..aae9f69884da 100644 --- a/drivers/media/usb/usbvision/usbvision-i2c.c +++ b/drivers/media/usb/usbvision/usbvision-i2c.c @@ -187,8 +187,8 @@ int usbvision_i2c_register(struct usb_usbvision *usbvision) usbvision->i2c_adap = i2c_adap_template; - sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name, - usbvision->dev->bus->busnum, usbvision->dev->devpath); + sprintf(usbvision->i2c_adap.name, "usbvision-%d-%s", + usbvision->dev->bus->busnum, usbvision->dev->devpath); PDEBUG(DBG_I2C, "Adaptername: %s", usbvision->i2c_adap.name); usbvision->i2c_adap.dev.parent = &usbvision->dev->dev;