From patchwork Mon Jul 17 12:44:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 107929 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp4478253qge; Mon, 17 Jul 2017 05:56:30 -0700 (PDT) X-Received: by 10.237.43.199 with SMTP id e65mr29896775qtd.19.1500296190883; Mon, 17 Jul 2017 05:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500296190; cv=none; d=google.com; s=arc-20160816; b=D+lN/61h4M3/8FKDStlI+954c8iYzPZDqDx+1BqEekZkoe/AsSwKZnk3ix3gbTh3FB 4cdjSmiV+VNqh4IIUDqj8vFtrRYvvGfKyRgdcjno90w/ICCkoPgBjJa+dFlkBDpnmqpx I2T0+zkXCyZbsYll56EI87fA3FkELxwuQq9auNqWBpaMG7XH/j6ONF+Hck4hssaMjJ9R Ph48QG/537xQXOVFA+li0nFx+KD0t2+oEhR+aA+qqzf/KCUGqBfw25tDEwEQWlZ6Wbzy JlerdYz3FkdoLKSN3foWELvkz8KDLxlHfRekNtzJhGcrtYft0zhOfapNUtvp+frSSuXQ HKcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=ahn6p5BrDCdi06Rw46z/4qfuz9/1FUbAUScpO4Q2qUY=; b=fW+P6YSokz/JhMBVEArzKAZX+ZZakuREFfmBIfSDISbP/AJtHvH7u3a39hptK6IZWd ZHyJC35P5GzKAmIUcNNi9qeFwa9gvXzP7M/OC9183o9hAolktvAtZSx4GWkBKoiBVJ5G 0JMAK+Xq3pibdOqF1mDGjmTHfCAc+gH3481figg5GFxF4eJUqOATUX351ABu+vY30Fqs L+L+vCOm+6pN0xynd6GaOllI0jXxyThfxFlpw6KPMAl9RK2pho9aiqRFfWVmqmr7DHpu VuRYTLuWL22TFEpr4LGkX5BVPdf9BjCz7u6IJf6wtJPdeFcS/W9BseY2QasY9Cj7W6Tl 9/hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y3si1627162qkc.225.2017.07.17.05.56.30 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 17 Jul 2017 05:56:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:50222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX5Zb-0000gA-VK for patch@linaro.org; Mon, 17 Jul 2017 08:56:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX5Og-0007wF-0v for qemu-devel@nongnu.org; Mon, 17 Jul 2017 08:45:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX5Of-0002JW-9P for qemu-devel@nongnu.org; Mon, 17 Jul 2017 08:45:10 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:37639) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dX5Of-00029H-3T for qemu-devel@nongnu.org; Mon, 17 Jul 2017 08:45:09 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1dX5OU-0003TG-7M for qemu-devel@nongnu.org; Mon, 17 Jul 2017 13:44:58 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 17 Jul 2017 13:44:42 +0100 Message-Id: <1500295494-8991-7-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500295494-8991-1-git-send-email-peter.maydell@linaro.org> References: <1500295494-8991-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 06/18] target/arm/translate.h: expand comment on DISAS_EXIT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20170713141928.25419-4-alex.bennee@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/target/arm/translate.h b/target/arm/translate.h index 15d383d..12fd79b 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -140,7 +140,10 @@ static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) */ #define DISAS_BX_EXCRET 11 /* For instructions which want an immediate exit to the main loop, - * as opposed to attempting to use lookup_and_goto_ptr. + * as opposed to attempting to use lookup_and_goto_ptr. Unlike + * DISAS_UPDATE this doesn't write the PC on exiting the translation + * loop so you need to ensure something (gen_a64_set_pc_im or runtime + * helper) has done so before we reach return from cpu_tb_exec. */ #define DISAS_EXIT 12