[Xen-devel,20/25,v6] xen/arm: vpl011: Add a new console_close_evtchn function in xenconsole

Message ID 1500296815-10243-21-git-send-email-bhupinder.thakur@linaro.org
State New
Headers show
Series
  • SBSA UART emulation support in Xen
Related show

Commit Message

Bhupinder Thakur July 17, 2017, 1:06 p.m.
This patch introduces a console_close_evtchn console_cleanup function. This function
closes the console event channel.

Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>

Changes since v5:
- Split this change in a separate patch.

 tools/console/daemon/io.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Wei Liu July 18, 2017, 1:14 p.m. | #1
On Mon, Jul 17, 2017 at 06:36:50PM +0530, Bhupinder Thakur wrote:
> This patch introduces a console_close_evtchn console_cleanup function. This function
> closes the console event channel.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>

Acked-by: Wei Liu <wei.liu2@citrix.com>
Stefano Stabellini July 18, 2017, 7:56 p.m. | #2
On Mon, 17 Jul 2017, Bhupinder Thakur wrote:
> This patch introduces a console_close_evtchn console_cleanup function. This function
> closes the console event channel.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> 
> Changes since v5:
> - Split this change in a separate patch.
> 
>  tools/console/daemon/io.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
> index 93fc8cc..54c91aa 100644
> --- a/tools/console/daemon/io.c
> +++ b/tools/console/daemon/io.c
> @@ -800,6 +800,14 @@ static void cleanup_domain(struct domain *d)
>  	remove_domain(d);
>  }
>  
> +static void console_close_evtchn(struct console *con)
> +{
> +	if (con->xce_handle != NULL)
> +		xenevtchn_close(con->xce_handle);
> +
> +	con->xce_handle = NULL;
> +}
> +
>  static void shutdown_domain(struct domain *d)
>  {
>  	struct console *con = &d->console;
> @@ -807,9 +815,7 @@ static void shutdown_domain(struct domain *d)
>  	d->is_dead = true;
>  	watch_domain(d, false);
>  	console_unmap_interface(con);
> -	if (con->xce_handle != NULL)
> -		xenevtchn_close(con->xce_handle);
> -	con->xce_handle = NULL;
> +	console_close_evtchn(con);
>  }
>  
>  static unsigned enum_pass = 0;
> -- 
> 2.7.4
>

Patch hide | download patch | download mbox

diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index 93fc8cc..54c91aa 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -800,6 +800,14 @@  static void cleanup_domain(struct domain *d)
 	remove_domain(d);
 }
 
+static void console_close_evtchn(struct console *con)
+{
+	if (con->xce_handle != NULL)
+		xenevtchn_close(con->xce_handle);
+
+	con->xce_handle = NULL;
+}
+
 static void shutdown_domain(struct domain *d)
 {
 	struct console *con = &d->console;
@@ -807,9 +815,7 @@  static void shutdown_domain(struct domain *d)
 	d->is_dead = true;
 	watch_domain(d, false);
 	console_unmap_interface(con);
-	if (con->xce_handle != NULL)
-		xenevtchn_close(con->xce_handle);
-	con->xce_handle = NULL;
+	console_close_evtchn(con);
 }
 
 static unsigned enum_pass = 0;