From patchwork Mon Jul 17 16:05:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 108008 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp4708879qge; Mon, 17 Jul 2017 09:11:10 -0700 (PDT) X-Received: by 10.28.130.132 with SMTP id e126mr4929505wmd.107.1500307870667; Mon, 17 Jul 2017 09:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500307870; cv=none; d=google.com; s=arc-20160816; b=b+mTsawA2zWSqihxPm8HKQ0li+W9R/0aAKPvqrbf6uqcSFkSjolU8iXx9SqrG8qJHr pUxFYpqTyBy3tRItD8xMtfsPPsSp+yVtkxDcFj2F5fiNCtei2djUCmzG5aHF5ppQ4E3E g3DHsknURF5OEczU09gX/8hbhns4o6GRm9DBaa++Yqnh1rUsqFlDoN2qEWcVZe/S9W1o k3/drw1m1Nowob7CExt64ByKrg+nK2yC5aDRh9Jw3JdzJxEE3wt6umR6lOwDbDrbVXIW IQqH+ak8HQDbzgCDnAmSYerStkdS6EzTkFfIOjICKi8GEo2urt3T4/QSmy3M12OySZpS C3Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=iHCKPNDf1znVxJUvNZvstnd6WlxcNcF/64MsApKUq74=; b=zrD+R06GBFNQMXoRQFISG+ZhRVTsqMb7ezxKeTPHR73OINeMVi7RDfYQMNCqP2oaus Fto34B9ybtwRtsnFn1ltkC0/8iu/qNmKPKANl/VkfH7rl6Zc/fZwP8zJoodx84SeDT3B c/t5+M1T8c7iAv/tGblbygQ6RBro+jKRreqQMn8pC+VN0jLy7u9FUsid+nqQihI9q2yp O1rPr+f2oxM7XXsRqYSxGDoWNbDvnQlIDbnX0ByB7DOu12kY/SWxkowP1czP8iRAYdXm aJ8Yp3+u9iTiJc5gqgNe2O2kuqNewQ6+2ag81ghmSuFn8snLSusd4l3VKmzErscPa4N0 Mv7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id c28si4010963wra.29.2017.07.17.09.11.10; Mon, 17 Jul 2017 09:11:10 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1E5FB26748E; Mon, 17 Jul 2017 18:06:47 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1072626746F; Mon, 17 Jul 2017 18:06:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id EB6AA267398 for ; Mon, 17 Jul 2017 18:05:53 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dX8Wq-0002rR-9i; Mon, 17 Jul 2017 16:05:50 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dX8Wn-0004tq-Fw; Mon, 17 Jul 2017 17:05:45 +0100 From: Mark Brown To: Fabio Estevam In-Reply-To: <1500239473-14886-8-git-send-email-festevam@gmail.com> Message-Id: Date: Mon, 17 Jul 2017 17:05:45 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [alsa-devel] Applied "ASoC: sta32x: Remove unneeded gpiod NULL check" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: sta32x: Remove unneeded gpiod NULL check has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From c5efe232e09ef29cc2f9e8333a49dd8891366c22 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Sun, 16 Jul 2017 18:11:13 -0300 Subject: [PATCH] ASoC: sta32x: Remove unneeded gpiod NULL check The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown --- sound/soc/codecs/sta32x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.13.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index 0790ae8530d9..5b888476d9ff 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -847,8 +847,7 @@ static int sta32x_set_bias_level(struct snd_soc_codec *codec, msleep(300); sta32x_watchdog_stop(sta32x); - if (sta32x->gpiod_nreset) - gpiod_set_value(sta32x->gpiod_nreset, 0); + gpiod_set_value(sta32x->gpiod_nreset, 0); regulator_bulk_disable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies);