| Message ID | 20170718214339.7774-40-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 5f214ccdd1cab5cdfbd15bf08124d456c7fd8eec |
| Headers | show |
On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > drivers/nvmem/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ping? > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 4c49285168fb..b0c60338296a 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, > > addr = of_get_property(cell_np, "reg", &len); > if (!addr || (len < 2 * sizeof(u32))) { > - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n", > - cell_np->full_name); > + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n", > + cell_np); > rval = -EINVAL; > goto err_mem; > } > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/08/17 23:14, Rob Herring wrote: > On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote: >> Now that we have a custom printf format specifier, convert users of >> full_name to use %pOF instead. This is preparation to remove storing >> of the full path string for each node. >> >> Signed-off-by: Rob Herring <robh@kernel.org> >> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> drivers/nvmem/core.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Ping? I have already sent this patch to Greg to queue up for next. Thanks, srini > >> >> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c >> index 4c49285168fb..b0c60338296a 100644 >> --- a/drivers/nvmem/core.c >> +++ b/drivers/nvmem/core.c >> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, >> >> addr = of_get_property(cell_np, "reg", &len); >> if (!addr || (len < 2 * sizeof(u32))) { >> - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n", >> - cell_np->full_name); >> + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n", >> + cell_np); >> rval = -EINVAL; >> goto err_mem; >> } >> -- >> 2.11.0 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 4c49285168fb..b0c60338296a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, addr = of_get_property(cell_np, "reg", &len); if (!addr || (len < 2 * sizeof(u32))) { - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n", - cell_np->full_name); + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n", + cell_np); rval = -EINVAL; goto err_mem; }
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html