[02/12] ARM: ep93xx: use ARM_PATCH_PHYS_VIRT

Message ID 20170720154939.3250697-1-arnd@arndb.de
State Accepted
Commit cd5bad4135e8e72144a19429d359c36fd4172a88
Headers show
Series
  • [01/12] ARM: ixp4xx: fix ioport_unmap definition
Related show

Commit Message

Arnd Bergmann July 20, 2017, 3:49 p.m.
Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT
when possible, but that fails for NOMMU or XIP_KERNEL configurations.
Using 'imply' instead of 'select' gets this right and only uses
the symbol when we don't have to hardcode the address anyway.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

Comments

Alexander Sverdlin July 20, 2017, 4:07 p.m. | #1
On Thu Jul 20 17:49:27 2017 Arnd Bergmann <arnd@arndb.de> wrote:
> Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT

> when possible, but that fails for NOMMU or XIP_KERNEL configurations.

> Using 'imply' instead of 'select' gets this right and only uses

> the symbol when we don't have to hardcode the address anyway.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>


> ---

>   arch/arm/Kconfig | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig

> index d6e6f40addf6..db856355bd24 100644

> --- a/arch/arm/Kconfig

> +++ b/arch/arm/Kconfig

> @@ -406,7 +406,7 @@ config ARCH_EP93XX

>       bool "EP93xx-based"

>       select ARCH_HAS_HOLES_MEMORYMODEL

>       select ARM_AMBA

> -    select ARM_PATCH_PHYS_VIRT

> +    imply ARM_PATCH_PHYS_VIRT

>       select ARM_VIC

>       select AUTO_ZRELADDR

>       select CLKDEV_LOOKUP

> -- 

> 2.9.0

>
Linus Walleij Aug. 2, 2017, 12:29 p.m. | #2
On Thu, Jul 20, 2017 at 5:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT

> when possible, but that fails for NOMMU or XIP_KERNEL configurations.

> Using 'imply' instead of 'select' gets this right and only uses

> the symbol when we don't have to hardcode the address anyway.

>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Linus Walleij <linus.walleij@linaro.org>


I assume you will apply this directly to ARM SoC.

Yours,
Linus Walleij

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d6e6f40addf6..db856355bd24 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -406,7 +406,7 @@  config ARCH_EP93XX
 	bool "EP93xx-based"
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARM_AMBA
-	select ARM_PATCH_PHYS_VIRT
+	imply ARM_PATCH_PHYS_VIRT
 	select ARM_VIC
 	select AUTO_ZRELADDR
 	select CLKDEV_LOOKUP