diff mbox series

[for,2.10,v2,6/6] docker: reduce noise when building travis.docker

Message ID 20170725133425.436-7-alex.bennee@linaro.org
State Superseded
Headers show
Series Various docker fixes | expand

Commit Message

Alex Bennée July 25, 2017, 1:34 p.m. UTC
Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so
much as we build the image.

Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/docker/dockerfiles/travis.docker | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.13.0

Comments

Eric Blake July 25, 2017, 2:18 p.m. UTC | #1
On 07/25/2017 08:34 AM, Alex Bennée wrote:
> Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so

> much as we build the image.

> 

> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/docker/dockerfiles/travis.docker | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker

> index 57ac8e1419..605b6e429b 100644

> --- a/tests/docker/dockerfiles/travis.docker

> +++ b/tests/docker/dockerfiles/travis.docker

> @@ -1,4 +1,7 @@

>  FROM quay.io/travisci/travis-ruby

> +ENV DEBIAN_FRONTEND noninteractive

> +ENV LANG en_US.UTF-8

> +ENV LC_ALL en_US.UTF-8


LANG is pointless if LC_ALL is set, as LC_ALL takes precedence.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Philippe Mathieu-Daudé July 25, 2017, 2:25 p.m. UTC | #2
On 07/25/2017 10:34 AM, Alex Bennée wrote:
> Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so

> much as we build the image.

> 

> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   tests/docker/dockerfiles/travis.docker | 3 +++

>   1 file changed, 3 insertions(+)

> 

> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker

> index 57ac8e1419..605b6e429b 100644

> --- a/tests/docker/dockerfiles/travis.docker

> +++ b/tests/docker/dockerfiles/travis.docker

> @@ -1,4 +1,7 @@

>   FROM quay.io/travisci/travis-ruby

> +ENV DEBIAN_FRONTEND noninteractive

> +ENV LANG en_US.UTF-8

> +ENV LC_ALL en_US.UTF-8


can be one-lined:
ENV DEBIAN_FRONTEND=noninteractive LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8
maybe add "default env vars set using travis (see [link])" in message?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


(not a bugfix)

>   RUN apt-get update

>   RUN apt-get -y build-dep qemu

>   RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools

>
diff mbox series

Patch

diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
index 57ac8e1419..605b6e429b 100644
--- a/tests/docker/dockerfiles/travis.docker
+++ b/tests/docker/dockerfiles/travis.docker
@@ -1,4 +1,7 @@ 
 FROM quay.io/travisci/travis-ruby
+ENV DEBIAN_FRONTEND noninteractive
+ENV LANG en_US.UTF-8
+ENV LC_ALL en_US.UTF-8
 RUN apt-get update
 RUN apt-get -y build-dep qemu
 RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools