| Message ID | 20170725153243.101147-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | b6eb66fd3430a1a0d1c89cf4bdb01062bdb9b738 |
| Headers | show |
On Tuesday, July 25, 2017 05:32:31 PM Arnd Bergmann wrote: > The newly added irqchip_fwnode_ops structure is not exported, which can > lead to link errors: > > ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined! > > I checked that all other such symbols that were introduced are > exported if they need to be, this is the only missing one. > > Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for the fix. It is linux-next only at this point, isn't it?
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index e064fd1390f1..9e8a075117a3 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -42,6 +42,7 @@ static inline void debugfs_remove_domain_dir(struct irq_domain *d) { } #endif const struct fwnode_operations irqchip_fwnode_ops; +EXPORT_SYMBOL_GPL(irqchip_fwnode_ops); /** * irq_domain_alloc_fwnode - Allocate a fwnode_handle suitable for
The newly added irqchip_fwnode_ops structure is not exported, which can lead to link errors: ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined! I checked that all other such symbols that were introduced are exported if they need to be, this is the only missing one. Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/irq/irqdomain.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0