| Message ID | 20170725153825.272975-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de> This is similar to patch "[PATCH -next] staging: pi433: depends on SPI" of Randy Dunlap > Arnd Bergmann <arnd@arndb.de> hat am 25. Juli 2017 um 17:38 geschrieben: > > > I ran into a build error with the new pi433 driver and > CONFIG_SPI disabled: > > drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': > pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' > drivers/staging/pi433/pi433_if.o: In function `pi433_probe': > pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' > drivers/staging/pi433/pi433_if.o: In function `pi433_init': > > I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, > and since I spot two cosmetic mistakes in the entry, I'm also > fixing the whitespace and remove the redundant 'default n'. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/pi433/Kconfig | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig > index b2716b85d5af..2fd07991c871 100644 > --- a/drivers/staging/pi433/Kconfig > +++ b/drivers/staging/pi433/Kconfig > @@ -1,16 +1,16 @@ > config PI433 > - tristate "Pi433 - a 433MHz radio module for Raspberry Pi" > - default n > - ---help--- > - This option allows you to enable support for the radio module Pi433. > + tristate "Pi433 - a 433MHz radio module for Raspberry Pi" > + depends on SPI > + ---help--- > + This option allows you to enable support for the radio module Pi433. > > - Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi > - or compatible. It extends the Raspberry Pi with the option, to > - send and receive data in the 433MHz ISM band - for example to > - communicate between two systems without using ethernet or bluetooth > - or for control or read sockets, actors, sensors, widely available > - for low price. > + Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi > + or compatible. It extends the Raspberry Pi with the option, to > + send and receive data in the 433MHz ISM band - for example to > + communicate between two systems without using ethernet or bluetooth > + or for control or read sockets, actors, sensors, widely available > + for low price. > > - For details or the option to buy, please visit https://pi433.de/en.html > + For details or the option to buy, please visit https://pi433.de/en.html > > - If in doubt, say N here, but saying yes most probably won't hurt > + If in doubt, say N here, but saying yes most probably won't hurt > -- > 2.9.0 > >
On Tue, Jul 25, 2017 at 05:38:05PM +0200, Arnd Bergmann wrote: > I ran into a build error with the new pi433 driver and > CONFIG_SPI disabled: > > drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': > pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' > drivers/staging/pi433/pi433_if.o: In function `pi433_probe': > pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' > drivers/staging/pi433/pi433_if.o: In function `pi433_init': > > I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, > and since I spot two cosmetic mistakes in the entry, I'm also > fixing the whitespace and remove the redundant 'default n'. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Randy sent in a patch just like this before you did, but he didn't touch the space/tab issue. thanks, greg k-h
diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig index b2716b85d5af..2fd07991c871 100644 --- a/drivers/staging/pi433/Kconfig +++ b/drivers/staging/pi433/Kconfig @@ -1,16 +1,16 @@ config PI433 - tristate "Pi433 - a 433MHz radio module for Raspberry Pi" - default n - ---help--- - This option allows you to enable support for the radio module Pi433. + tristate "Pi433 - a 433MHz radio module for Raspberry Pi" + depends on SPI + ---help--- + This option allows you to enable support for the radio module Pi433. - Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi - or compatible. It extends the Raspberry Pi with the option, to - send and receive data in the 433MHz ISM band - for example to - communicate between two systems without using ethernet or bluetooth - or for control or read sockets, actors, sensors, widely available - for low price. + Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi + or compatible. It extends the Raspberry Pi with the option, to + send and receive data in the 433MHz ISM band - for example to + communicate between two systems without using ethernet or bluetooth + or for control or read sockets, actors, sensors, widely available + for low price. - For details or the option to buy, please visit https://pi433.de/en.html + For details or the option to buy, please visit https://pi433.de/en.html - If in doubt, say N here, but saying yes most probably won't hurt + If in doubt, say N here, but saying yes most probably won't hurt
I ran into a build error with the new pi433 driver and CONFIG_SPI disabled: drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' drivers/staging/pi433/pi433_if.o: In function `pi433_probe': pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' drivers/staging/pi433/pi433_if.o: In function `pi433_init': I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, and since I spot two cosmetic mistakes in the entry, I'm also fixing the whitespace and remove the redundant 'default n'. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/pi433/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.9.0