From patchwork Tue Jul 25 19:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 108663 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp912111qge; Tue, 25 Jul 2017 12:00:54 -0700 (PDT) X-Received: by 10.237.56.40 with SMTP id j37mr28517133qte.45.1501009254305; Tue, 25 Jul 2017 12:00:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501009254; cv=none; d=google.com; s=arc-20160816; b=lPnHV3hcvfiu+WnxPp8Ft3vVfiBpY6+6aS+0yT6FGnI9/QOye0PdcC0Btr8etvxVWS oTI6CIGuu9cMZG+NwzyRBnsrYv1+BPYScFoQilevA46fpH6bG4y1a8+z43Hk5hnYvSkS 4vV6gHMsQvtTdwOLA0eTYJQGX8FElZq1SYx9cBSUyc16QVtD0umd0J2rZcqxDWjywy/4 IvxjUdIJVVyuvQJaFTBKz9u2CtVnt8p14qO2bYwm9j4s4opRqs6c+GDy0qqEXGlMzo/f oW8IDMX7OpgJ3a+l8WKf1Flc8gaTDt1CwqMqI/cMTK+KjGm/i+EqmG95dGq1EfAANKQz QMnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=M3XFxNs5ZXjgPZ+AivnkpEVntcN9BCplfMTemglG5PI=; b=qtCbSIYqlS6YYwKEzytkYlpo/7Hk0v6KQvQP9KyAXDKJDdt2KtIT6sknz/Wj0y9K4y g57RMVWGC5ge9o5nHf9uuOtCz71T3SFK+T6o+ev7v9YQHueowWnrEloSE6a5s7XhsK71 YO2lng3iGqaF+RIAbgT7dYdEa0cAJofgGGuW3mkiAeoAxEmhjrzsLoeTROMNtofeEBb4 6nZC4CJwaiR4W6g753uROK+1sxVb9Yd8iK0eFPmTYmNrtfeN++ECShjPkHo+BZDGVSSc t2cP/MQXQEBbOTLEPyYistOp8SoD5hcQdCY1kPzS6+hru8EfQXv4Juh+xvE9PHbgXqzw UYmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id m7si1531937qte.404.2017.07.25.12.00.53; Tue, 25 Jul 2017 12:00:54 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 6BA01644A7; Tue, 25 Jul 2017 19:00:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 5314A60B11; Tue, 25 Jul 2017 19:00:24 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id BD448608E7; Tue, 25 Jul 2017 19:00:21 +0000 (UTC) Received: from forward3p.cmail.yandex.net (forward3p.cmail.yandex.net [77.88.31.18]) by lists.linaro.org (Postfix) with ESMTPS id 7DAA3608E7 for ; Tue, 25 Jul 2017 19:00:20 +0000 (UTC) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [IPv6:2a02:6b8:0:1619::15:6]) by forward3p.cmail.yandex.net (Yandex) with ESMTP id 339B720D36 for ; Tue, 25 Jul 2017 22:00:18 +0300 (MSK) Received: from smtp4j.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4j.mail.yandex.net (Yandex) with ESMTP id 08F4D3240FD5 for ; Tue, 25 Jul 2017 22:00:17 +0300 (MSK) Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ZZmVc0vwF2-0HQGIBHd; Tue, 25 Jul 2017 22:00:17 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 25 Jul 2017 22:00:05 +0300 Message-Id: <1501009206-21235-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1501009206-21235-1-git-send-email-odpbot@yandex.ru> References: <1501009206-21235-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 87 Subject: [lng-odp] [PATCH v1 1/2] configure: remove non-standard test usage X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov According to POSIX it is correct to check for string equality using one equal sign, not two signs. POSIX-strict shells will return incorrect result on such constructions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 87 (lumag:fix-m4) ** https://github.com/Linaro/odp/pull/87 ** Patch: https://github.com/Linaro/odp/pull/87.patch ** Base sha: f4f7679d16917d9a7c1b2220e351fd27733ee96b ** Merge commit sha: 39b4f10ed8c764ff67ddc651f9b82f5c3e015119 **/ configure.ac | 6 +++--- platform/linux-generic/m4/odp_pcap.m4 | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index e4903c7a..51dd9352 100644 --- a/configure.ac +++ b/configure.ac @@ -115,7 +115,7 @@ AC_SUBST([ARCH_DIR]) ########################################################################## # Warn on the defaults if arch is undefined ########################################################################## -if test "${ARCH_DIR}" == "undefined"; +if test "${ARCH_DIR}" = "undefined"; then echo "ARCH_DIR is undefined, please add your ARCH_DIR based on host=${host}" exit 1 @@ -135,7 +135,7 @@ AS_CASE([$host], ) AC_SUBST([ARCH_ABI]) -if test "${ARCH_ABI}" == "undefined"; +if test "${ARCH_ABI}" = "undefined"; then echo "ARCH_ABI is undefined, please add your ARCH_ABI based on host=${host}" exit 1 @@ -164,7 +164,7 @@ AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) # Run platform specific checks and settings ########################################################################## IMPLEMENTATION_NAME="" -if test "${with_platform}" == "linux-generic"; +if test "${with_platform}" = "linux-generic"; then m4_include([./platform/linux-generic/m4/configure.m4]) m4_include([./test/linux-generic/m4/configure.m4]) diff --git a/platform/linux-generic/m4/odp_pcap.m4 b/platform/linux-generic/m4/odp_pcap.m4 index ffdff17c..d7295f21 100644 --- a/platform/linux-generic/m4/odp_pcap.m4 +++ b/platform/linux-generic/m4/odp_pcap.m4 @@ -8,7 +8,7 @@ AC_CHECK_HEADER(pcap/pcap.h, [])], []) -if test $have_pcap == yes; then +if test "$have_pcap" = "yes"; then ODP_CFLAGS="$AM_CFLAGS -DHAVE_PCAP" PCAP_LIBS="-lpcap" fi