From patchwork Tue Jul 25 20:45:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 108702 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp28849qge; Tue, 25 Jul 2017 13:45:53 -0700 (PDT) X-Received: by 10.84.210.65 with SMTP id z59mr18308576plh.450.1501015553704; Tue, 25 Jul 2017 13:45:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501015553; cv=none; d=google.com; s=arc-20160816; b=GOIS5F9umoMpvseTExqIvJX+JH6dBr+8rjJXX94xrRpTWXvaXCWLcw/QKbekKGYCQg 3UhIox0uK051CTckxEvBbCupq6E3Pwbnr7JUWn5TBpPhpAyly0gCS9ie//B0DQrbN3pJ HUfyrGslE5lQevruRCSC4OSFTheCh59ykgnc7Fxzr8EtyWi5yp7RpMckT8c+7FA6VY32 bS2pMkVR8Y/lFT5+A7Bb+lw27vTfKqplhKF5FvPcNWjFyFf0c5DFwiZt9ZCdiNrdqLs0 raz1FJhIwkBfUa4gC1N/lLM+7g6pqivujsF+qeoD85CnYxafG9JdlbSbH0ASAC47eNQb tGqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=sgAUo9oml6MBc6ka8Tl6/rhEc9BFwvMnrusY6nSRMlM=; b=XSv2k5z7ySBGLMXbrl4ERdfpuNEcNeL6K7XVK2XS3DKyXOyy/kJ8hiUXz14aJ60pM6 D7NMOULL35JvAeqj8b3Fanh7sLGiH1Wgxb9DKX9i+mY/fY+XsiEWzv4SeF4WLO3ITXxn 2Gn9putLmkPL9lYpi1OwqvbaIYRJriCT1oWf9SOEnWToMN+i9UWAwn68tR1SSOh/9cGh clbP7RY0Ky6Ekn6mcejAe840f3knLwOpQCnzuq1ff/yLUFBnC2JbJ3TLZyQnVEug301y df/l7EG76qEWHNRBeCKa43QWMFTU7d0SXBrmSRA4K7tLZCB9KfNBOd3IBrkFlKqfBLjI 8qOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=JTpztAhE; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si9102153plm.762.2017.07.25.13.45.53; Tue, 25 Jul 2017 13:45:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=JTpztAhE; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbdGYUpv (ORCPT + 6 others); Tue, 25 Jul 2017 16:45:51 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:37313 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbdGYUpt (ORCPT ); Tue, 25 Jul 2017 16:45:49 -0400 Received: by mail-pg0-f44.google.com with SMTP id y129so74741551pgy.4 for ; Tue, 25 Jul 2017 13:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sgAUo9oml6MBc6ka8Tl6/rhEc9BFwvMnrusY6nSRMlM=; b=JTpztAhEuzpvCrKqaxVWo69crdOV07dXPcmWIf19tGkKYS4OHS1okZlB7OPxDSyIQ+ 3qWco8ohXB1YojEyh7R3j7C0V6cqdsTxPUc+lDYHh7Fny85ksas47QvBJ1bUneKS1JCD RKXAPm5zh3SfDCOuQMM4hoVgVMdwgCFZiDRRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sgAUo9oml6MBc6ka8Tl6/rhEc9BFwvMnrusY6nSRMlM=; b=b926Zct+HDw7f3tz/1NUZ1xAXW9uY/NUNNm+AW7Dvnj4Y8a55ZMFRxncXmplUC08Gl znzkpezVyzf76CFLlWyc8G92X713RKC0r8GwbBMwhcLE0/yMtzkRLZS7hORKNd5/j/vI KMppRhd0zYGsTcd7bS9CHP404ThwVFiSxtkH/a86F1hIP7wFWetW+vZZUcU8hRyRDLmv m54+UTL83OkAZiYwT/4z57LHntCEhT6KpVd6Gjxl8UrIz/vLHnPLbdYpMTPkXi6G8He5 4nPf/gEh2U+JfDC06RoyaAnSugz3VLBq2H+KCo6/R64+wfgc+sDycm1CuvWdHK87gZyT q2nQ== X-Gm-Message-State: AIVw113oH8epw4oUtmFzF9vga3OkkgApZyZ9ry6HoccVCX5x9l3qmjMH wxQnmOtBv6IrLu0Hde33uw== X-Received: by 10.84.128.195 with SMTP id a61mr22977280pla.222.1501015549299; Tue, 25 Jul 2017 13:45:49 -0700 (PDT) Received: from localhost.localdomain ([106.51.135.235]) by smtp.gmail.com with ESMTPSA id d4sm532125pfj.59.2017.07.25.13.45.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Jul 2017 13:45:48 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Oliver Neukum , "David S . Miller" Subject: [PATCH for-3.18 06/15] kaweth: fix firmware download Date: Wed, 26 Jul 2017 02:15:17 +0530 Message-Id: <1501015526-32178-7-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1501015526-32178-1-git-send-email-amit.pundir@linaro.org> References: <1501015526-32178-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Oliver Neukum commit 60bcabd080f53561efa9288be45c128feda1a8bb upstream. This fixes the oops discovered by the Umap2 project and Alan Stern. The intf member needs to be set before the firmware is downloaded. Signed-off-by: Oliver Neukum Signed-off-by: David S. Miller Signed-off-by: Amit Pundir --- drivers/net/usb/kaweth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index dcb6d33141e0..95ef45a5e9df 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1029,6 +1029,7 @@ static int kaweth_probe( kaweth = netdev_priv(netdev); kaweth->dev = udev; kaweth->net = netdev; + kaweth->intf = intf; spin_lock_init(&kaweth->device_lock); init_waitqueue_head(&kaweth->term_wait); @@ -1139,8 +1140,6 @@ err_fw: dev_dbg(dev, "Initializing net device.\n"); - kaweth->intf = intf; - kaweth->tx_urb = usb_alloc_urb(0, GFP_KERNEL); if (!kaweth->tx_urb) goto err_free_netdev;