ACPI: processor: use dev_dbg() instead of dev_warn() when CPPC probe failed

Message ID 1501065612-45769-1-git-send-email-guohanjun@huawei.com
State New
Headers show

Commit Message

Hanjun Guo July 26, 2017, 10:40 a.m.
From: Hanjun Guo <hanjun.guo@linaro.org>


_CPC is a optinal object for processor device so it's
fine for processor devices in DSDT without CPPC data,
but when booting the system with CPPC enabled in the
kernel but without its support in the firmware, I got
lots of warnings on a 64 core system:

[    6.346016] acpi ACPI0007:00: CPPC data invalid or not present
[    6.346028] acpi ACPI0007:01: CPPC data invalid or not present
[    6.346039] acpi ACPI0007:02: CPPC data invalid or not present
[    6.346050] acpi ACPI0007:03: CPPC data invalid or not present
[    6.346063] acpi ACPI0007:04: CPPC data invalid or not present
...
[    6.346737] acpi ACPI0007:3f: CPPC data invalid or not present

This isn't much useful and a little bit noise, so
switch the dev_warn() to dev_dbg().

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

Cc: Alexey Klimov <alexey.klimov@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/acpi/processor_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.12.4

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rafael J. Wysocki July 27, 2017, 11:52 p.m. | #1
On Wednesday, July 26, 2017 06:40:12 PM Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>

> 

> _CPC is a optinal object for processor device so it's

> fine for processor devices in DSDT without CPPC data,

> but when booting the system with CPPC enabled in the

> kernel but without its support in the firmware, I got

> lots of warnings on a 64 core system:

> 

> [    6.346016] acpi ACPI0007:00: CPPC data invalid or not present

> [    6.346028] acpi ACPI0007:01: CPPC data invalid or not present

> [    6.346039] acpi ACPI0007:02: CPPC data invalid or not present

> [    6.346050] acpi ACPI0007:03: CPPC data invalid or not present

> [    6.346063] acpi ACPI0007:04: CPPC data invalid or not present

> ...

> [    6.346737] acpi ACPI0007:3f: CPPC data invalid or not present

> 

> This isn't much useful and a little bit noise, so

> switch the dev_warn() to dev_dbg().

> 

> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

> Cc: Alexey Klimov <alexey.klimov@arm.com>

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---

>  drivers/acpi/processor_driver.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c

> index 591d1dd..9d6aff2 100644

> --- a/drivers/acpi/processor_driver.c

> +++ b/drivers/acpi/processor_driver.c

> @@ -237,7 +237,7 @@ static int __acpi_processor_start(struct acpi_device *device)

>  

>  	result = acpi_cppc_processor_probe(pr);

>  	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))

> -		dev_warn(&device->dev, "CPPC data invalid or not present\n");

> +		dev_dbg(&device->dev, "CPPC data invalid or not present\n");

>  

>  	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)

>  		acpi_processor_power_init(pr);

> 


Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index 591d1dd..9d6aff2 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -237,7 +237,7 @@  static int __acpi_processor_start(struct acpi_device *device)
 
 	result = acpi_cppc_processor_probe(pr);
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
-		dev_warn(&device->dev, "CPPC data invalid or not present\n");
+		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
 	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
 		acpi_processor_power_init(pr);