[PATCHv1] test: classification: fix: update odp_pktin_queue_param_t

Message ID 1501162009-11539-1-git-send-email-bala.manoharan@linaro.org
State New
Headers show

Commit Message

Balasubramanian Manoharan July 27, 2017, 1:26 p.m.
classifier_enable field in odp_pktin_queue_param_t has to set to true
for classification test suite to function correctly.

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

---
 .../validation/api/classification/odp_classification_common.c           | 2 ++
 .../validation/api/classification/odp_classification_tests.c            | 2 ++
 2 files changed, 4 insertions(+)

-- 
1.9.1

Comments

Maxim Uvarov July 27, 2017, 8:01 p.m. | #1
test also should test case if flag is false.

Maxim.

On 07/27/17 16:26, Balasubramanian Manoharan wrote:
> classifier_enable field in odp_pktin_queue_param_t has to set to true

> for classification test suite to function correctly.

> 

> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

> ---

>  .../validation/api/classification/odp_classification_common.c           | 2 ++

>  .../validation/api/classification/odp_classification_tests.c            | 2 ++

>  2 files changed, 4 insertions(+)

> 

> diff --git a/test/common_plat/validation/api/classification/odp_classification_common.c b/test/common_plat/validation/api/classification/odp_classification_common.c

> index eca30b8..1b142e1 100644

> --- a/test/common_plat/validation/api/classification/odp_classification_common.c

> +++ b/test/common_plat/validation/api/classification/odp_classification_common.c

> @@ -50,6 +50,8 @@ odp_pktio_t create_pktio(odp_queue_type_t q_type, odp_pool_t pool)

>  

>  	odp_pktin_queue_param_init(&pktin_param);

>  	pktin_param.queue_param.sched.sync = ODP_SCHED_SYNC_ATOMIC;

> +	pktin_param.classifier_enable = true;

> +	pktin_param.hash_enable = false;

>  

>  	if (odp_pktin_queue_config(pktio, &pktin_param)) {

>  		fprintf(stderr, "pktin queue config failed.\n");

> diff --git a/test/common_plat/validation/api/classification/odp_classification_tests.c b/test/common_plat/validation/api/classification/odp_classification_tests.c

> index 4f43082..a0f73e3 100644

> --- a/test/common_plat/validation/api/classification/odp_classification_tests.c

> +++ b/test/common_plat/validation/api/classification/odp_classification_tests.c

> @@ -52,6 +52,8 @@ int classification_suite_init(void)

>  

>  	odp_pktin_queue_param_init(&pktin_param);

>  	pktin_param.queue_param.sched.sync = ODP_SCHED_SYNC_ATOMIC;

> +	pktin_param.classifier_enable = true;

> +	pktin_param.hash_enable = false;

>  

>  	if (odp_pktin_queue_config(pktio_loop, &pktin_param)) {

>  		fprintf(stderr, "pktin queue config failed.\n");

>

Patch

diff --git a/test/common_plat/validation/api/classification/odp_classification_common.c b/test/common_plat/validation/api/classification/odp_classification_common.c
index eca30b8..1b142e1 100644
--- a/test/common_plat/validation/api/classification/odp_classification_common.c
+++ b/test/common_plat/validation/api/classification/odp_classification_common.c
@@ -50,6 +50,8 @@  odp_pktio_t create_pktio(odp_queue_type_t q_type, odp_pool_t pool)
 
 	odp_pktin_queue_param_init(&pktin_param);
 	pktin_param.queue_param.sched.sync = ODP_SCHED_SYNC_ATOMIC;
+	pktin_param.classifier_enable = true;
+	pktin_param.hash_enable = false;
 
 	if (odp_pktin_queue_config(pktio, &pktin_param)) {
 		fprintf(stderr, "pktin queue config failed.\n");
diff --git a/test/common_plat/validation/api/classification/odp_classification_tests.c b/test/common_plat/validation/api/classification/odp_classification_tests.c
index 4f43082..a0f73e3 100644
--- a/test/common_plat/validation/api/classification/odp_classification_tests.c
+++ b/test/common_plat/validation/api/classification/odp_classification_tests.c
@@ -52,6 +52,8 @@  int classification_suite_init(void)
 
 	odp_pktin_queue_param_init(&pktin_param);
 	pktin_param.queue_param.sched.sync = ODP_SCHED_SYNC_ATOMIC;
+	pktin_param.classifier_enable = true;
+	pktin_param.hash_enable = false;
 
 	if (odp_pktin_queue_config(pktio_loop, &pktin_param)) {
 		fprintf(stderr, "pktin queue config failed.\n");