| Message ID | 1501692241-23310-8-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | v7M: cleanups and bugfixes prior to v8M | expand |
On Wed, Aug 02, 2017 at 05:43:53PM +0100, Peter Maydell wrote: > When we switched our handling of exception exit to detect > the magic addresses at translate time rather than via > a do_unassigned_access hook, we forgot to update a > comment; correct the omission. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index fd83a21..cb88c66 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -6143,7 +6143,7 @@ static void do_v7m_exception_exit(ARMCPU *cpu) > bool rettobase = false; > > /* We can only get here from an EXCP_EXCEPTION_EXIT, and > - * arm_v7m_do_unassigned_access() enforces the architectural rule > + * gen_bx_excret() enforces the architectural rule > * that jumps to magic addresses don't have magic behaviour unless > * we're in Handler mode (compare pseudocode BXWritePC()). > */ > -- > 2.7.4 > >
On 08/02/2017 09:43 AM, Peter Maydell wrote: > When we switched our handling of exception exit to detect > the magic addresses at translate time rather than via > a do_unassigned_access hook, we forgot to update a > comment; correct the omission. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/arm/helper.c b/target/arm/helper.c index fd83a21..cb88c66 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6143,7 +6143,7 @@ static void do_v7m_exception_exit(ARMCPU *cpu) bool rettobase = false; /* We can only get here from an EXCP_EXCEPTION_EXIT, and - * arm_v7m_do_unassigned_access() enforces the architectural rule + * gen_bx_excret() enforces the architectural rule * that jumps to magic addresses don't have magic behaviour unless * we're in Handler mode (compare pseudocode BXWritePC()). */
When we switched our handling of exception exit to detect the magic addresses at translate time rather than via a do_unassigned_access hook, we forgot to update a comment; correct the omission. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4