From patchwork Mon Aug 7 15:53:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 109573 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp2915852obb; Mon, 7 Aug 2017 08:53:59 -0700 (PDT) X-Received: by 10.28.208.78 with SMTP id h75mr934255wmg.119.1502121239270; Mon, 07 Aug 2017 08:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502121239; cv=none; d=google.com; s=arc-20160816; b=hSjMjD4bzXrwhLtQqwd5xPhg/xyBM3wVgeixJi/qPIK7gZMvULdaVoCre9ctnuQ2nO xV2PWw+NpgexQtIl4SyMLpdXKAL9Jja9+qXsePafxDrQiTAxEenhPF8RAqwC3YVD/13H +SJqxTKcK2d/5taCw6od3iFvE+fb6wdPPhVbLaSTmTPv6k6y6ERaWo+c79NYttXBTfg4 qo4ioyWbDtdx0w7Kq9PWpn/t3AGpFMFT3qKKZmEazgTQx55JTmLl5BeprnsRdRoMhJFX XCLKCA23e9Du6UYZ0ZAC0aK/3LOP2VhPTySxfKwxtrREUe9ep+vdNrrRhi7EMjrEgU0n i2jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=Cw1sIy2ZDJL3G2rmlaroixxl4n5oBRTkH0sleofB5N8=; b=b6HgJDd8ufTHYFLIvGKnb8rc285YN5UboJ4lMPWVGAdNkcITMkuB75aXIfhPuvD3BH DKRvmKVga50THJxr2sQs0MU5xtcOCcSEMTlyhFUGdB9Js+lM1Mc4TcA2d3kwVtDy8BFg Ah7lnCiJfBPJhlTDLB49niy0O13+Aydjkbjjl3s77GgxcogaAkZX/zcAlNnr0TQS9e8n rKJySL7jDMHmGRVfZJcpkizGs9Nqlc22slgfUrEQvv5d1rThEOQ9jLoIf7/1Bas8VW7I gamqGIVQJh+KrMm6iLi8Mn8mnO7vuk9uqOcIEwCHuuMC+aXn2ODccYEdvF4/IqfiTjYZ d4lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id f28si1211834wmh.98.2017.08.07.08.53.59; Mon, 07 Aug 2017 08:53:59 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id AB575267487; Mon, 7 Aug 2017 17:53:23 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3A7FD267487; Mon, 7 Aug 2017 17:53:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 925F0267459 for ; Mon, 7 Aug 2017 17:53:19 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dekLC-0006fb-Iu; Mon, 07 Aug 2017 15:53:16 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dekLA-0005Uc-0T; Mon, 07 Aug 2017 16:53:12 +0100 From: Mark Brown To: Fabio Estevam In-Reply-To: <1502075586-23581-1-git-send-email-festevam@gmail.com> Message-Id: Date: Mon, 07 Aug 2017 16:53:12 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [alsa-devel] Applied "ASoC: soc-core: Remove unneeded dentry member from snd_soc_codec" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: soc-core: Remove unneeded dentry member from snd_soc_codec has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 353c64dd19ebc99786c3578ea0444e1b5b1bb172 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Mon, 7 Aug 2017 09:08:52 -0300 Subject: [PATCH] ASoC: soc-core: Remove unneeded dentry member from snd_soc_codec There is no need to have the *debugfs_reg dentry member as part of the snd_soc_codec structure as its only usage is inside soc_init_codec_debugfs(). Use a local dentry variable instead. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown --- include/sound/soc.h | 4 ---- sound/soc/soc-core.c | 9 +++++---- 2 files changed, 5 insertions(+), 8 deletions(-) -- 2.13.3 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/include/sound/soc.h b/include/sound/soc.h index 10b71beb9f13..aad3f14966f1 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -903,10 +903,6 @@ struct snd_soc_codec { /* component */ struct snd_soc_component component; - -#ifdef CONFIG_DEBUG_FS - struct dentry *debugfs_reg; -#endif }; /* codec driver */ diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 921622a01944..558efdfd717d 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -339,11 +339,12 @@ static void soc_cleanup_component_debugfs(struct snd_soc_component *component) static void soc_init_codec_debugfs(struct snd_soc_component *component) { struct snd_soc_codec *codec = snd_soc_component_to_codec(component); + struct dentry *debugfs_reg; - codec->debugfs_reg = debugfs_create_file("codec_reg", 0644, - codec->component.debugfs_root, - codec, &codec_reg_fops); - if (!codec->debugfs_reg) + debugfs_reg = debugfs_create_file("codec_reg", 0644, + codec->component.debugfs_root, + codec, &codec_reg_fops); + if (!debugfs_reg) dev_warn(codec->dev, "ASoC: Failed to create codec register debugfs file\n"); }