From patchwork Tue Aug 8 20:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 109673 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp3413077qge; Tue, 8 Aug 2017 13:01:09 -0700 (PDT) X-Received: by 10.237.58.38 with SMTP id n35mr7502715qte.61.1502222469762; Tue, 08 Aug 2017 13:01:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502222469; cv=none; d=google.com; s=arc-20160816; b=xa5klafZ3X5Rry8S1H80a5zrcDeqhhLLLmDYBER1agMVmAFXy4qTHf1PuOEXmdC1z2 oxhyT4j2HL+SjsyXfXDbe3fKB9XnocP4Ke4V+5UkrK/mTitJN9dRDvPQ4GWDmLRGMI+m juOOPFHOTYBzaN51gRXKBp5W01N8QdBzbI8L40hdNrsuLNvwBzkizGoKnby2vQBjcovR BEFoflmXLMJgisZZT132Z8zJGPdcQhjoxrLfIcMlsCVfY2KsXsiH7hJhKgP+mkGaEn7t C54e7S7aznLxyTEcsd+DmQYo/yHWboiN+rvwiNsJIftxTdAroZHNzmpCg0d47MrHt8dm pGlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=87dwxJnczVZcfOhZVEAS6wUKOGVR0l155/pmKQjmBkM=; b=rEgwwGOr1voGqiR4HWXpQiiEfHdLV1cZBYaEj3urBA5/Usy+0cH/tb5VrH3FxJfaWp B1vmeWsOgJeNsi5MMiU4hPe0tJxMf4Yl8S3NKwXwGc1nnfDQBOqTk2v49YmQVB7c0rI+ guSfWGSAZV/Fv9OBem4tUZ+Y8MZYIHuT0i5upzPZhnue7O2xjBcDOXo/SP14QfCpySEp cOXYbcpNeuYF47S5mSUBbNccfaJ4UsE5MtDToOXyJ/QwDA1EYQs7yzpXZu/n5oJWsK5y PuHaccAQvU0UqcjNRsmPFjcoqE8eOphSsdBF/ZgFF0hsNgQVhIq82kHzK8jPpRISR2Eu RVQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id f4si1648847qtc.303.2017.08.08.13.01.09; Tue, 08 Aug 2017 13:01:09 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 60E2060CEE; Tue, 8 Aug 2017 20:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 7288260BED; Tue, 8 Aug 2017 20:00:34 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3A50360BF5; Tue, 8 Aug 2017 20:00:29 +0000 (UTC) Received: from forward103p.mail.yandex.net (forward103p.mail.yandex.net [77.88.28.106]) by lists.linaro.org (Postfix) with ESMTPS id CAE52608CE for ; Tue, 8 Aug 2017 20:00:27 +0000 (UTC) Received: from mxback4o.mail.yandex.net (mxback4o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1e]) by forward103p.mail.yandex.net (Yandex) with ESMTP id 733862180E45 for ; Tue, 8 Aug 2017 23:00:26 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback4o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id GFhQyR47Es-0Qs0w1U5; Tue, 08 Aug 2017 23:00:26 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 9BRJ8cTE2V-0PqSscTG; Tue, 08 Aug 2017 23:00:25 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 8 Aug 2017 23:00:06 +0300 Message-Id: <1502222409-9574-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1502222409-9574-1-git-send-email-odpbot@yandex.ru> References: <1502222409-9574-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 108 Subject: [lng-odp] [PATCH API-NEXT v3 1/4] linux-gen: classification: mark several functions as static X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 108 (lumag:symbols-cleanup) ** https://github.com/Linaro/odp/pull/108 ** Patch: https://github.com/Linaro/odp/pull/108.patch ** Base sha: e420668cd3886f003c8bd6022e210bf08a0ee3b5 ** Merge commit sha: 4ec4664e462d336f5b34b03ec598531c07ebf235 **/ .../linux-generic/include/odp_classification_internal.h | 7 ------- platform/linux-generic/odp_classification.c | 14 +++++++++----- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/platform/linux-generic/include/odp_classification_internal.h b/platform/linux-generic/include/odp_classification_internal.h index 208b0f5b..8882a717 100644 --- a/platform/linux-generic/include/odp_classification_internal.h +++ b/platform/linux-generic/include/odp_classification_internal.h @@ -49,13 +49,6 @@ This function should be called during pktio initialization. **/ int pktio_classifier_init(pktio_entry_t *pktio); -void _odp_cls_update_hash_proto(cos_t *cos, - odp_pktin_hash_proto_t hash_proto); - -uint32_t packet_rss_hash(odp_packet_hdr_t *pkt_hdr, - odp_cls_hash_proto_t hash_proto, - const uint8_t *base); - #ifdef __cplusplus } #endif diff --git a/platform/linux-generic/odp_classification.c b/platform/linux-generic/odp_classification.c index f9a82a2e..af8b5862 100644 --- a/platform/linux-generic/odp_classification.c +++ b/platform/linux-generic/odp_classification.c @@ -33,7 +33,7 @@ static cos_tbl_t *cos_tbl; static pmr_tbl_t *pmr_tbl; static _cls_queue_grp_tbl_t *queue_grp_tbl; -const rss_key default_rss = { +static const rss_key default_rss = { .u8 = { 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2, 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0, @@ -191,7 +191,7 @@ int odp_cls_capability(odp_cls_capability_t *capability) return 0; } -void _odp_cls_update_hash_proto(cos_t *cos, odp_pktin_hash_proto_t hash_proto) +static void _odp_cls_update_hash_proto(cos_t *cos, odp_pktin_hash_proto_t hash_proto) { if (hash_proto.proto.ipv4 || hash_proto.proto.ipv4_tcp || hash_proto.proto.ipv4_udp) @@ -934,6 +934,10 @@ static inline cos_t *cls_select_cos(pktio_entry_t *entry, return cls->default_cos; } +static uint32_t packet_rss_hash(odp_packet_hdr_t *pkt_hdr, + odp_cls_hash_proto_t hash_proto, + const uint8_t *base); + /** * Classify packet * @@ -989,9 +993,9 @@ int cls_classify_packet(pktio_entry_t *entry, const uint8_t *base, return 0; } -uint32_t packet_rss_hash(odp_packet_hdr_t *pkt_hdr, - odp_cls_hash_proto_t hash_proto, - const uint8_t *base) +static uint32_t packet_rss_hash(odp_packet_hdr_t *pkt_hdr, + odp_cls_hash_proto_t hash_proto, + const uint8_t *base) { thash_tuple_t tuple; const _odp_ipv4hdr_t *ipv4;