[oe,meta-oe,8/9] collectd: Fix build with clang

Message ID	20170808214800.39621-8-raj.khem@gmail.com
State	Accepted
Commit	4febf0dafb3fc7aac007198046cfe0731fc5be5b
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; From: Khem Raj <raj.khem@gmail.com> To: openembedded-devel@lists.openembedded.org Date: Tue, 8 Aug 2017 14:47:59 -0700 Message-Id: <20170808214800.39621-8-raj.khem@gmail.com> In-Reply-To: <20170808214800.39621-1-raj.khem@gmail.com> References: <20170808214800.39621-1-raj.khem@gmail.com> Subject: [oe] [meta-oe][PATCH 8/9] collectd: Fix build with clang Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org
Series	[oe,meta-oe,1/9] php7: upgrade to 7.1.7 \| expand [oe,meta-oe,1/9] php7: upgrade to 7.1.7 [oe,meta-oe,2/9] llvm: Remove [oe,meta-networking,3/9] squid: Add missing dependencies on openssl expat and libxml2 [oe,meta-multimedia,4/9] kodi: Use std namespace for string objects [oe,meta-oe,5/9] mongodb: Upgrade to 3.4.6 [oe,meta-python,6/9] python3-twisted: Fix build with clang [oe,meta-python,7/9] python-grpcio: Do not hardcode compiler -std options [oe,meta-oe,8/9] collectd: Fix build with clang [oe,meta-oe,9/9] fbida: Fix build with libjpeg-turbo

Message ID

20170808214800.39621-8-raj.khem@gmail.com

State

Accepted

Commit

4febf0dafb3fc7aac007198046cfe0731fc5be5b

Headers

Received-SPF: pass (google.com: best guess record for domain of
	openembedded-devel-bounces@lists.openembedded.org designates
	140.211.169.62 as permitted sender) client-ip=140.211.169.62; 
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Date: Tue,  8 Aug 2017 14:47:59 -0700
Message-Id: <20170808214800.39621-8-raj.khem@gmail.com>
In-Reply-To: <20170808214800.39621-1-raj.khem@gmail.com>
References: <20170808214800.39621-1-raj.khem@gmail.com>
Subject: [oe] [meta-oe][PATCH 8/9] collectd: Fix build with clang
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: openembedded-devel-bounces@lists.openembedded.org
Errors-To: openembedded-devel-bounces@lists.openembedded.org

Series

[oe,meta-oe,1/9] php7: upgrade to 7.1.7 | expand

Commit Message

Khem Raj Aug. 8, 2017, 9:47 p.m. UTC

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 ...onfigure-Check-for-Wno-error-format-truncation-comp.patch | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

-- 
2.14.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

diff --git a/meta-oe/recipes-extended/collectd/collectd/0001-configure-Check-for-Wno-error-format-truncation-comp.patch b/meta-oe/recipes-extended/collectd/collectd/0001-configure-Check-for-Wno-error-format-truncation-comp.patch
index 70b0983e4..5069a639c 100644
--- a/meta-oe/recipes-extended/collectd/collectd/0001-configure-Check-for-Wno-error-format-truncation-comp.patch
+++ b/meta-oe/recipes-extended/collectd/collectd/0001-configure-Check-for-Wno-error-format-truncation-comp.patch
@@ -1,14 +1,18 @@ 
-From 14d469bc82c758116aef7d549abd49c131b4170f Mon Sep 17 00:00:00 2001
+From b459c55e4968321e5a82272cb39aa69d4054990f Mon Sep 17 00:00:00 2001
 From: Khem Raj <raj.khem@gmail.com>
 Date: Sat, 22 Apr 2017 11:54:57 -0700
 Subject: [PATCH] configure: Check for -Wno-error=format-truncation compiler
  option
 
 If this option is supported by compiler then disable it ( gcc7+)
+Use -Werror to elevate the warning to an error in case compiler like clang
+which warn about unknown options but not error out unless asked for
+
 Fixes
 client.c:834:23: error: '%s' directive output may be truncated writing up to 1023 bytes into a region of size 1010 [-Werror=format-truncation=]
 
 Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
 ---
  configure.ac                |  3 +-
  m4/ax_check_compile_flag.m4 | 74 +++++++++++++++++++++++++++++++++++++++++++++
@@ -16,7 +20,7 @@  Signed-off-by: Khem Raj <raj.khem@gmail.com>
  create mode 100644 m4/ax_check_compile_flag.m4
 
 diff --git a/configure.ac b/configure.ac
-index 8854542..f3a6b57 100644
+index 8854542..edb8cfb 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -4,7 +4,6 @@ AC_INIT([collectd],[m4_esyscmd(./version-gen.sh)])
@@ -31,7 +35,7 @@  index 8854542..f3a6b57 100644
          AM_CFLAGS="$AM_CFLAGS -Werror"
          AM_CXXFLAGS="$AM_CXXFLAGS -Werror"
  fi
-+AX_CHECK_COMPILE_FLAG([-Werror=format-truncation],[AM_CFLAGS="$AM_CFLAGS -Wno-error=format-truncation" AM_CXXFLAGS="$AM_CXXFLAGS -Wno-error=format-truncation"])
++AX_CHECK_COMPILE_FLAG([-Werror -Werror=format-truncation],[AM_CFLAGS="$AM_CFLAGS -Wno-error=format-truncation" AM_CXXFLAGS="$AM_CXXFLAGS -Wno-error=format-truncation"])
 +
  AC_SUBST([AM_CFLAGS])
  AC_SUBST([AM_CXXFLAGS])
@@ -117,5 +121,5 @@  index 0000000..dcabb92
 +AS_VAR_POPDEF([CACHEVAR])dnl
 +])dnl AX_CHECK_COMPILE_FLAGS
 -- 
-2.12.2
+2.13.4

[oe,meta-oe,8/9] collectd: Fix build with clang

Commit Message

Patch