genirq: fix for_each_action_of_desc() macro

Message ID 1502260341-28184-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 163616cf2f6ab7a8e37452ec00320039ab65bd45
Headers show

Commit Message

Masahiro Yamada Aug. 9, 2017, 6:32 a.m.
struct irq_desc does not have a member named "act".  The correct
name is "action".

Currently, all users of this macro use an iterator named "action".
If a different name is used, it will cause a build error.

Fixes: f944b5a7aff0 ("genirq: Use a common macro to go through the actions list")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 kernel/irq/internals.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Daniel Lezcano Aug. 14, 2017, 10:11 a.m. | #1
On 09/08/2017 08:32, Masahiro Yamada wrote:
> struct irq_desc does not have a member named "act".  The correct

> name is "action".

> 

> Currently, all users of this macro use an iterator named "action".

> If a different name is used, it will cause a build error.

> 

> Fixes: f944b5a7aff0 ("genirq: Use a common macro to go through the actions list")

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>





-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Patch

diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index a2c48058354c..a4aa39009f0d 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -151,7 +151,7 @@  static inline void chip_bus_sync_unlock(struct irq_desc *desc)
 #define IRQ_GET_DESC_CHECK_PERCPU	(_IRQ_DESC_CHECK | _IRQ_DESC_PERCPU)
 
 #define for_each_action_of_desc(desc, act)			\
-	for (act = desc->act; act; act = act->next)
+	for (act = desc->action; act; act = act->next)
 
 struct irq_desc *
 __irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,