From patchwork Wed Aug 9 22:51:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 109755 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp1536213qge; Wed, 9 Aug 2017 15:53:10 -0700 (PDT) X-Received: by 10.99.99.7 with SMTP id x7mr9325184pgb.81.1502319190638; Wed, 09 Aug 2017 15:53:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502319190; cv=none; d=google.com; s=arc-20160816; b=TcGRm1oNFfvS4HxmCZEM56+kqhusWFDUnZkXHD0bRaiNpodevnXrFpvElavaS9Nuc4 eyBANvCshYs1EHNEteR9v+Ztl5sI5Tl15F9bL4teUK+pqWJRd7kJbtJDBfseIcgZZHyi YbIHBOOZCsilgIBHc2F+T7P+ZxULUOb+9atxIZXPe8HiuLyrwDgpKzn/hcO9Dx2m4Zvs QBxGEtYtwX6Bg4rLpD8sqnsVWNS86cLk6xZS6dTTSLiZn5565wTbp5Cp672ANpunsthm Bw5HsrTbAkE3J3AExWn0jpILYCxrxM2d37mMKfxR/5e+AkpNIyZWYCyhIJP183ZEMs+3 fNUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=AMrdGMOfsA3ltiHavKANoUJIe+rOwOuQeYljtv0Hzzk=; b=vqRAo99tNP/7Ig2ni38dOsPVbJfsM+z9pvXTxcL2LiyPaE6Z7kKn5x1Pk+EhFTfaa2 iptzFFChhO65QRJenmB12say4JNHXPvGy0Ui2z/L5c/qyjxaanq5lqqfZYroYIvd3Qac 3HIk5piXXneB71ssA6SJBr+wLtrTrj8rmqX8CY7qhovha0ESDrNNQDEuTuISiXxTFOdf 41uK08N1fbSlOQsckqsDkNTxI3I3F94wMmBdrzL5cVkgYAInbMccKqNgpuwrrFCnYVcy PnqS1MUU8xGD/yWcQKymMLUsIyh2YC2Jq9d+1zHLkYI0KPGvCnGEHzm6i2FyGJLXVp8p LJsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ROxGBYps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si3457388plb.393.2017.08.09.15.53.10; Wed, 09 Aug 2017 15:53:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ROxGBYps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbdHIWxG (ORCPT + 25 others); Wed, 9 Aug 2017 18:53:06 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:25540 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdHIWxE (ORCPT ); Wed, 9 Aug 2017 18:53:04 -0400 Received: from grover.sesame (FL1-122-131-185-176.osk.mesh.ad.jp [122.131.185.176]) (authenticated) by conuserg-07.nifty.com with ESMTP id v79Mpewn016783; Thu, 10 Aug 2017 07:51:41 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v79Mpewn016783 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1502319101; bh=AMrdGMOfsA3ltiHavKANoUJIe+rOwOuQeYljtv0Hzzk=; h=From:To:Cc:Subject:Date:From; b=ROxGBYpsDMqFQwXA+Z2qUnOXCVxZyg5p1DnXK+wkQkS18P0vo/nLA6L7UsYsD9oLF zoe3iGH0gXqFKjyOKVgCNdSQJ2Tntgb+ppIG3DMiSJPILkDA0UzVIeohEp/QaGszVt IGDyAXvyJrDcFHf8zyPH6/7IXFZWUhbm8y8GjMdlSURwdQOP6XK8lwEJouAfGj8hT4 zNfwI/YP5oaanLY3WZ4c+4RobEP4Wz66rr/cxbJXkPjDR3vrNaUGaskOK2bz85HHk0 3+aPf2uagMqg8WiXLFCPJkOp9QnvVdkSYDJMF25LA1ZPWhlZJMV6lJSML/X0SbBYNp POAeU+1QPPOiw== X-Nifty-SrcIP: [122.131.185.176] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: Masahiro Yamada , Linus Walleij , linux-kernel@vger.kernel.org, Brian Norris , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Gregory Fong , linux-arm-kernel@lists.infradead.org Subject: [PATCH] gpio: brcmstb: check return value of gpiochip_irqchip_add() Date: Thu, 10 Aug 2017 07:51:27 +0900 Message-Id: <1502319087-23396-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because gpiochip_irqchip_add() may fail, its return value should be checked. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-brcmstb.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.7.4 Acked-by: Gregory Fong diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index e6489143721a..51485997f680 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -339,6 +339,7 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, struct brcmstb_gpio_priv *priv = bank->parent_priv; struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; + int err; bank->irq_chip.name = dev_name(dev); bank->irq_chip.irq_mask = brcmstb_gpio_irq_mask; @@ -355,8 +356,6 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, dev_warn(dev, "Couldn't get wake IRQ - GPIOs will not be able to wake from sleep"); } else { - int err; - /* * Set wakeup capability before requesting wakeup * interrupt, so we can process boot-time "wakeups" @@ -383,8 +382,10 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, if (priv->can_wake) bank->irq_chip.irq_set_wake = brcmstb_gpio_irq_set_wake; - gpiochip_irqchip_add(&bank->gc, &bank->irq_chip, 0, - handle_simple_irq, IRQ_TYPE_NONE); + err = gpiochip_irqchip_add(&bank->gc, &bank->irq_chip, 0, + handle_simple_irq, IRQ_TYPE_NONE); + if (err) + return err; gpiochip_set_chained_irqchip(&bank->gc, &bank->irq_chip, priv->parent_irq, brcmstb_gpio_irq_handler);