[3/3] reset: uniphier: add analog amplifiers reset control

Message ID 20170810072703.32433-3-suzuki.katsuhiro@socionext.com
State New
Headers show
Series
  • [1/3] reset: uniphier: add audio systems reset control
Related show

Commit Message

Katsuhiro Suzuki Aug. 10, 2017, 7:27 a.m.
Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.

Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

---
 drivers/reset/reset-uniphier.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

-- 
2.13.2

Comments

Philipp Zabel Aug. 10, 2017, 10:37 a.m. | #1
Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on

> UniPhier LD11/LD20 SoCs.

> 

> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

> ---

>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++

>  1 file changed, 15 insertions(+)

> 

> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c

> index f60c137c17cb..cda4a78a58e2 100644

> --- a/drivers/reset/reset-uniphier.c

> +++ b/drivers/reset/reset-uniphier.c

> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {

> >  	UNIPHIER_RESET_END,

>  };

>  

> +/* Analog signal amplifiers reset data */

> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

> > +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */

> > +	UNIPHIER_RESET_END,

> +};

> +

>  /* core implementaton */

>  struct uniphier_reset_priv {

> >  	struct reset_controller_dev rcdev;

> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {

> >  		.compatible = "socionext,uniphier-ld20-peri-reset",

> >  		.data = uniphier_pro4_peri_reset_data,

> >  	},

> > +	/* Analog signal amplifiers reset */

> > +	{

> > +		.compatible = "socionext,uniphier-ld11-adamv-reset",

> > +		.data = uniphier_ld11_adamv_reset_data,

> > +	},

> > +	{

> > +		.compatible = "socionext,uniphier-ld20-adamv-reset",

> > +		.data = uniphier_ld11_adamv_reset_data,

> > +	},

> >  	{ /* sentinel */ }

>  };

>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);


Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp
Masahiro Yamada Aug. 10, 2017, 11:11 a.m. | #2
2017-08-10 19:37 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Hi Katsuhiro,

>

> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

>> Add a reset line for analog signal amplifier core (ADAMV) on

>> UniPhier LD11/LD20 SoCs.

>>

>> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

>> ---

>>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++

>>  1 file changed, 15 insertions(+)

>>

>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c

>> index f60c137c17cb..cda4a78a58e2 100644

>> --- a/drivers/reset/reset-uniphier.c

>> +++ b/drivers/reset/reset-uniphier.c

>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {

>> >     UNIPHIER_RESET_END,

>>  };

>>

>> +/* Analog signal amplifiers reset data */

>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */

>> > +   UNIPHIER_RESET_END,

>> +};

>> +

>>  /* core implementaton */

>>  struct uniphier_reset_priv {

>> >     struct reset_controller_dev rcdev;

>> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {

>> >             .compatible = "socionext,uniphier-ld20-peri-reset",

>> >             .data = uniphier_pro4_peri_reset_data,

>> >     },

>> > +   /* Analog signal amplifiers reset */

>> > +   {

>> > +           .compatible = "socionext,uniphier-ld11-adamv-reset",

>> > +           .data = uniphier_ld11_adamv_reset_data,

>> > +   },

>> > +   {

>> > +           .compatible = "socionext,uniphier-ld20-adamv-reset",

>> > +           .data = uniphier_ld11_adamv_reset_data,

>> > +   },

>> >     { /* sentinel */ }

>>  };

>>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

>

> Please add a patch to describe the new compatible values in

> Documentation/devicetree/bindings/reset/uniphier-reset.txt.

>


The code change is OK with me.

Assuming you will update the binding,

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>






-- 
Best Regards
Masahiro Yamada
Masahiro Yamada Aug. 10, 2017, 11:23 a.m. | #3
Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> 2017-08-10 19:37 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:

>> Hi Katsuhiro,

>>

>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

>>> Add a reset line for analog signal amplifier core (ADAMV) on

>>> UniPhier LD11/LD20 SoCs.

>>>

>>> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

>>> ---

>>>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++

>>>  1 file changed, 15 insertions(+)

>>>

>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c

>>> index f60c137c17cb..cda4a78a58e2 100644

>>> --- a/drivers/reset/reset-uniphier.c

>>> +++ b/drivers/reset/reset-uniphier.c

>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {

>>> >     UNIPHIER_RESET_END,

>>>  };

>>>

>>> +/* Analog signal amplifiers reset data */

>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

>>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */

>>> > +   UNIPHIER_RESET_END,

>>> +};



I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?





-- 
Best Regards
Masahiro Yamada
Katsuhiro Suzuki Aug. 11, 2017, 4:14 a.m. | #4
Hi Philipp,

On 2017年08月10日 19:37, Philipp Zabel wrote:
> Hi Katsuhiro,

> 

> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

>> Add a reset line for analog signal amplifier core (ADAMV) on

>> UniPhier LD11/LD20 SoCs.

>>

>>> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

>> ---

>>   drivers/reset/reset-uniphier.c | 15 +++++++++++++++

>>   1 file changed, 15 insertions(+)

>>

>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c

>> index f60c137c17cb..cda4a78a58e2 100644

>> --- a/drivers/reset/reset-uniphier.c

>> +++ b/drivers/reset/reset-uniphier.c

>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {

>>>   	UNIPHIER_RESET_END,

>>   };

>>   

>> +/* Analog signal amplifiers reset data */

>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

>>> +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */

>>> +	UNIPHIER_RESET_END,

>> +};

>> +

>>   /* core implementaton */

>>   struct uniphier_reset_priv {

>>>   	struct reset_controller_dev rcdev;

>> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {

>>>   		.compatible = "socionext,uniphier-ld20-peri-reset",

>>>   		.data = uniphier_pro4_peri_reset_data,

>>>   	},

>>> +	/* Analog signal amplifiers reset */

>>> +	{

>>> +		.compatible = "socionext,uniphier-ld11-adamv-reset",

>>> +		.data = uniphier_ld11_adamv_reset_data,

>>> +	},

>>> +	{

>>> +		.compatible = "socionext,uniphier-ld20-adamv-reset",

>>> +		.data = uniphier_ld11_adamv_reset_data,

>>> +	},

>>>   	{ /* sentinel */ }

>>   };

>>   MODULE_DEVICE_TABLE(of, uniphier_reset_match);

> 

> Please add a patch to describe the new compatible values in

> Documentation/devicetree/bindings/reset/uniphier-reset.txt.

> 


Thank you, I will add it and send V2 series.


Regards,
--
Katsuhiro Suzuki
Katsuhiro Suzuki Aug. 11, 2017, 4:23 a.m. | #5
Hi Yamada-san,

On 2017年08月10日 20:23, Masahiro Yamada wrote:
> Hi.

> 

> 

> 2017-08-10 20:11 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:

>> 2017-08-10 19:37 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:

>>> Hi Katsuhiro,

>>>

>>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

>>>> Add a reset line for analog signal amplifier core (ADAMV) on

>>>> UniPhier LD11/LD20 SoCs.

>>>>

>>>>> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>

>>>> ---

>>>>   drivers/reset/reset-uniphier.c | 15 +++++++++++++++

>>>>   1 file changed, 15 insertions(+)

>>>>

>>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c

>>>> index f60c137c17cb..cda4a78a58e2 100644

>>>> --- a/drivers/reset/reset-uniphier.c

>>>> +++ b/drivers/reset/reset-uniphier.c

>>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {

>>>>>      UNIPHIER_RESET_END,

>>>>   };

>>>>

>>>> +/* Analog signal amplifiers reset data */

>>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

>>>>> +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */

>>>>> +   UNIPHIER_RESET_END,

>>>> +};

> 

> 

> I take back my Acked-by.

> 

> 

> The reset line index is independent from others

> because this block is a separate instance.

> 

> Are you OK with starting from the reset ID 100?


It's my mistake. This ID can start with 0.
I will fix in next V2 series, thank you.

Regards,
--
Katsuhiro Suzuki

Patch hide | download patch | download mbox

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@  static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
+/* Analog signal amplifiers reset data */
+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
+	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+	UNIPHIER_RESET_END,
+};
+
 /* core implementaton */
 struct uniphier_reset_priv {
 	struct reset_controller_dev rcdev;
@@ -415,6 +421,15 @@  static const struct of_device_id uniphier_reset_match[] = {
 		.compatible = "socionext,uniphier-ld20-peri-reset",
 		.data = uniphier_pro4_peri_reset_data,
 	},
+	/* Analog signal amplifiers reset */
+	{
+		.compatible = "socionext,uniphier-ld11-adamv-reset",
+		.data = uniphier_ld11_adamv_reset_data,
+	},
+	{
+		.compatible = "socionext,uniphier-ld20-adamv-reset",
+		.data = uniphier_ld11_adamv_reset_data,
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, uniphier_reset_match);