From patchwork Thu Aug 10 12:14:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 109802 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp2280654obb; Thu, 10 Aug 2017 05:16:26 -0700 (PDT) X-Received: by 10.84.178.37 with SMTP id y34mr13162929plb.125.1502367386196; Thu, 10 Aug 2017 05:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502367386; cv=none; d=google.com; s=arc-20160816; b=0GOsOF84tO/ZZEyBEWcyW65GH3Sj83YhBESJdeIk0sP4/sCqzVFDSgIXTn7RBPiiyW +tuwsoWQwsPhdOvSdNSaqtpzI27vouvd1wKdwhnpaeY/gOqXFwAvk418ULaUwZhvy5uo b8OdqaMfttRiQfzY35JJaTCA6T22elymaWJjdgk1GsyinXWy0twUIWSloG+hyqacc4pl rZ+m5IVvtwUhfUqKRHtEKzghAq+um/apSvcohav2Roa6cqj07SBnxeu+VdSIqliho04Z JpIOsUZUIs1aAMRAJsZDpM75sngi1uoH59OZYU4TOdwXzhbOz6xqn9Hq882KqYuVE4lM dqYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=lXAAtaoS2DLzO4u6q3a2Dz2KiyHPib+vXOqZNqGlco4=; b=PHzTKw09JmQUaFsPNqR4NrLkAWIqW8VVCkN6gkRE7ukXxeAumeUXKaFwvNoffUTCJI ZdQjV03hPEeExkTJP+oN69Mg7xHIMreJUkmbd84QcGh3ShLpmoTDVOx3Y2Uhus/g/7I6 10HrDR/0s4CM0+0lHK78pA6aJlY8g5Y453rk4rclJgTvO6UZ8O/VLNoItpzwmkCxb9Cx xZ2SIyQqkx2UfmoXSjS2qjeQN3EYXLAQ8MTZREVsmKtqBmE6Xpx8WmCo0WnZzauEM/Z0 NKH6iU/xUJ3Wo4nb3Wuwjbw/8DjalyK/LVlmi68so6282yU3jFzaqH3CNGPq3Wbu8K28 7llQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si3865847pgr.251.2017.08.10.05.16.25; Thu, 10 Aug 2017 05:16:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbdHJMQX (ORCPT + 25 others); Thu, 10 Aug 2017 08:16:23 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53214 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbdHJMQT (ORCPT ); Thu, 10 Aug 2017 08:16:19 -0400 Received: from wuerfel.lan ([95.208.155.18]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0Ldqqt-1dGNQW1tBb-00izHr; Thu, 10 Aug 2017 14:14:51 +0200 From: Arnd Bergmann To: Paolo Bonzini , =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= Cc: Arnd Bergmann , Christian Borntraeger , Michal Hocko , David Hildenbrand , Lorenzo Stoakes , Suraj Jitindar Singh , Ingo Molnar , Claudio Imbrenda , Luiz Capitulino , Markus Elfring , "Cao, Lei" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kvm: avoid uninitialized-variable warnings Date: Thu, 10 Aug 2017 14:14:39 +0200 Message-Id: <20170810121449.2610298-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:8v9otAKeJ/jEY2RuAzJ3tIWGkxlwLYP6tBBYG5WR4L7lWHFV0Nv NtYNi1pJv8/a0I1GpIDidcTJCPiCw2BYzr3vX+nhC12zsLr7aFncMaLdmEPdg/bEX9SXxMU 6Hz/pC9+UWPI3KPlJURMRhIpUDoy8C2dePTJwDdleXnicTI7HVsHP20YH4SPh5tXnqxm+8h iXXADPXDBlV+fZ1xEaYZg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Pobpu3+fY1k=:qgHkG98k8gUmo9dewlX7Sq LR2sLHzp+NWvkHuUkhORk74u+PIOP/4t3MdT+YpAidG/IftVMWdoAiicodjZLYYIs2w4GeXI4 4p0CtBL4MENTBvKGf2XAnAJMId7rkx+xec8Bn0O07VX16RrAQwL8PK0XaNktTpkLepke5VeHe eCoAJrsqLGOIXaXDhexf3H35ZTXB7jDXiCe9GIhP2LIi8VzBYvci4GlAIbelf30EYqkZgklEc dOrguxJlVC8UZOGGARoAtWaFAMSDn1Gn0eWCnmnVuIaXCeZ5K+r8Fn1Syo+L8Ao6AO0sFg9hr OqX0+rB+fwX7l/oifnrENiisQSwXhA9esFwU4oK/nbAGy9UBLi/4dGUpbL++z3cLGZtVLVyAj tr+MgyF2Sy1cx9/axSxNo8bOQlBEdtDA+gneCHdv6MaZacnkZxjT0RwKO06ZubhsuxdJqHImI 1IQuoAyl+CNfhxCTAGTkqe4sdpDFqrCthtzADHojPRFJ9uenslx0O8hy6hCRP+BkPFHKoZxAG DsH3ZXlgxpYVHFRzRsVFgTlkE7PnRPt3Q5Q/NLFnOHoheDGbwotO4M6BrBcfaqCfCnpbbQW1D dtf11eRhYDKm4+dau1vgw2szHJ8kLdE0sRvKj2f8S5GzcAS5svVlIaptEujzmiVAM3D7Z7n8Z Yiiy4LgqTthNOWmaCnsPe4fUbUeMQxHBeWaKUct3QYvnQVSKOK3dokRPPpPpfpZdzatbVUjub +vADJuKQP3+tUX1r8B0QVz+ScVecsmkryD7/lA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When PAGE_OFFSET is not a compile-time constant, we run into warnings from the use of kvm_is_error_hva() that the compiler cannot optimize out: arch/arm/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_gfn_to_hva_cache_init': arch/arm/kvm/../../../virt/kvm/kvm_main.c:1978:14: error: 'nr_pages_avail' may be used uninitialized in this function [-Werror=maybe-uninitialized] arch/arm/kvm/../../../virt/kvm/kvm_main.c: In function 'gfn_to_page_many_atomic': arch/arm/kvm/../../../virt/kvm/kvm_main.c:1660:5: error: 'entry' may be used uninitialized in this function [-Werror=maybe-uninitialized] This adds fake initializations to the two instances I ran into. Signed-off-by: Arnd Bergmann --- virt/kvm/kvm_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 15252d723b54..c812b40dc8de 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1651,7 +1651,7 @@ int gfn_to_page_many_atomic(struct kvm_memory_slot *slot, gfn_t gfn, struct page **pages, int nr_pages) { unsigned long addr; - gfn_t entry; + gfn_t entry = 0; addr = gfn_to_hva_many(slot, gfn, &entry); if (kvm_is_error_hva(addr)) @@ -1970,6 +1970,7 @@ static int __kvm_gfn_to_hva_cache_init(struct kvm_memslots *slots, * verify that the entire region is valid here. */ while (start_gfn <= end_gfn) { + nr_pages_avail = 0; ghc->memslot = __gfn_to_memslot(slots, start_gfn); ghc->hva = gfn_to_hva_many(ghc->memslot, start_gfn, &nr_pages_avail);