| Message ID | 1346143301-1631-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 08/28/2012 05:41 PM, Sachin Kamat wrote: > Fixes the following warning: > drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: > symbol 'g2d_pm_ops' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 6adfa4e..1065e90 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev) > } > #endif > > -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); > +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); Right, it should be static but i don't get any warning message without static. Thanks. > > struct platform_driver g2d_driver = { > .probe = g2d_probe,
On 29 August 2012 12:32, Joonyoung Shim <jy0922.shim@samsung.com> wrote: > On 08/28/2012 05:41 PM, Sachin Kamat wrote: >> >> Fixes the following warning: >> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: >> symbol 'g2d_pm_ops' was not declared. Should it be static? >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c >> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c >> index 6adfa4e..1065e90 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c >> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev) >> } >> #endif >> -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); >> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); > > > Right, it should be static but i don't get any warning message without > static. You will get it if you enable sparse checking while building the kernel. > > Thanks. > > >> struct platform_driver g2d_driver = { >> .probe = g2d_probe, > >
Applied. Thanks. 2012/8/29 Sachin Kamat <sachin.kamat@linaro.org>: > On 29 August 2012 12:32, Joonyoung Shim <jy0922.shim@samsung.com> wrote: >> On 08/28/2012 05:41 PM, Sachin Kamat wrote: >>> >>> Fixes the following warning: >>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: >>> symbol 'g2d_pm_ops' was not declared. Should it be static? >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>> --- >>> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c >>> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c >>> index 6adfa4e..1065e90 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c >>> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev) >>> } >>> #endif >>> -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); >>> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); >> >> >> Right, it should be static but i don't get any warning message without >> static. > > You will get it if you enable sparse checking while building the kernel. > >> >> Thanks. >> >> >>> struct platform_driver g2d_driver = { >>> .probe = g2d_probe, >> >> > > > > -- > With warm regards, > Sachin > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 6adfa4e..1065e90 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev) } #endif -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); struct platform_driver g2d_driver = { .probe = g2d_probe,
Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: symbol 'g2d_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)