| Message ID | 1502727520-5635-1-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | 7467c9d9598993d8531b2f76c090a5743000612b |
| Headers | show |
Hi Rob, On 14/08/17 17:18, Sudeep Holla wrote: > Instead of the callsites choosing between of_cpu_device_node_get if the > CPUs are registered as of_node is populated by then and of_get_cpu_node > when the CPUs are not yet registered as CPU of_nodes are not yet stashed > thereby needing to parse the device tree, we can call of_get_cpu_node > in case the CPUs are not yet registered in of_cpu_device_node_get. > > This will allow to use of_cpu_device_node_get anywhere hiding the > details from the caller. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Frank Rowand <frowand.list@gmail.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > include/linux/of_device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Rob, > > You have already acked this patch, but I wanted you to pick up this via > your tree and hence I am resending it. I tried pinging on that thread > but I can understand that it's lost in your mailbox :) > Gentle ping! -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/of_device.h b/include/linux/of_device.h index b4ad8b4f8506..611502524425 100644 --- a/include/linux/of_device.h +++ b/include/linux/of_device.h @@ -50,7 +50,7 @@ static inline struct device_node *of_cpu_device_node_get(int cpu) struct device *cpu_dev; cpu_dev = get_cpu_device(cpu); if (!cpu_dev) - return NULL; + return of_get_cpu_node(cpu, NULL); return of_node_get(cpu_dev->of_node); }
Instead of the callsites choosing between of_cpu_device_node_get if the CPUs are registered as of_node is populated by then and of_get_cpu_node when the CPUs are not yet registered as CPU of_nodes are not yet stashed thereby needing to parse the device tree, we can call of_get_cpu_node in case the CPUs are not yet registered in of_cpu_device_node_get. This will allow to use of_cpu_device_node_get anywhere hiding the details from the caller. Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- include/linux/of_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Hi Rob, You have already acked this patch, but I wanted you to pick up this via your tree and hence I am resending it. I tried pinging on that thread but I can understand that it's lost in your mailbox :) Regards, Sudeep -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html