| Message ID | 1502807418-9994-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 72b384f4a7d1d120a2591fc2019cec6ae50d7998 |
| Headers | show |
On 15.08.2017 16:30, Peter Maydell wrote: > The mmio-interface device is not something we want to allow > users to create on the command line: > * it is intended as an implementation detail of the memory > subsystem, which gets created and deleted by that > subsystem on demand; it makes no sense to create it > by hand on the command line > * it uses a pointer property 'host_ptr' which can't be > set on the command line > > Mark the device as not user_creatable to avoid confusion. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/misc/mmio_interface.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c > index da154e5..894e980 100644 > --- a/hw/misc/mmio_interface.c > +++ b/hw/misc/mmio_interface.c > @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) > dc->realize = mmio_interface_realize; > dc->unrealize = mmio_interface_unrealize; > dc->props = mmio_interface_properties; > + /* Reason: pointer property "host_ptr", and this device > + * is an implementation detail of the memory subsystem, > + * not intended to be created directly by the user. > + */ > + dc->user_creatable = false; > } > > static const TypeInfo mmio_interface_info = { > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 15 August 2017 at 17:16, Thomas Huth <thuth@redhat.com> wrote: > On 15.08.2017 16:30, Peter Maydell wrote: >> The mmio-interface device is not something we want to allow >> users to create on the command line: >> * it is intended as an implementation detail of the memory >> subsystem, which gets created and deleted by that >> subsystem on demand; it makes no sense to create it >> by hand on the command line >> * it uses a pointer property 'host_ptr' which can't be >> set on the command line >> >> Mark the device as not user_creatable to avoid confusion. >> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> >> --- >> hw/misc/mmio_interface.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c >> index da154e5..894e980 100644 >> --- a/hw/misc/mmio_interface.c >> +++ b/hw/misc/mmio_interface.c >> @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) >> dc->realize = mmio_interface_realize; >> dc->unrealize = mmio_interface_unrealize; >> dc->props = mmio_interface_properties; >> + /* Reason: pointer property "host_ptr", and this device >> + * is an implementation detail of the memory subsystem, >> + * not intended to be created directly by the user. >> + */ >> + dc->user_creatable = false; >> } >> >> static const TypeInfo mmio_interface_info = { >> > > Reviewed-by: Thomas Huth <thuth@redhat.com> Applied to master, thanks. -- PMM
On Tue, Aug 15, 2017 at 06:16:22PM +0200, Thomas Huth wrote: > On 15.08.2017 16:30, Peter Maydell wrote: > > The mmio-interface device is not something we want to allow > > users to create on the command line: > > * it is intended as an implementation detail of the memory > > subsystem, which gets created and deleted by that > > subsystem on demand; it makes no sense to create it > > by hand on the command line > > * it uses a pointer property 'host_ptr' which can't be > > set on the command line > > > > Mark the device as not user_creatable to avoid confusion. > > > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > > --- > > hw/misc/mmio_interface.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c > > index da154e5..894e980 100644 > > --- a/hw/misc/mmio_interface.c > > +++ b/hw/misc/mmio_interface.c > > @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) > > dc->realize = mmio_interface_realize; > > dc->unrealize = mmio_interface_unrealize; > > dc->props = mmio_interface_properties; > > + /* Reason: pointer property "host_ptr", and this device > > + * is an implementation detail of the memory subsystem, > > + * not intended to be created directly by the user. > > + */ > > + dc->user_creatable = false; > > } > > > > static const TypeInfo mmio_interface_info = { > > > > Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c index da154e5..894e980 100644 --- a/hw/misc/mmio_interface.c +++ b/hw/misc/mmio_interface.c @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) dc->realize = mmio_interface_realize; dc->unrealize = mmio_interface_unrealize; dc->props = mmio_interface_properties; + /* Reason: pointer property "host_ptr", and this device + * is an implementation detail of the memory subsystem, + * not intended to be created directly by the user. + */ + dc->user_creatable = false; } static const TypeInfo mmio_interface_info = {
The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line * it uses a pointer property 'host_ptr' which can't be set on the command line Mark the device as not user_creatable to avoid confusion. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/misc/mmio_interface.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.4