diff mbox series

[02/14] efi/libstub: arm64: use hidden attribute for struct screen_info reference

Message ID 20170818194947.19347-3-ard.biesheuvel@linaro.org
State Accepted
Commit 760b61d76da6d6a99eb245ab61abf71ca5415cea
Headers show
Series EFI changes for v4.14 | expand

Commit Message

Ard Biesheuvel Aug. 18, 2017, 7:49 p.m. UTC 
To prevent the compiler from emitting absolute references to screen_info
when building position independent code, redeclare the symbol with hidden
visibility.

Cc: Matt Fleming <matt@codeblueprint.co.uk>
Tested-by: Matthias Kaehlcke <mka@chromium.org>

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 arch/arm64/include/asm/efi.h | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.11.0
diff mbox series

Patch

diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h
index 8f3043aba873..464ac850c5e2 100644
--- a/arch/arm64/include/asm/efi.h
+++ b/arch/arm64/include/asm/efi.h
@@ -81,6 +81,9 @@  static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base,
 #define alloc_screen_info(x...)		&screen_info
 #define free_screen_info(x...)
 
+/* redeclare as 'hidden' so the compiler will generate relative references */
+extern struct screen_info screen_info __attribute__((__visibility__("hidden")));
+
 static inline void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
 {
 }