From patchwork Tue Aug 22 10:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 110646 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp5107108obb; Tue, 22 Aug 2017 03:22:15 -0700 (PDT) X-Received: by 10.237.32.173 with SMTP id 42mr176085qtb.47.1503397335734; Tue, 22 Aug 2017 03:22:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503397335; cv=none; d=google.com; s=arc-20160816; b=M2IfqE2xhvAhG4rxKNitHZrGTlPpl/2Q2LsR3X366DRPCp9RWBZKcRz0Ie1Oefxezh JxIap2WTYUaUc3QNPxMuE9nUlVzLadPmGivy5Dq7pM3G6klpeCWZ9CuHaqRpX208AgbT EagmtaD2WwKcWoCCyoEbPbXWscXbnjeF9hGo12dIR1lY+LXOuknCt6iKHk1/wY/dF/ux +TB64gaORJaR65cNPyGwlHmX6u+4fFWNvhuqzklfhFKZyt6IvJ96iMl+N8MIg+au7NDI c6fI+d/4WmWxYdGXISqtbj2CV88MM4gwutXz5hepgD1VfqAigfrxhrlgypyvOr3DWBgk 8OOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=kaX+L/zOv7nN1AR43V/HNxg+r9riZVy4sgK7caGmQHg=; b=Fh440I25wZWJU6IbkKlBY2r+RTFukl0GXoClmlkfsnhv11hsc07oP/CYwSaGLGoVT5 IxRy9m4Zwwa/x99gki8mRP4SmPIUluolzQKVJlMeXSx7pLHBrJ7A8XTwGPcaV5e0RAio hoUNyuPjrgLhuqC1sXfu9Sljmk+NQdIfIeU8Mt2qdNX7GABj9Mn1bpdu3rSN5TUeZJc2 JFZWQ3sdezc9bseHDCah+OUooGd1GsvfKVovZVVA6IV5CuM55GNca3KB3hN454THGxMe 6e05bNYiGrp/F7aXECTSIbDMjIfRG/w8sOvPfBtHoh2qOkJR1Cx2Xxs6YB1bhMuVcnFC lstQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id n1si13382797qkf.231.2017.08.22.03.22.15; Tue, 22 Aug 2017 03:22:15 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 5D96E60DBD; Tue, 22 Aug 2017 10:22:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4EDA565C2E; Tue, 22 Aug 2017 10:03:08 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C31C864473; Tue, 22 Aug 2017 10:02:49 +0000 (UTC) Received: from forward101j.mail.yandex.net (forward101j.mail.yandex.net [5.45.198.241]) by lists.linaro.org (Postfix) with ESMTPS id 4627164473 for ; Tue, 22 Aug 2017 10:00:31 +0000 (UTC) Received: from mxback2o.mail.yandex.net (mxback2o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1c]) by forward101j.mail.yandex.net (Yandex) with ESMTP id B0C9C12435D1 for ; Tue, 22 Aug 2017 13:00:29 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback2o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id oGYeOdJRAt-0TS450nV; Tue, 22 Aug 2017 13:00:29 +0300 Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Rlal5nTP8B-0TfWeFbi; Tue, 22 Aug 2017 13:00:29 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 22 Aug 2017 13:00:05 +0300 Message-Id: <1503396009-8350-22-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1503396009-8350-1-git-send-email-odpbot@yandex.ru> References: <1503396009-8350-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 127 Subject: [lng-odp] [PATCH v5 21/25] configure: pass all compiler options through acceptance check X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 127 (lumag:improve-build) ** https://github.com/Linaro/odp/pull/127 ** Patch: https://github.com/Linaro/odp/pull/127.patch ** Base sha: aecb3c7a442b426761f1e6f43308a1e9ea709ef3 ** Merge commit sha: 86e036501e05c61e5570d0908af382a61c2d4e89 **/ configure.ac | 38 ++++++++++++++++++++++++-------------- m4/ax_check_compile_flag.m4 | 12 +++++++----- 2 files changed, 31 insertions(+), 19 deletions(-) diff --git a/configure.ac b/configure.ac index ac36ee89..5e5e8639 100644 --- a/configure.ac +++ b/configure.ac @@ -308,23 +308,33 @@ AC_SUBST(ODP_DEPRECATED_API) ########################################################################## # Default warning setup ########################################################################## -ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" -ODP_CFLAGS="$ODP_CFLAGS -Wmissing-declarations -Wold-style-definition -Wpointer-arith" -ODP_CFLAGS="$ODP_CFLAGS -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral" -ODP_CFLAGS="$ODP_CFLAGS -Wformat-security -Wundef -Wwrite-strings" -ODP_CFLAGS="$ODP_CFLAGS -std=c99" +ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror" dnl Use -Werror in the checks below since Clang emits a warning instead of dnl an error when it encounters an unknown warning option. -AX_CHECK_COMPILE_FLAG([-Wimplicit-fallthrough=0], - [ODP_CFLAGS="$ODP_CFLAGS -Wimplicit-fallthrough=0"], - [], [-Werror]) -AX_CHECK_COMPILE_FLAG([-Wformat-truncation=0], - [ODP_CFLAGS="$ODP_CFLAGS -Wformat-truncation=0"], - [], [-Werror]) -AX_CHECK_COMPILE_FLAG([-Wformat-overflow=0], - [ODP_CFLAGS="$ODP_CFLAGS -Wformat-overflow=0"], - [], [-Werror]) +AC_DEFUN([ODP_CHECK_CFLAG], + [AX_CHECK_COMPILE_FLAG([$1], + [ODP_CFLAGS="$ODP_CFLAGS $1"], + [], [-W -Wall -Werror], + [AC_LANG_SOURCE([int main(void) + {return 0;}])])]) +ODP_CHECK_CFLAG([-Wstrict-prototypes]) +ODP_CHECK_CFLAG([-Wmissing-prototypes]) +ODP_CHECK_CFLAG([-Wmissing-declarations]) +ODP_CHECK_CFLAG([-Wold-style-definition]) +ODP_CHECK_CFLAG([-Wpointer-arith]) +ODP_CHECK_CFLAG([-Wcast-align]) +ODP_CHECK_CFLAG([-Wnested-externs]) +ODP_CHECK_CFLAG([-Wcast-qual]) +ODP_CHECK_CFLAG([-Wformat-nonliteral]) +ODP_CHECK_CFLAG([-Wformat-security]) +ODP_CHECK_CFLAG([-Wundef]) +ODP_CHECK_CFLAG([-Wwrite-strings]) +ODP_CHECK_CFLAG([-Wimplicit-fallthrough=0]) +ODP_CHECK_CFLAG([-Wformat-truncation=0]) +ODP_CHECK_CFLAG([-Wformat-overflow=0]) + +ODP_CFLAGS="$ODP_CFLAGS -std=c99" # Extra flags for example to suppress certain warning types ODP_CFLAGS="$ODP_CFLAGS $ODP_CFLAGS_EXTRA" diff --git a/m4/ax_check_compile_flag.m4 b/m4/ax_check_compile_flag.m4 index c3a8d695..ca363971 100644 --- a/m4/ax_check_compile_flag.m4 +++ b/m4/ax_check_compile_flag.m4 @@ -4,7 +4,7 @@ # # SYNOPSIS # -# AX_CHECK_COMPILE_FLAG(FLAG, [ACTION-SUCCESS], [ACTION-FAILURE], [EXTRA-FLAGS]) +# AX_CHECK_COMPILE_FLAG(FLAG, [ACTION-SUCCESS], [ACTION-FAILURE], [EXTRA-FLAGS], [INPUT]) # # DESCRIPTION # @@ -19,6 +19,8 @@ # the flags: "CFLAGS EXTRA-FLAGS FLAG". This can for example be used to # force the compiler to issue an error when a bad flag is given. # +# INPUT gives an alternative input source to AC_COMPILE_IFELSE. +# # NOTE: Implementation based on AX_CFLAGS_GCC_OPTION. Please keep this # macro in sync with AX_CHECK_{PREPROC,LINK}_FLAG. # @@ -53,19 +55,19 @@ # modified version of the Autoconf Macro, you may extend this special # exception to the GPL to apply to your modified version as well. -#serial 2 +#serial 4 AC_DEFUN([AX_CHECK_COMPILE_FLAG], -[AC_PREREQ(2.59)dnl for _AC_LANG_PREFIX +[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF AS_VAR_PUSHDEF([CACHEVAR],[ax_cv_check_[]_AC_LANG_ABBREV[]flags_$4_$1])dnl AC_CACHE_CHECK([whether _AC_LANG compiler accepts $1], CACHEVAR, [ ax_check_save_flags=$[]_AC_LANG_PREFIX[]FLAGS _AC_LANG_PREFIX[]FLAGS="$[]_AC_LANG_PREFIX[]FLAGS $4 $1" - AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], + AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM()])], [AS_VAR_SET(CACHEVAR,[yes])], [AS_VAR_SET(CACHEVAR,[no])]) _AC_LANG_PREFIX[]FLAGS=$ax_check_save_flags]) -AS_IF([test x"AS_VAR_GET(CACHEVAR)" = xyes], +AS_VAR_IF(CACHEVAR,yes, [m4_default([$2], :)], [m4_default([$3], :)]) AS_VAR_POPDEF([CACHEVAR])dnl