From patchwork Wed Aug 23 14:44:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 110856 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp7035005ybm; Wed, 23 Aug 2017 07:45:10 -0700 (PDT) X-Received: by 10.84.215.204 with SMTP id g12mr3260828plj.410.1503499510849; Wed, 23 Aug 2017 07:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503499510; cv=none; d=google.com; s=arc-20160816; b=uc8Od5M1HCE6Fwa5m8I3+fmGHd0CEMwYoCmT2UrPG/+DDl/T1z5ExEuU0OfJjrZafW Sp7ffTgnmkoYKxi5p8csR+vhSxgJCHCEv6azY18HcqR2MM0qxqh+OtPgiWW31jESjqUQ UoHnHWoU+H1ZXDMmi5S8LezP3AdOoR6uWZXXy0qO0B/0/oIfJ6rfJNrfAHZjFEpuMQB+ NHPuCPHByuB/f8ttafDeHXT4gTOs3VjryQKgH09YPHSaxzOq5Ql+lserajnFRUkJP0PZ rm3JQ+8MnqCxa2Fg8YsfjZoszAnmMYfa0X50pF8aKpGAIFIO39BZlkyQlK0wzDpx2Btz vWLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=eoHdgHp3z3Qz90eTGDKhQs50mPnKBQxcdGJd8rJx9TI=; b=0A+NJpJbjaUAjPxRjyyxD4L7tyG6t7huV6DcURH+DgpLJM3taiqbYkmfMtqA5iIj20 CNDL4gIr/EGF6aAHshJWvwULgaX0pGI5knA/kHj4x+odwdxmtLs97A7RKhsyo4KUrB3Q 9CzSPdK3pcrlLKhqnLZyORfqs9OctSNPya1qagkjHBOAAYUZ9jGx894ZLKwhe55EgWcm +yl2EWfxsx4P1G0kLCZwQELY6czskmZGVlwU7AXLywMT6LxNgqJ7hGVJ9zN5SO0zCfU9 ZE274wXJUl61HuwnrfKLpj8fOJKjfwa5Iig6O9aKbN3X2thRaj3SGYJwfrJpxq+bB4xz Dfxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y38si1199844plh.1023.2017.08.23.07.45.10; Wed, 23 Aug 2017 07:45:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbdHWOpJ (ORCPT + 3 others); Wed, 23 Aug 2017 10:45:09 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58953 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985AbdHWOpI (ORCPT ); Wed, 23 Aug 2017 10:45:08 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0LZf8m-1dGjRr3FV6-00lR2X; Wed, 23 Aug 2017 16:45:03 +0200 From: Arnd Bergmann To: Tony Lindgren , Lee Jones Cc: Arnd Bergmann , Roger Quadros , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mfd: omap-usb-tll: fix register offsets Date: Wed, 23 Aug 2017 16:44:51 +0200 Message-Id: <20170823144501.2292044-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:v/FlDQBHTHp6xgfo4jO5tt8tsYlsZjDzvNV+ILBJ84nsCeCh8aU mebAsQcPDZRkkWMdNGHq8qUll1dTGIEIGys9ggZPiutKa3b/K2g2Y7NzKVGxIBUJsBhD2oo F3Q3vPK2434pGosLiVNPnVTF3BVvwMvmSk+4a9OVGJMMwtpz+yaCNiMuVZ22twyLqEbyDcF 4YRp8fGHSmdUfOYessquw== X-UI-Out-Filterresults: notjunk:1; V01:K0:kigLcC49yfI=:lgn65Z7d2MTFs/ettrWM81 J3FwTCpMywMwg8mFL6BSlrzvUSCBO8pOzZQ8JjBcSmE72xDUWbZi0ovZ/aIq1qS7x0KSVb7Ok K9gPu1B0KjPCHbphEfce7VSXSE9Zy42VCVFo2eYj1triRe5S3bEDCRS9lwsSAlbB2VI0nSLNH qxoQbTDpir/DFdA83wWGBXuTOq4Dg1qxtCGK+RKAF7fY2BIdeLt1/wrM4ERkcqWEA43QKKIrm p4rKVcM9riP0vVjaNR5vCS7UzdGQphY/5Bl6G2QQ0GFGkPlxFU3kLQBXTDP+tndp45tDROqdR 3wBZEnMs93iRLwe/AhdTs7iScqmbhFvtZsf9J10Sd7s+wWuDWSRRFN+wTUUhCoGVIDS9KJLYX Xn99p7ANmC4LG8YHgyO+N0Fh5xaacv7sNKxqHi3iBdF46r/1cH/kqEmMcqtExdFDuB2NMwe1b o2b5THK9wxAyOy54ZZsQb/EVwwcdZRvyLrjofx1ioTbi6Gdtq/nTxAj180xRolCjDJi01bYG0 XW5PLvolVT6t5Q5DP6nGmgpXmKDjPNV8LUhZ8zjGsbxenECSbNySIRpYEAgQTlLMjQUtmUykj ZF6Nyjho7ZmJ0mbAsArhTR0WONkU6yK00NHte11wiaUtN21EM8Ztt3GdDa4M0crmUK4/VZj03 POYavGGEwSLBWXwAQfzzPNHPMhTBdk8huidw3tvPcXFRFlyvTm8XDUsKqU95LF5WCfpI9Q1AM EPkiczSsFJPvRgw2/f1UT+FBTHhs35jV5P1C5g== Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org gcc-8 notices that the register number calculation is wrong when the offset is an 'u8' but the number is larger than 256: drivers/mfd/omap-usb-tll.c: In function 'omap_tll_init': drivers/mfd/omap-usb-tll.c:90:46: error: overflow in conversion from 'int' to 'u8 {aka unsigned char}' chages value from 'i * 256 + 2070' to '22' [-Werror=overflow] This addresses it by always using a 32-bit offset number for the register. This is apparently an old problem that previous compilers did not find. Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver") Signed-off-by: Arnd Bergmann --- drivers/mfd/omap-usb-tll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 6f5300b0eb31..44a5d66314c6 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -131,12 +131,12 @@ static inline u32 usbtll_read(void __iomem *base, u32 reg) return readl_relaxed(base + reg); } -static inline void usbtll_writeb(void __iomem *base, u8 reg, u8 val) +static inline void usbtll_writeb(void __iomem *base, u32 reg, u8 val) { writeb_relaxed(val, base + reg); } -static inline u8 usbtll_readb(void __iomem *base, u8 reg) +static inline u8 usbtll_readb(void __iomem *base, u32 reg) { return readb_relaxed(base + reg); }