From patchwork Thu Aug 24 21:23:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Reisner X-Patchwork-Id: 110950 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp29771qge; Thu, 24 Aug 2017 14:26:39 -0700 (PDT) X-Received: by 10.99.169.25 with SMTP id u25mr7631419pge.128.1503609998760; Thu, 24 Aug 2017 14:26:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503609998; cv=none; d=google.com; s=arc-20160816; b=KaGD3W5cwPwCMjkymek/+kpukD5peApazCFn21SWiYZ6Jf661xT60fvPZobZ8XAWl7 hJYTu0h1vuCRXDbADNPnFG9rR3W2QGwTfeWiUG1WZDyVyVhNobAOW0d3J5riG5qb0kg/ egWEURKjTYBj33CUgE4FpZFyk0rWMPa56b6b+qWWiUGE1Db1KV7cKt1Ojr+fj313XxwR Y0nxpi7pmiHxTwTaMXfRioFk3/Wmnmpfvn1u/mmi8XioNzLy8h5xhmJ0d89C6Lf7UwsB SJ2PN87lXTLEpn8Vi8C1l8eskTV5AyCLcz1Z2jKhwLT54sQ9qkKmzhKww8VfZ4e6rhxv cQvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=cWHJnPcL9WelNF/PHHEyCRGl8Wuu12ilT4SV4WawV4o=; b=W7Ny+inlZ2N86IiI1pGmn68FOhpkbeXL+EiCH4hs48FawLryflWpyxnQA6pWYwaeNb q+wfjthn6udi6cOvCoCQ4/2jndWG6eAsGucvTpZfJgOL08IItRWRBYRpoi4fniKKx3Ge 74vFGoJOVETkCWQQUsCKJRPR+3wg7d9zH8aabrdR9tUc3tBHZzwSTwPdpTcU1yl1Gs90 PEp6BjqTu1BeaOa26jeOE9CpUhEMAxe0LiecXf1Un4hR2C8guG0JqAC35n8snuc9Mh6G JBX1+PXR2giY7oTh3nRE+IX/00h3n4fEOSujKDcRHOEz5d/sjMX8wUF7jEXffr60Z6zR 8PIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20150623.gappssmtp.com header.s=20150623 header.b=s0V8lAst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si3868624plm.791.2017.08.24.14.26.38; Thu, 24 Aug 2017 14:26:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20150623.gappssmtp.com header.s=20150623 header.b=s0V8lAst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754282AbdHXV0e (ORCPT + 26 others); Thu, 24 Aug 2017 17:26:34 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36719 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753924AbdHXVXg (ORCPT ); Thu, 24 Aug 2017 17:23:36 -0400 Received: by mail-wm0-f41.google.com with SMTP id z132so4595284wmg.1 for ; Thu, 24 Aug 2017 14:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cWHJnPcL9WelNF/PHHEyCRGl8Wuu12ilT4SV4WawV4o=; b=s0V8lAstzQzqGi6WESgDkCtBiN944hLIyVnmRMEQEHfqSKFpZMS6UNOZSwcJH4ywhR 43X86bYLihtpzFbtdG8aCd4/b7Ek2B1sKh+mxTscQUiyLRB+gHpjpg28bxlT9sydOvE4 lMBvbM2eIQ1B1P1I2AabaE1wOI6xXKgaPauB/qZJ361jMJ3s1EqChwABPnvmUYmo9R6C GVewpxhzT2q3ilqqvHZ+8BlHZ/jNX9kWH1mGpMEvUI9eeITAToaI+uBGVU1Z7soBWVu/ MWni5cxZDzPUCtTJlOS+UVrp38Bsx93AGTFvevZHjfvaXzqCRigFlK5ijMtS8K4WDRNP r93g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cWHJnPcL9WelNF/PHHEyCRGl8Wuu12ilT4SV4WawV4o=; b=JWS6ZTcfN/uf47SpN1OZaKtJrQFcXkCVd0vYlfL/Nv7u0nEHO07YCgivHw87z1++Qz XKEKmYWJGgTK4D8U2827M9CX0YgQWpemfHFT7dx1Z5CnV3nfeoka/VOd3VQNs489NUke 2ja03FAZxDEPZjgJdlRSpkHVQqq0AWTE4Jdt9X/FNT/j3qcVQT6dESRtluBFwnDv4FJE A1843Q2b58z+4qPb1ZeNo2G48N2LbOdxllt/SMXGhghKniSVZPAiUPyyJCcrXXfZ8mT0 8HVyrGTFi8nQ6V+SPEtZWvydPIkfZmRq5NaxS6Oz8T0aNwE8YWtBmjUN1543qCv+nK9h 94Aw== X-Gm-Message-State: AHYfb5iEiM39gLChtvaGmzaauCGyUAEOq5n7WMp57VtdPdaiBOyVMe9i iMvKTSC/clMHaSns X-Received: by 10.28.30.23 with SMTP id e23mr63232wme.187.1503609814870; Thu, 24 Aug 2017 14:23:34 -0700 (PDT) Received: from localhost.localdomain (91.141.1.130.wireless.dyn.drei.com. [91.141.1.130]) by smtp.gmail.com with ESMTPSA id l13sm7212058wmd.47.2017.08.24.14.23.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Aug 2017 14:23:34 -0700 (PDT) From: Philipp Reisner To: Jens Axboe , linux-kernel@vger.kernel.org Cc: drbd-dev@lists.linbit.com Subject: [PATCH 05/17] drbd: mark symbols static where possible Date: Thu, 24 Aug 2017 23:23:02 +0200 Message-Id: <1503609794-13233-6-git-send-email-philipp.reisner@linbit.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503609794-13233-1-git-send-email-philipp.reisner@linbit.com> References: <1503609794-13233-1-git-send-email-philipp.reisner@linbit.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baoyou Xie We get a few warnings when building kernel with W=1: drbd/drbd_receiver.c:1224:6: warning: no previous prototype for 'one_flush_endio' [-Wmissing-prototypes] drbd/drbd_req.c:1450:6: warning: no previous prototype for 'send_and_submit_pending' [-Wmissing-prototypes] drbd/drbd_main.c:924:6: warning: no previous prototype for 'assign_p_sizes_qlim' [-Wmissing-prototypes] .... In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg -- 2.7.4 diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index a3b2ee7..11f3852 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -923,7 +923,9 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device) } /* communicated if (agreed_features & DRBD_FF_WSAME) */ -void assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p, struct request_queue *q) +static void +assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p, + struct request_queue *q) { if (q) { p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q)); diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 1b3f439..2489667 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -1261,7 +1261,7 @@ struct one_flush_context { struct issue_flush_context *ctx; }; -void one_flush_endio(struct bio *bio) +static void one_flush_endio(struct bio *bio) { struct one_flush_context *octx = bio->bi_private; struct drbd_device *device = octx->device; diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index 72cb0bd..e48012d 100644 --- a/drivers/block/drbd/drbd_worker.c +++ b/drivers/block/drbd/drbd_worker.c @@ -203,7 +203,8 @@ void drbd_peer_request_endio(struct bio *bio) } } -void drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device *device) +static void +drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device *device) { panic("drbd%u %s/%u potential random memory corruption caused by delayed completion of aborted local request\n", device->minor, device->resource->name, device->vnr);