From patchwork Tue Aug 29 08:19:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanimir Varbanov X-Patchwork-Id: 111195 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp983684qge; Tue, 29 Aug 2017 01:20:53 -0700 (PDT) X-Received: by 10.84.217.221 with SMTP id d29mr83386plj.197.1503994853431; Tue, 29 Aug 2017 01:20:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503994853; cv=none; d=google.com; s=arc-20160816; b=Gv023yEzKoo9jd9jZGJi7nIaziTor3DB/UlYcMK1/LeeRRNfGqUchEblQxQPanZ1A/ xfkEdiTGD9iPPQ6zKSH1u2PTwiiae+2KsYz5uySFxmBZhffq2w41u1CDHnRVLJO1uzms xaYU38+Vh27hAihkorhSs8G6uOTVfb+3hqMWtfe/aAW3uZYdGmxoK6Y+oXpFiVQgFSoS Capt63WbOqKCjTPP32tTE1csGxEHEB2g+ng3/CamAZSalubrx6y91kcHQSyyY/TtzID2 rL9/3przkvvnBhA8a8DYzlAKNKX5IonbLoz5JF3CWEw6BfkLfnbW6oN9saZSg6tuq8H7 NjLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=v65A0gKr+4RO/UCXkWr5H85SfbSkYDoQUvUmwqeLT/E=; b=PuyX/XYw1UR8lSAOwLmYLI/ZZXQZRlSjKnAAyrxUpzcqtt1G/J2jz+Z4iKsIdgy4kp WdxchwfEwDmnxlYUFY8XDTgDX7dE2PJXwpZpCOFl6FGFQiwCToMorkXgYNVswhyW3FV4 qcNJ3seDW+s+QmjS5r5rqF+B8Z93TaLKVqFguLJSUbYkTTzs0vl2qqgjxLVrigoFH1d9 EqXQRPqXAqv4Qr0Xm40DF8OSbqk410ZrIX14fiUqHg52EUO5LOUtxfw1KWa1tBf0bfMH tdLzNmbMuhthDnKsPIxH7HWeIFUtRSJttfigOV3M0xooVvneTO7JDcW+sO5DxBNhYo7d 558g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ggqkivlH; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si2057888plm.728.2017.08.29.01.20.52; Tue, 29 Aug 2017 01:20:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ggqkivlH; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751306AbdH2IUt (ORCPT + 9 others); Tue, 29 Aug 2017 04:20:49 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36366 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbdH2IUp (ORCPT ); Tue, 29 Aug 2017 04:20:45 -0400 Received: by mail-wm0-f52.google.com with SMTP id b82so15890980wmd.1 for ; Tue, 29 Aug 2017 01:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=pNQZqPzM85rAX1iHxDdNFJQcYyEwddTRjEEsdB52DlU=; b=ggqkivlH46Kzwba8y1KwxDeUxOaIs/tPcC11N8M6SqFdaoCg3Atm8TqZ2rtyqurIMX +rmI7eOiAuT9NNmzQbqD0TpuE+XuQBtmyf3IzWwBq+i+Dlp37aZei4Kp7nJmrfPyfDdK DmEuwlt/6umT9BGNv7YqJzPEuU2I1x79nmn7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pNQZqPzM85rAX1iHxDdNFJQcYyEwddTRjEEsdB52DlU=; b=XB7ThhGLkQy1EipbZAGq301EhrE3T93nZ9QgH5dRgMMsIBGoX1EyXKi+khIelP3qhN y5YSmjJSv8WGbZHBA8KJPI49CVdpyIi1d3cveu4V/n6Dmi7AjYJ6O5VQWeGMBfTqUy3o Mi0EU1ZujDHujDuHFPwBL2jzzQaW0n0jT/mJ54N5Xt7EovzwT98jMoZkEEKCfp9eDayc yjX6Lq6kw4M9U1AzG4tCD/+Fvnw0mh6mCav6IjL4+lqgcJIL/nckI8VYEyXwY36qnjCw MjOj23ZPZOjzLVrwH4WHhaGoli+oAhyAYvbx/cmWUPVEf8C4ZfiQ/JWVXlbndUAHDVJy ppQw== X-Gm-Message-State: AHYfb5hudaVVX6jts+DlnUaqgtp6xYDeyimzKfIK7rCM09Eeeg3fhv+k r0sQjFqAZ6Qzm+jW X-Received: by 10.28.107.77 with SMTP id g74mr348321wmc.48.1503994843964; Tue, 29 Aug 2017 01:20:43 -0700 (PDT) Received: from localhost.localdomain ([37.157.136.206]) by smtp.gmail.com with ESMTPSA id u10sm856033wmf.25.2017.08.29.01.20.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 01:20:43 -0700 (PDT) From: Stanimir Varbanov To: Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Stanimir Varbanov Subject: [PATCH] media: venus: init registered list on streamoff Date: Tue, 29 Aug 2017 11:19:43 +0300 Message-Id: <20170829081943.29277-1-stanimir.varbanov@linaro.org> X-Mailer: git-send-email 2.11.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add missing init_list_head for the registered buffer list. Absence of the init could lead to a unhandled kernel paging request as below, when streamon/streamoff are called in row. [338046.571321] Unable to handle kernel paging request at virtual address fffffffffffffe00 [338046.574849] pgd = ffff800034820000 [338046.582381] [fffffffffffffe00] *pgd=00000000b60f5003[338046.582545] , *pud=00000000b1f31003 , *pmd=0000000000000000[338046.592082] [338046.597754] Internal error: Oops: 96000004 [#1] PREEMPT SMP [338046.601671] Modules linked in: venus_enc venus_dec venus_core usb_f_ecm g_ether usb_f_rndis u_ether libcomposite ipt_MASQUERADE nf_nat_masquerade_ipv4 arc4 wcn36xx mac80211 btqcomsmd btqca iptable_nat nf_co] [338046.662408] CPU: 0 PID: 5433 Comm: irq/160-venus Tainted: G W 4.9.39+ #232 [338046.668024] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [338046.675268] task: ffff80003541cb00 task.stack: ffff800026e20000 [338046.682097] PC is at venus_helper_release_buf_ref+0x28/0x88 [venus_core] [338046.688282] LR is at vdec_event_notify+0xe8/0x150 [venus_dec] [338046.695029] pc : [] lr : [] pstate: a0000145 [338046.701256] sp : ffff800026e23bc0 [338046.708494] x29: ffff800026e23bc0 x28: 0000000000000000 [338046.718853] x27: ffff000000afd4f8 x26: ffff800031faa700 [338046.729253] x25: ffff000000afd790 x24: ffff800031faa618 [338046.739664] x23: ffff800003e18138 x22: ffff800002fc9810 [338046.750109] x21: ffff800026e23c28 x20: 0000000000000001 [338046.760592] x19: ffff80002a13b800 x18: 0000000000000010 [338046.771099] x17: 0000ffffa3d01600 x16: ffff000008100428 [338046.781654] x15: 0000000000000006 x14: ffff000089045ba7 [338046.792250] x13: ffff000009045bb6 x12: 00000000004f37c8 [338046.802894] x11: 0000000000267211 x10: 0000000000000000 [338046.813574] x9 : 0000000000032000 x8 : 00000000dc400000 [338046.824274] x7 : 0000000000000000 x6 : ffff800031faa728 [338046.835005] x5 : ffff80002a13b850 x4 : 0000000000000000 [338046.845793] x3 : fffffffffffffdf8 x2 : 0000000000000000 [338046.856602] x1 : 0000000000000003 x0 : ffff80002a13b800 Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 68933d208063..9b2a401a4891 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -682,6 +682,7 @@ void venus_helper_vb2_stop_streaming(struct vb2_queue *q) hfi_session_abort(inst); load_scale_clocks(core); + INIT_LIST_HEAD(&inst->registeredbufs); } venus_helper_buffers_done(inst, VB2_BUF_STATE_ERROR);